beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6
ladybird/Meta/Lagom/ReadMe.md

173 lines
8.6 KiB
Markdown
Raw Permalink Normal View History

Lagom: Import the beginnings of a "port" of Serenity libs for the outside. The C++ facilities of Serenity are getting pretty comfortable, and I'd like to take them with me to projects outside the system. Let's make it a bit easier to do that by bundling AK and LibCore (for now) into a portable library called "Lagom". :^)
2019-07-25 09:56:08 +00:00
# Lagom
Documentation: Reorganize Lagom README and update fuzzer documentation Add some prose to the introduction of Lagom about how we use it. Also, move the section on including Lagom in other projects above the fuzzer documentation. Remove the explicit cmake commands from the Fuzzer documentation, as the script should be the source of truth.
2023-02-26 02:07:51 +00:00
The Serenity C++ libraries, for other Operating Systems.
Lagom: Import the beginnings of a "port" of Serenity libs for the outside. The C++ facilities of Serenity are getting pretty comfortable, and I'd like to take them with me to projects outside the system. Let's make it a bit easier to do that by bundling AK and LibCore (for now) into a portable library called "Lagom". :^)
2019-07-25 09:56:08 +00:00
## About
If you want to bring the comfortable Serenity classes with you to another system, look no further. This is basically a "port" of the `AK` and `LibCore` libraries to generic \*nix systems.
*Lagom* is a Swedish word that means "just the right amount." ([Wikipedia](https://en.wikipedia.org/wiki/Lagom))
Lagom: Add a note on how to build the fuzzers to readme
2020-07-13 18:57:59 +00:00
Documentation: Reorganize Lagom README and update fuzzer documentation Add some prose to the introduction of Lagom about how we use it. Also, move the section on including Lagom in other projects above the fuzzer documentation. Remove the explicit cmake commands from the Fuzzer documentation, as the script should be the source of truth.
2023-02-26 02:07:51 +00:00
Lagom is used by the Serenity project in the following ways:
- [Build tools](./Tools) required to build Serenity itself using Serenity's own C++ libraries are in Lagom.
Documentation: Combine testing documentation together Bring together the docs on running tests, with the ones on writing them which were hidden in Browser/Patterns.md I've made a few adjustments while I was at it, because RunningTests.md was a bit outdated and didn't mention `Meta/ladybird.sh test`. It's possible they're still outdated and wrong, but I'm not familiar enough with that area to know.
2024-10-22 14:18:06 +00:00
- [Unit tests](../../Documentation/Testing.md) in CI are built using the Lagom build for host systems to ensure portability.
Documentation: Reorganize Lagom README and update fuzzer documentation Add some prose to the introduction of Lagom about how we use it. Also, move the section on including Lagom in other projects above the fuzzer documentation. Remove the explicit cmake commands from the Fuzzer documentation, as the script should be the source of truth.
2023-02-26 02:07:51 +00:00
- [Continuous fuzzing](#fuzzing-on-oss-fuzz) is done with the help of OSS-fuzz using the Lagom build.
Everywhere: Move the Ladybird folder to UI
2024-11-09 17:50:33 +00:00
- [The Ladybird browser](../../README.md) uses Lagom to provide LibWeb and LibJS for non-Serenity systems.
Meta: Update Lagom ReadMe links to the Ladybird LibJS website Also remove references to the web REPL as we no longer build that.
2024-07-07 09:36:30 +00:00
- [ECMA 262 spec tests](https://ladybirdbrowser.github.io/libjs-website/test262) for LibJS are run per-commit and tracked on [LibJS website](https://ladybirdbrowser.github.io/libjs-website/).
- [Wasm spec tests](https://ladybirdbrowser.github.io/libjs-website/wasm) for LibWasm are run per-commit and tracked on [LibJS website](https://ladybirdbrowser.github.io/libjs-website/).
Documentation: Reorganize Lagom README and update fuzzer documentation Add some prose to the introduction of Lagom about how we use it. Also, move the section on including Lagom in other projects above the fuzzer documentation. Remove the explicit cmake commands from the Fuzzer documentation, as the script should be the source of truth.
2023-02-26 02:07:51 +00:00
## Using Lagom in an External Project
It is possible to use Lagom for your own projects outside of Serenity too!
CI: Pull test262 runner from SerenityOS/libjs-test262
2023-08-06 06:51:52 +00:00
An example of this in use can be found in the [LibJS test262 runner](https://github.com/SerenityOS/libjs-test262).
Documentation: Reorganize Lagom README and update fuzzer documentation Add some prose to the introduction of Lagom about how we use it. Also, move the section on including Lagom in other projects above the fuzzer documentation. Remove the explicit cmake commands from the Fuzzer documentation, as the script should be the source of truth.
2023-02-26 02:07:51 +00:00
To implement this yourself:
CI: Pull test262 runner from SerenityOS/libjs-test262
2023-08-06 06:51:52 +00:00
- Download a copy of [SerenityOS/libjs-test262/cmake/FetchLagom.cmake](https://github.com/SerenityOS/libjs-test262/blob/7832c333c1504eecf1c5f9e4247aa6b34a52a3be/cmake/FetchLagom.cmake) and place it wherever you wish
Documentation: Reorganize Lagom README and update fuzzer documentation Add some prose to the introduction of Lagom about how we use it. Also, move the section on including Lagom in other projects above the fuzzer documentation. Remove the explicit cmake commands from the Fuzzer documentation, as the script should be the source of truth.
2023-02-26 02:07:51 +00:00
- In your root `CMakeLists.txt`, add the following commands:
```cmake
include(FetchContent)
include(cmake/FetchLagom.cmake) # If you've placed the file downloaded above differently, be sure to reflect that in this command :^)
```
- In addition, you will need to also add some compile options that Serenity uses to ensure no warnings or errors:
```cmake
AK: Fix Clang 18 `-Wdeprecated-literal-operator` warning The proper syntax for defining user-defined literals does not require a space between the `operator""` token and the operator name: > error: identifier 'sv' preceded by whitespace in a literal operator > declaration is deprecated
2023-08-17 16:27:39 +00:00
add_compile_options(-Wno-literal-suffix) # AK::StringView defines operator""sv, which GCC complains does not have an underscore.
Documentation: Reorganize Lagom README and update fuzzer documentation Add some prose to the introduction of Lagom about how we use it. Also, move the section on including Lagom in other projects above the fuzzer documentation. Remove the explicit cmake commands from the Fuzzer documentation, as the script should be the source of truth.
2023-02-26 02:07:51 +00:00
add_compile_options(-fno-gnu-keywords) # JS::Value has a method named typeof, which also happens to be a GNU keyword.
```
Now, you can link against Lagom libraries.
Things to keep in mind:
- You should prefer to use a library's `Lagom::` alias when linking
- Example: `Lagom::Core` vs `LibCore`
- If your application has name clashes with any names in AK, you may have to define `USING_AK_GLOBALLY=0` for the files that have visibility to both sets of headers.
Lagom: Add a note on how to build the fuzzers to readme
2020-07-13 18:57:59 +00:00
## Fuzzing
Lagom: Mention OSS-Fuzz in ReadMe We added OSS-Fuzz integration in #4154, but documentation about it is spread across several pull requests, IRC, and issues. Let's collect the important bits in the ReadMe.
2020-11-29 18:26:51 +00:00
Lagom can be used to fuzz parts of SerenityOS's code base. Fuzzers can be run locally, and they also run continuously on OSS-Fuzz.
### Fuzzing locally
Documentation: Reorganize Lagom README and update fuzzer documentation Add some prose to the introduction of Lagom about how we use it. Also, move the section on including Lagom in other projects above the fuzzer documentation. Remove the explicit cmake commands from the Fuzzer documentation, as the script should be the source of truth.
2023-02-26 02:07:51 +00:00
Lagom can be used to fuzz parts of SerenityOS's code base. This requires building with `clang`, so it's convenient to use a different build directory for that. Fuzzers work best with Address Sanitizer enabled. The fuzzer build requires code generators to be pre-built without fuzzing in a two stage build.
To build with LLVM's libFuzzer, invoke the ``BuildFuzzers.sh`` script with no arguments.
Lagom: Add two-stage build for Fuzzers to enable fuzzing generated code This allows us to fuzz the generated unicode and timezone database helpers, and to fuzz things like LibJS using Fuzzilli to get proper coverage of our unicode handling code. Update the Azure CI to use the new two-stage build as well, and cleanup some unused CMake options there.
2022-02-19 23:09:40 +00:00
```sh
Documentation: Reorganize Lagom README and update fuzzer documentation Add some prose to the introduction of Lagom about how we use it. Also, move the section on including Lagom in other projects above the fuzzer documentation. Remove the explicit cmake commands from the Fuzzer documentation, as the script should be the source of truth.
2023-02-26 02:07:51 +00:00
./BuildFuzzers.sh
./Build/lagom-fuzzers/FuzzSomething # The full list can be found in Fuzzers/CMakeLists.txt
Lagom: Add two-stage build for Fuzzers to enable fuzzing generated code This allows us to fuzz the generated unicode and timezone database helpers, and to fuzz things like LibJS using Fuzzilli to get proper coverage of our unicode handling code. Update the Azure CI to use the new two-stage build as well, and cleanup some unused CMake options there.
2022-02-19 23:09:40 +00:00
```
Lagom: Add a note on how to build the fuzzers to readme
2020-07-13 18:57:59 +00:00
Meta+Documentation: Require Xcode 14.3 or Clang 14 for the host compiler There have been multiple reports of Xcode 14.0 (based on upstream LLVM 14) segfaulting when compiling `LibCore/Process.cpp`. Let's require Xcode 14.3, which is a known good version based on LLVM 15. Note that Xcode 14.3 requires macOS Ventura, so users of Monterey or older are expected to get Homebrew Clang instead. Homebrew Clang 13 also suffers from the same crash. Although I have not tested on Linux, the backtrace points to the middle-end, so x86_64 is also likely to be affected. LLVM 14 was released 14 months ago, so it's not an unreasonable requirement.
2023-05-21 09:04:47 +00:00
(Note that we require clang >= 14, see the pick_clang() function in the script for the paths that are searched)
Fuzzing: Update build instructions The project needs clang-12, which is not on all systems the default (e.g. Debian Testing).
2021-10-21 18:20:51 +00:00
Lagom: Add an option for standalone fuzzers to BuildFuzzers.sh This builds simple fuzzing binaries without any oss-fuzz specific configuration and without any LibFuzzer instrumentation.
2023-04-13 14:22:03 +00:00
To build fuzzers without any kind of default instrumentation, pass the ``--standalone`` flag to ``BuildFuzzers.sh``:
```sh
./BuildFuzzers.sh --standalone
# This binary will read a single test input from a given filename (or, if no filename is given, from stdin) and exit.
./Build/lagom-fuzzers-standalone/Fuzzers/FuzzSomething
```
CMake: Remove ENABLE_LAGOM_LIBWEB and ENABLE_LAGOM_LADYBIRD options
2024-06-06 00:23:49 +00:00
The fuzzing build's CMake cache can be manipulated with commands like `cmake -B Build/fuzzers -S . -DENABLE_LAGOM_CCACHE=OFF`.
Meta: Document how to manipulate CMake caches for the fuzzing build
2023-02-24 23:50:33 +00:00
Meta: Describe how to analyze an LLVM fuzzer crash
2020-08-30 11:46:09 +00:00
Any fuzzing results (particularly slow inputs, crashes, etc.) will be dropped in the current directory.
Fuzzing: Update build instructions The project needs clang-12, which is not on all systems the default (e.g. Debian Testing).
2021-10-21 18:20:51 +00:00
Fuzzers work better if you give them a fuzz corpus, e.g. `./Fuzzers/FuzzBMPLoader ../Base/res/html/misc/bmpsuite_files/rgba32-61754.bmp` Pay attention that LLVM also likes creating new files, don't blindly commit them (yet)!
Meta: Describe how to analyze an LLVM fuzzer crash
2020-08-30 11:46:09 +00:00
Lagom: Augment fuzzing readme a bit Recommend using asan, don't set the c compiler (c++ compiler is sufficient), mention how to run on several cores, and how to get less output.
2020-11-13 20:40:29 +00:00
To run several fuzz jobs in parallel, pass `-jobs=24 -workers=24`.
To get less log output, pass `-close_fd_mask=3` -- but that but hides assertion messages. Just `1` only closes stdout.
It's good to move overzealous log output behind `FOO_DEBUG` macros.
Documentation: Reorganize Lagom README and update fuzzer documentation Add some prose to the introduction of Lagom about how we use it. Also, move the section on including Lagom in other projects above the fuzzer documentation. Remove the explicit cmake commands from the Fuzzer documentation, as the script should be the source of truth.
2023-02-26 02:07:51 +00:00
Using other fuzzers is possible, as demonstrated by the OSS-fuzz build. Doing so likely requires setting CFLAGS and CXXFLAGS
on the second stage of the CMake build, or in your environment.
Meta: Document fuzz dump
2020-11-29 21:49:00 +00:00
### Keeping track of interesting testcases
There are many quirky files that exercise a lot of interesting edge cases.
We should probably keep track of them, somewhere.
Meta: Update Documentation and CI for repo move
2024-05-30 21:06:21 +00:00
We have a [bmp suite and a jpg suite and several others](https://github.com/LadybirdWebBrowser/ladybird/tree/master/Base/res/html/misc).
Meta: Document fuzz dump
2020-11-29 21:49:00 +00:00
They are GPL'ed, and therefore not quite as compatible with the rest of Serenity.
That's probably not a problem, but keeping "our" testcases separate from those GPL'ed suits sounds like a good idea.
Meta: Fix broken external links Meta/Lagom/ReadMe.md never had any other name; not sure how that typo happened. The link to the non-existent directory is especially vexing because the text goes on to explain that we don't want such a directory to exist. Found by running markdown-checker, and 'wget'ing all external links.
2021-10-04 18:39:51 +00:00
We could keep those testcases somewhere else in the repository, like a `fuzz` directory.
Meta: Document fuzz dump
2020-11-29 21:49:00 +00:00
But fuzzing tends to generate more and more and more files, and they will blow up in size.
Especially if we keep all interesting testcases, which is exactly what I intend to do.
So we should keep the actual testcases out of the main serenity repo,
that's why we created https://github.com/SerenityOS/serenity-fuzz-corpora
Feel free to upload lots and lots files there, or use them for great good!
Lagom: Mention OSS-Fuzz in ReadMe We added OSS-Fuzz integration in #4154, but documentation about it is spread across several pull requests, IRC, and issues. Let's collect the important bits in the ReadMe.
2020-11-29 18:26:51 +00:00
### Fuzzing on OSS-Fuzz
Meta: Rename Fuzzer flags to `ENABLE_FUZZERS_{LIBFUZZER,OSSFUZZ}`
2022-03-29 14:31:51 +00:00
https://oss-fuzz.com/ automatically runs all fuzzers in the Fuzzers/ subdirectory whose name starts with "Fuzz" and which are added to the build in `Fuzzers/CMakeLists.txt` if `ENABLE_FUZZERS_OSSFUZZ` is set. Looking for "serenity" on oss-fuzz.com finds interesting links, in particular:
Lagom: Mention OSS-Fuzz in ReadMe We added OSS-Fuzz integration in #4154, but documentation about it is spread across several pull requests, IRC, and issues. Let's collect the important bits in the ReadMe.
2020-11-29 18:26:51 +00:00
* [known open bugs found by fuzzers](https://oss-fuzz.com/testcases?project=serenity&open=yes)
* [oss-fuzz bug tracker for these](https://bugs.chromium.org/p/oss-fuzz/issues/list?sort=-opened&can=1&q=proj:serenity)
* [coverage report](https://oss-fuzz.com/coverage-report/job/libfuzzer_asan_serenity/latest)
* [build logs](https://oss-fuzz-build-logs.storage.googleapis.com/index.html#serenity)
Documentation: Reorganize Lagom README and update fuzzer documentation Add some prose to the introduction of Lagom about how we use it. Also, move the section on including Lagom in other projects above the fuzzer documentation. Remove the explicit cmake commands from the Fuzzer documentation, as the script should be the source of truth.
2023-02-26 02:07:51 +00:00
Here's [Serenity's OSS-Fuzz Config](https://github.com/google/oss-fuzz/tree/master/projects/serenity). The configuration runs the `BuildFuzzers.sh` script with the `--oss-fuzz` argument inside the OSS-Fuzz docker container.
Lagom: Mention OSS-Fuzz in ReadMe We added OSS-Fuzz integration in #4154, but documentation about it is spread across several pull requests, IRC, and issues. Let's collect the important bits in the ReadMe.
2020-11-29 18:26:51 +00:00
Documentation: Reorganize Lagom README and update fuzzer documentation Add some prose to the introduction of Lagom about how we use it. Also, move the section on including Lagom in other projects above the fuzzer documentation. Remove the explicit cmake commands from the Fuzzer documentation, as the script should be the source of truth.
2023-02-26 02:07:51 +00:00
To run the OSS-fuzz build locally:
Lagom: Mention OSS-Fuzz in ReadMe We added OSS-Fuzz integration in #4154, but documentation about it is spread across several pull requests, IRC, and issues. Let's collect the important bits in the ReadMe.
2020-11-29 18:26:51 +00:00
```
git clone https://github.com/google/oss-fuzz/
cd oss-fuzz
python3 infra/helper.py build_image serenity
python3 infra/helper.py build_fuzzers serenity
```
These commands will put the fuzzers in `build/out/serenity` in the oss-fuzz repo. You can run the binaries in there individually, or simply type:
```
python3 infra/helper.py run_fuzzer serenity FUZZER_NAME
```
Meta: Add some more documentation on oss-fuzz
2021-01-20 19:58:01 +00:00
To build the fuzzers using the oss-fuzz build process, but against a local serenity checkout:
```
python3 infra/helper.py build_fuzzers serenity $HOME/src/serenity/
```
To run a shell in oss-fuzz's serenity docker image:
```
docker run -it gcr.io/oss-fuzz/serenity bash
```
Meta: Describe how to analyze an LLVM fuzzer crash
2020-08-30 11:46:09 +00:00
### Analyzing a crash
LLVM fuzzers have a weird interface. In particular, to see the help, you need to call it with `-help=1`, and it will ignore `--help` and `-help`.
To reproduce a crash, run it like this: `MyFuzzer crash-27480a219572aa5a11b285968a3632a4cf25388e`
To reproduce a crash in gdb, you want to disable various signal handlers, so that gdb sees the actual location of the crash:
```
Documentation: Update Lagom ReadMe with new fuzzer build instructions
2021-09-18 09:16:23 +00:00
$ gdb ./Fuzzers/FuzzBMP
Meta: Describe how to analyze an LLVM fuzzer crash
2020-08-30 11:46:09 +00:00
<... SNIP some output ...>
(gdb) run -handle_abrt=0 -handle_segv=0 crash-27480a219572aa5a11b285968a3632a4cf25388e
<... SNIP some output ...>
Everywhere: Hoist the Libraries folder to the top-level
2024-11-09 17:25:08 +00:00
FuzzBMP: ../../Libraries/LibGfx/Bitmap.cpp:84: Gfx::Bitmap::Bitmap(Gfx::BitmapFormat, const Gfx::IntSize &, Gfx::Bitmap::Purgeable): Assertion `m_data && m_data != (void*)-1' failed.
Meta: Describe how to analyze an LLVM fuzzer crash
2020-08-30 11:46:09 +00:00
Thread 1 "FuzzBMP" received signal SIGABRT, Aborted.
__GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
50 ../sysdeps/unix/sysv/linux/raise.c: File or directory not found.
(gdb)
```
Lagom/Fuzzers: Recommend enabling UBSan, extend instructions
2021-01-29 23:42:32 +00:00
UBSan doesn't always give useful information. use something like `export UBSAN_OPTIONS=print_stacktrace=1` to always print stacktraces.
You may run into annoying issues with the stacktrace:
```
==123456==WARNING: invalid path to external symbolizer!
==123456==WARNING: Failed to use and restart external symbolizer!
```
That means it couldn't find the executable `llvm-symbolizer`, which could be in your OS's package `llvm`.
`llvm-symbolizer-11` will [not be recognized](https://stackoverflow.com/a/42845444/).
Reference in a new issue Copy permalink