refactor: rename to AlbumSortByOptions

mobile/lib/modules/album/providers/album_sort_by_options.provider.dart

@@ -4,7 +4,7 @@ import 'package:immich_mobile/modules/settings/services/app_settings.service.dar
 import 'package:immich_mobile/shared/models/album.dart';
 import 'package:riverpod_annotation/riverpod_annotation.dart';
 
-part 'album_sort_options.provider.g.dart';
+part 'album_sort_by_options.provider.g.dart';
 
 typedef AlbumSortFn = List<Album> Function(List<Album> albums, bool isReverse);
 
@@ -42,10 +42,10 @@ class _AlbumSortHandlers {
 
   static const AlbumSortFn mostRecent = _sortByMostRecent;
   static List<Album> _sortByMostRecent(List<Album> albums, bool isReverse) {
-    final sorted = albums
+    final sorted = albums.where((a) => a.isRemote).sorted((a, b) {
-        .where((a) => a.isRemote)
+      if (a.endDate != null && b.endDate != null) {
-        .sortedBy((album) => album.endDate ?? DateTime(1000))
+        return a.endDate!.compareTo(b.endDate!);
-        .sorted((a, b) {
+      }
       if (a.endDate == null) return 1;
       if (b.endDate == null) return -1;
       return 0;
@@ -55,10 +55,10 @@ class _AlbumSortHandlers {
 
   static const AlbumSortFn mostOldest = _sortByMostOldest;
   static List<Album> _sortByMostOldest(List<Album> albums, bool isReverse) {
-    final sorted = albums
+    final sorted = albums.where((a) => a.isRemote).sorted((a, b) {
-        .where((a) => a.isRemote)
+      if (a.startDate != null && b.startDate != null) {
-        .sortedBy((album) => album.startDate ?? DateTime.now())
+        return a.startDate!.compareTo(b.startDate!);
-        .sorted((a, b) {
+      }
       if (a.startDate == null) return 1;
       if (b.startDate == null) return -1;
       return 0;
@@ -96,7 +96,7 @@ enum AlbumSortMode {
 }
 
 @riverpod
-class AlbumSortFunction extends _$AlbumSortFunction {
+class AlbumSortByOptions extends _$AlbumSortByOptions {
   @override
   AlbumSortMode build() {
     final sortOpt = ref

mobile/lib/modules/album/providers/album_sort_by_options.provider.g.dart

@@ -1,27 +1,28 @@
 // GENERATED CODE - DO NOT MODIFY BY HAND
 
-part of 'album_sort_options.provider.dart';
+part of 'album_sort_by_options.provider.dart';
 
 // **************************************************************************
 // RiverpodGenerator
 // **************************************************************************
 
-String _$albumSortFunctionHash() => r'2758b7d6274a1adc51e554e99cd6725bd875140f';
+String _$albumSortByOptionsHash() =>
+    r'8d22fa8b7cbca2d3d7ed20a83bf00211dc948004';
 
-/// See also [AlbumSortFunction].
+/// See also [AlbumSortByOptions].
-@ProviderFor(AlbumSortFunction)
+@ProviderFor(AlbumSortByOptions)
-final albumSortFunctionProvider =
+final albumSortByOptionsProvider =
-    AutoDisposeNotifierProvider<AlbumSortFunction, AlbumSortMode>.internal(
+    AutoDisposeNotifierProvider<AlbumSortByOptions, AlbumSortMode>.internal(
-  AlbumSortFunction.new,
+  AlbumSortByOptions.new,
-  name: r'albumSortFunctionProvider',
+  name: r'albumSortByOptionsProvider',
   debugGetCreateSourceHash: const bool.fromEnvironment('dart.vm.product')
       ? null
-      : _$albumSortFunctionHash,
+      : _$albumSortByOptionsHash,
   dependencies: null,
   allTransitiveDependencies: null,
 );
 
-typedef _$AlbumSortFunction = AutoDisposeNotifier<AlbumSortMode>;
+typedef _$AlbumSortByOptions = AutoDisposeNotifier<AlbumSortMode>;
 String _$albumSortOrderHash() => r'573dea45b4519e69386fc7104c72522e35713440';
 
 /// See also [AlbumSortOrder].

mobile/lib/modules/album/ui/add_to_album_sliverlist.dart

@@ -1,7 +1,7 @@
 import 'package:easy_localization/easy_localization.dart';
 import 'package:flutter/material.dart';
 import 'package:hooks_riverpod/hooks_riverpod.dart';
-import 'package:immich_mobile/modules/album/providers/album_sort_options.provider.dart';
+import 'package:immich_mobile/modules/album/providers/album_sort_by_options.provider.dart';
 import 'package:immich_mobile/modules/album/ui/album_thumbnail_listtile.dart';
 import 'package:immich_mobile/shared/models/album.dart';
 
@@ -22,7 +22,7 @@ class AddToAlbumSliverList extends HookConsumerWidget {
 
   @override
   Widget build(BuildContext context, WidgetRef ref) {
-    final albumSortMode = ref.watch(albumSortFunctionProvider);
+    final albumSortMode = ref.watch(albumSortByOptionsProvider);
     final albumSortIsReverse = ref.watch(albumSortOrderProvider);
     final sortedAlbums = albumSortMode.sortFn(albums, albumSortIsReverse);
     final sortedSharedAlbums =

mobile/lib/modules/album/views/library_page.dart

@@ -4,7 +4,7 @@ import 'package:flutter_hooks/flutter_hooks.dart';
 import 'package:hooks_riverpod/hooks_riverpod.dart';
 import 'package:immich_mobile/extensions/build_context_extensions.dart';
 import 'package:immich_mobile/modules/album/providers/album.provider.dart';
-import 'package:immich_mobile/modules/album/providers/album_sort_options.provider.dart';
+import 'package:immich_mobile/modules/album/providers/album_sort_by_options.provider.dart';
 import 'package:immich_mobile/modules/album/ui/album_thumbnail_card.dart';
 import 'package:immich_mobile/routing/router.dart';
 import 'package:immich_mobile/shared/providers/server_info.provider.dart';
@@ -19,7 +19,7 @@ class LibraryPage extends HookConsumerWidget {
         ref.watch(serverInfoProvider.select((v) => v.serverFeatures.trash));
     final albums = ref.watch(albumProvider);
     final isDarkTheme = context.isDarkTheme;
-    final albumSortOption = ref.watch(albumSortFunctionProvider);
+    final albumSortOption = ref.watch(albumSortByOptionsProvider);
     final albumSortIsReverse = ref.watch(albumSortOrderProvider);
 
     useEffect(
@@ -69,7 +69,7 @@ class LibraryPage extends HookConsumerWidget {
                 .read(albumSortOrderProvider.notifier)
                 .changeSortDirection(!albumSortIsReverse);
           } else {
-            ref.read(albumSortFunctionProvider.notifier).changeSortMode(value);
+            ref.read(albumSortByOptionsProvider.notifier).changeSortMode(value);
           }
         },
         child: Row(

mobile/lib/modules/album/views/sharing_page.dart

@@ -3,7 +3,7 @@ import 'package:flutter/material.dart';
 import 'package:flutter_hooks/flutter_hooks.dart';
 import 'package:hooks_riverpod/hooks_riverpod.dart';
 import 'package:immich_mobile/extensions/build_context_extensions.dart';
-import 'package:immich_mobile/modules/album/providers/album_sort_options.provider.dart';
+import 'package:immich_mobile/modules/album/providers/album_sort_by_options.provider.dart';
 import 'package:immich_mobile/modules/album/providers/shared_album.provider.dart';
 import 'package:immich_mobile/modules/album/ui/album_thumbnail_card.dart';
 import 'package:immich_mobile/modules/partner/providers/partner.provider.dart';
@@ -18,7 +18,7 @@ class SharingPage extends HookConsumerWidget {
 
   @override
   Widget build(BuildContext context, WidgetRef ref) {
-    final albumSortOption = ref.watch(albumSortFunctionProvider);
+    final albumSortOption = ref.watch(albumSortByOptionsProvider);
     final albumSortIsReverse = ref.watch(albumSortOrderProvider);
     final albums = ref.watch(sharedAlbumProvider);
     final sharedAlbums = albumSortOption.sortFn(albums, albumSortIsReverse);

mobile/test/album_sort_by_options_provider_test.dart

@@ -1,6 +1,6 @@
 import 'package:collection/collection.dart';
 import 'package:flutter_test/flutter_test.dart';
-import 'package:immich_mobile/modules/album/providers/album_sort_options.provider.dart';
+import 'package:immich_mobile/modules/album/providers/album_sort_by_options.provider.dart';
 import 'package:immich_mobile/shared/models/album.dart';
 import 'package:immich_mobile/shared/models/asset.dart';
 import 'package:immich_mobile/shared/models/user.dart';