724 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Perma Alesheikh	0b066b7529	remove unnessary conversions to itself ... Reasons: - Remove unnecessary steps. into() is called on String when the expected type is already String. Signed-off-by: Perma Alesheikh <me@prma.dev>	2024-01-09 22:12:31 +01:00
Perma Alesheikh	a6440aaa27	remove unnecessary into_owned ... Reasons: - Remove unnecessary step. - Avoid allocation when not needed. Signed-off-by: Perma Alesheikh <me@prma.dev>	2024-01-09 22:12:09 +01:00
Perma Alesheikh	2af1936ef8	use map_while to count for always err case. ... Reasons: - Filter_map will run forever if iterator only returns Err with lines. This is a possibility for "lines" iterators. - Map_while will break the mapping the moment the iterator returns error. Signed-off-by: Perma Alesheikh <me@prma.dev>	2024-01-09 22:11:23 +01:00
Perma Alesheikh	b417ad11a0	use if let instead of a map with only sideeffects ... Reasons: - Map is usually intended for transforming a value, and as is not idiomatically used for only doing side-effects and control flow. Signed-off-by: Perma Alesheikh <me@prma.dev>	2024-01-09 22:10:28 +01:00
Perma Alesheikh	0f097fe293	remove double referencing ... Reasons: - The compiler will immediately dereference the referenced reference. Signed-off-by: Perma Alesheikh <me@prma.dev>	2024-01-09 22:09:02 +01:00
Perma Alesheikh	945c567f35	remove reference over trait implemented type ... Reasons: - String already implement the AsRef<str>. Signed-off-by: Perma Alesheikh <me@prma.dev>	2024-01-09 22:08:41 +01:00
Perma Alesheikh	2ef477c225	remove needless update using default ... Reasons: - Every field is either turned-off entirely or assigned a value when it needs one. - Avoids the situation when a new field is introduced and is assigned a default value when it is not desired. Signed-off-by: Perma Alesheikh <me@prma.dev>	2024-01-09 22:07:37 +01:00
Perma Alesheikh	54287d40b8	replace into implementation with from ... Reasons: - From Implementation also implements Into trait. - Adhere to the recommendation by the Into trait's comments. Signed-off-by: Perma Alesheikh <me@prma.dev>	2024-01-09 22:04:26 +01:00
Clément DOUIN	bd1ac45a58	remove empty string from println call	2024-01-09 22:02:09 +01:00
Perma Alesheikh	0ff940871b	use char when replacing a single character ... Reasons: - More idiomatic use of string. Considering that they are constants, I don't anticipate any performance gains related to heap-allocation. Signed-off-by: Perma Alesheikh <me@prma.dev>	2024-01-09 21:55:20 +01:00
Perma Alesheikh	f7a7937cb1	use as_deref instead of as_ref for account.name ... Reasons: - More concise. - Avoids the need for map(String::str). Signed-off-by: Perma Alesheikh <me@prma.dev>	2024-01-09 21:54:21 +01:00
Perma Alesheikh	59fefd7c78	use or instead of or_else ... Reasons: - Closure is not needed. - Makes it more concise. Signed-off-by: Perma Alesheikh <me@prma.dev>	2024-01-09 21:49:33 +01:00
Perma Alesheikh	8016ecb5a0	define SendmailConfig once ... Reasons: - Makes the declaration more concicse. - Avoids the mutation. Signed-off-by: Perma Alesheikh <me@prma.dev>	2024-01-09 21:42:28 +01:00
Clément DOUIN	6fcdf7ea10	fix bad prompt_passwd for pgp config	2024-01-09 21:37:53 +01:00
Clément DOUIN	6f9f75cfd2	plug autoconfig to imap and smtp wizards	2024-01-09 21:36:17 +01:00
Clément DOUIN	b0d7e773dc	renamed sync feature to account-sync, put wizard stuff under feature	2024-01-09 09:28:45 +01:00
Perma Alesheikh	921194da5c	remove empty str inside println ... Reasons: - Functionally it has the same result. Signed-off-by: Perma Alesheikh <me@prma.dev>	2024-01-08 23:02:03 +01:00
Perma Alesheikh	95eed65193	use empty ok instead of wrapping empty expression ... Reasons: - It is more readable since the evaluated result is more explicit. Signed-off-by: Perma Alesheikh <me@prma.dev>	2024-01-08 23:01:52 +01:00
Perma Alesheikh	3cca9ac9e8	use static instead of const for lazy values ... Reasons: - Every time a const is referenced, a new instance of the Cell, Mutex, or AtomicXxxx is created, negating the purpose of using these types. To address this issue, the const value should be stored within a static item. Signed-off-by: Perma Alesheikh <me@prma.dev>	2024-01-08 23:01:41 +01:00
Perma Alesheikh	d2ad386eaa	use as as_deref instead of as_ref and mapping on str ... Reasons: - Make the code more direct and concise. Signed-off-by: Perma Alesheikh <me@prma.dev>	2024-01-08 23:01:26 +01:00
Perma Alesheikh	6173495cb6	use iter instead of into_iter ... Reasons: - This is functionally similar to into_iter since it is reference. - It does not consume the list. Signed-off-by: Perma Alesheikh <me@prma.dev>	2024-01-08 23:01:03 +01:00
Clément DOUIN	42226abc9c	improve contributing section	2024-01-08 22:47:08 +01:00
Clément DOUIN	161f35d20e	clean cargo features	2024-01-08 10:34:37 +01:00
Clément DOUIN	819bdc84b3	fix features warns and save sent message copy option	2024-01-08 00:33:07 +01:00
Clément DOUIN	a6b863759c	add one cargo feature per backend feature	2024-01-07 23:48:45 +01:00
Clément DOUIN	9ffac16e05	adjust readme matrix workspace name	2024-01-06 08:51:51 +01:00
Clément DOUIN	95c078c327	improve readme contributing section	2024-01-06 08:41:11 +01:00
Clément DOUIN	45ce05ec4d	fix typos	2024-01-05 21:59:41 +01:00
prma	38c8a67ddd	fix: remove printer message from completions command ... this way the output command can be used to source completion	2024-01-05 21:56:47 +01:00
Clément DOUIN	89fbb8a9db	update screenshot readme	2024-01-05 11:50:16 +01:00
Clément DOUIN	70fad9b1fd	fix default command	2024-01-03 22:49:39 +01:00
Clément DOUIN	0352e91e36	improve backend features management for every command	2024-01-03 12:58:44 +01:00
Clément DOUIN	a8c6756f56	fix envelope listing	2024-01-02 12:21:12 +01:00
Clément DOUIN	37c352ea7f	Merge pull request #463 from w3irdrobot/sendmail-fix ... allow account.sendmail when sendmail feature is on	2024-01-01 22:32:51 +01:00
Clément DOUIN	6af2342316	Merge pull request #464 from w3irdrobot/fix-ambiguous-email ... fix ambiguous email export	2024-01-01 22:30:45 +01:00
w3irdrobot	6b6e5cb1fa	fix ambiguous email export	2024-01-01 15:57:30 -05:00
w3irdrobot	77206b2326	allow account.sendmail when sendmail feature is on	2024-01-01 13:49:31 -05:00
Clément DOUIN	12e71a5ba8	improve release process	2024-01-01 16:22:30 +01:00
Clément DOUIN	ce2b292d2b	update license year	2024-01-01 00:31:19 +01:00
Clément DOUIN	be877f0b3e	fix linux, macos and windows release builds	2024-01-01 00:27:45 +01:00
Clément DOUIN	131acd6230	update flake deps, fix gh release interpreter	2023-12-31 11:05:08 +01:00
Clément DOUIN	fa2c6c44bc	prepare v1.0.0-beta	2023-12-31 09:24:42 +01:00
Clément DOUIN	a59d1ca2c6	refactor imap and smtp encryption options	2023-12-30 22:38:25 +01:00
Clément DOUIN	eee17f9173	fix oauth2 serde config namings	2023-12-29 22:33:15 +01:00
Clément DOUIN	bc36ce1255	add imap.watch.timeout example in config sample	2023-12-29 21:00:48 +01:00
Clément DOUIN	8d12528da6	add imap.watch.timeout option	2023-12-29 20:52:15 +01:00
Clément DOUIN	5ede53476b	change watch imap envelope idle algorithm	2023-12-26 16:45:32 +01:00
Clément DOUIN	cdf0a9a846	bump email-lib@0.18.5	2023-12-24 15:11:21 +01:00
Clément DOUIN	2351cfdd28	fix redundant copy saved	2023-12-20 16:43:33 +01:00
Clément DOUIN	92a94c8ff1	fix missing serde rename	2023-12-20 15:03:03 +01:00