Manav Rathi
34a8bdcf47
Remove unnecessary rounding
2024-05-20 10:15:41 +05:30
Manav Rathi
78420f65ab
Case
2024-05-20 10:09:41 +05:30
Manav Rathi
20dcf3e473
Annotate
2024-05-20 10:04:33 +05:30
Manav Rathi
476edd8cf5
Remove unused code paths
...
Only internal users come into such scenarios currently
2024-05-20 09:52:32 +05:30
Manav Rathi
b420eece38
[desktop] Add note about xdg-open bug on Ubuntu
...
Ref: https://github.com/electron/electron/issues/31485
2024-05-17 15:24:42 +05:30
Manav Rathi
af7c2edf98
Remove debugging lines
2024-05-17 14:21:37 +05:30
Manav Rathi
f61b5118ba
Add a CORS workaround for uploads to arbitrary testing buckets
...
Workaround for the following error when trying to upload from the desktop app to a staging bucket
> ente://app/gallery:1 Access to XMLHttpRequest at
'https://xxx-staging-xxx.s3.xxx.backblazeb2.com/ ...' from origin 'ente://app'
has been blocked by CORS policy: Response to preflight request doesn't pass
access control check: The 'Access-Control-Allow-Origin' header has a value
'null' that is not equal to the supplied origin.
2024-05-17 11:56:10 +05:30
Manav Rathi
4160be30b9
Fix tag
2024-05-17 10:14:29 +05:30
Manav Rathi
b9c4682adc
[desktop] Fix warning on windows auto update
...
> disableWebInstaller is set to false, you should set it to true if you do not
plan on using a web installer. This will default to true in a future version.
2024-05-16 20:54:24 +05:30
Manav Rathi
17f3839e88
[desktop] Update to electron 30.0.6
...
https://github.com/electron/electron/releases/tag/v30.0.6
2024-05-16 15:51:15 +05:30
Manav Rathi
e430ee3606
lf
2024-05-16 15:49:13 +05:30
Manav Rathi
eaa0ddc468
Same for desktop
2024-05-16 15:46:43 +05:30
Manav Rathi
43a3df5bbf
embeddings
2024-05-16 13:43:18 +05:30
Manav Rathi
f64d4943ed
log.warn
2024-05-15 15:57:45 +05:30
Manav Rathi
e88f7fde36
Upgrade to Electron 30.0.5 to fix Linux crash when maximizing window
...
https://github.com/electron/electron/pull/42179
2024-05-15 15:43:46 +05:30
Manav Rathi
ab89bc4816
Reorder and attach logs
2024-05-15 15:41:46 +05:30
Manav Rathi
45183422e2
[web] Lint concurrently
2024-05-15 13:59:10 +05:30
Manav Rathi
901c401d2a
Et
2024-05-15 13:43:24 +05:30
Manav Rathi
176431ba1f
Electron side
2024-05-15 13:18:03 +05:30
Manav Rathi
78a649cae3
[desktop] Ignore imagemagick on ARM in one more place
2024-05-14 19:47:45 +05:30
Manav Rathi
859adea2eb
Mark completed TODO
2024-05-13 20:17:15 +05:30
Manav Rathi
bf7c97c006
Remove ffmpeg timeout
2024-05-13 20:03:21 +05:30
Manav Rathi
0b797cebed
Trace the error
2024-05-13 18:50:12 +05:30
Manav Rathi
5e9e1623ae
Clear input file
2024-05-13 18:45:35 +05:30
Manav Rathi
6553976beb
Fix time reporting
2024-05-13 18:37:42 +05:30
Manav Rathi
3c7c14e11c
conv
2024-05-13 16:18:03 +05:30
Manav Rathi
0e3649f9b6
Scaffold
2024-05-13 15:50:22 +05:30
Manav Rathi
1b8b840ecf
Process
2024-05-13 15:37:35 +05:30
Manav Rathi
b82507f74c
Handle logout
2024-05-13 15:00:21 +05:30
Manav Rathi
11811053fa
Web
2024-05-13 14:40:32 +05:30
Manav Rathi
a21cc51eb0
Plan
2024-05-13 14:20:44 +05:30
Manav Rathi
b7292f2629
Add a log line for debugging
2024-05-13 11:35:24 +05:30
Manav Rathi
957c2a64df
Keep the order in the documentation examples
...
https://imagemagick.org/Usage/thumbnails/
2024-05-13 11:33:25 +05:30
Manav Rathi
631b1772e4
Fix mangled parameter being passed to imagemagick
...
Similar: https://github.com/ente-io/ente/pull/1175
2024-05-13 11:31:34 +05:30
Manav Rathi
9ca8ef9e74
The bundled binary is x86 only, bail out early on ARM
...
Error: Error invoking remote method 'generateImageThumbnail': Error: Command failed: '/tmp/.mount_ente-1lYbIWw/resources/image-magick' '/home/m/Downloads/VM/IMG_4484.WEBP' -auto-orient -define 'jpeg:size=1440x1440' -thumbnail '720x720>' -unsharp '0x.5' -quality 70 '/tmp/ente/9aNsp1FdLe.jpeg'
/bin/sh: 1: /tmp/.mount_ente-1lYbIWw/resources/image-magick: Exec format error
The binary is from https://github.com/ente-io/ImageMagick/
2024-05-13 11:22:13 +05:30
Manav Rathi
644e67f648
--no-sandbox does not prevent the SUID abort when added from JS
...
From https://github.com/toeverything/AFFiNE/issues/6722#issuecomment-2081805954
> Disable sandboxing entirely by launching with --no-sandbox. Adding this
argument from JS is unfortunately insufficient, as the GPU process is launched
before the main process JS is run.
Ref:
* https://github.com/electron/electron/issues/17972
2024-05-13 10:19:44 +05:30
Manav Rathi
3ba7bcbf06
Add the other CHANGELOG entries
2024-05-12 20:00:48 +05:30
Manav Rathi
5b92133aae
[desktop] Pass the SUID workaround correctly
...
The flag itself is documented as supported:
https://www.electronjs.org/docs/latest/api/command-line-switches
I was just passing it incorrectly (hopefully).
2024-05-12 18:41:10 +05:30
Manav Rathi
d188abfe65
Add a workaround for the SUID sandbox helper error on Linux
...
I am able to reproduce this on Ubuntu 24 ARM.
> The SUID sandbox helper binary was found, but is not configured correctly.
See:
- https://github.com/electron/electron/issues/17972
- https://stackoverflow.com/questions/63780918/building-electron-linux-distro-the-suid-sandbox-helper-binary-was-found-but-i
2024-05-12 15:35:18 +05:30
Manav Rathi
2a3bf41937
Update instructions
2024-05-11 19:19:56 +05:30
Manav Rathi
c7aa5ccd1f
Document log paths
2024-05-11 18:56:37 +05:30
Manav Rathi
be329bc1c9
electron 30.0.3
...
https://github.com/electron/electron/releases/tag/v30.0.3
Fixed an issue where fs.createWriteStream could write out of order
https://github.com/electron/electron/pull/42046
Fixed crash after upgrade on Linux
https://github.com/electron/electron/pull/42064
2024-05-11 18:52:07 +05:30
Manav Rathi
1b3e11f713
Log errors/warnings to the console always
2024-05-10 11:00:13 +05:30
Manav Rathi
b22361d652
yarn lint-fix
2024-05-08 12:12:03 +05:30
Manav Rathi
4db07149ae
[desktop] Don't invoke electron-builder twice on CI
2024-05-08 12:10:20 +05:30
Manav Rathi
7e0ef23bc1
yarn lint-fix
2024-05-08 11:20:28 +05:30
Manav Rathi
212f863733
Restore the yarn-timeout workaround
...
e.g. see a recent build failures:
https://github.com/ente-io/photos-desktop/actions/runs/8996782367/job/24713793588
there was another one recently. both of these were on the Windows runner, in one
case the message was:
info There appears to be trouble with your network connection. Retrying...
in another case the issue manifested later
D:\a\photos-desktop\photos-desktop\web\node_modules\date-fns\formatISO\index.js:11
/**
SyntaxError: Invalid or unexpected token
at internalCompileFunction (node:internal/vm:128:18)
at wrapSafe (node:internal/modules/cjs/loader:1280:20)
but retrying fixed it, so I'm counting it as a broken package install.
2024-05-08 11:17:15 +05:30
Manav Rathi
a07d999b74
Clarify
2024-05-08 10:26:21 +05:30
Manav Rathi
771a02c36b
rc
2024-05-08 10:15:12 +05:30
Manav Rathi
145a7cee2a
yarn lint-fix
2024-05-08 10:10:34 +05:30
