beenull/ente
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[mob][photos] Fix BG task not getting killed (#1608)

Browse source 
## Description

`BackgroundFetch.finish(taskId)` doesn't seems to be killing the BG
task.
Explicitly killing the Isolate does the work.
This commit is contained in:
Vishnu Mohandas 2024-05-03 19:56:35 +05:30 committed by GitHub
commit 7f6e8228af
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
mobile/lib/main.dart
View file

@ -1,5 +1,6 @@
import 'dart:async';
import 'dart:io';
import "dart:isolate";
import "package:adaptive_theme/adaptive_theme.dart";
import 'package:background_fetch/background_fetch.dart';
@ -330,10 +331,15 @@ Future<void> _killBGTask([String? taskId]) async {
DateTime.now().microsecondsSinceEpoch,
);
final prefs = await SharedPreferences.getInstance();
await prefs.remove(kLastBGTaskHeartBeatTime);
if (taskId != null) {
BackgroundFetch.finish(taskId);
}
///Band aid for background process not getting killed. Should migrate to using
///workmanager instead of background_fetch.
Isolate.current.kill();
}
Future<void> _firebaseMessagingBackgroundHandler(RemoteMessage message) async {