Remove GitHub deployments

Not integrating GitHub deployments for now since creating a deployment
(anywhere) causes "This branch has not been deployed" message to appear on
unrelated branches.

Also, the Discord /github webhook doesn't support deployment status events
anyway - Discord accepts and responds to the webhook with a 204 but it doesn't
appear in the channel. This is not a big issue, we can easily massage the
payload ourselves, but just mentioning this for posterity. Refs:

* [Corresponding issue on Discord](https://github.com/discord/discord-api-docs/issues/6203#issuecomment-1608151265)

* [A general recipe](https://gist.github.com/jagrosh/5b1761213e33fc5b54ec7f6379034a22)

---

For deleting the existing deployment I had to

```
gh api /repos/ente-io/ente/deployments --jq=".[].id"
gh api --method DELETE -H "Accept: application/vnd.github+json" -H "X-GitHub-Api-Version: 2022-11-28" "/repos/ente-io/ente/deployments/1375794893"
```

This helpful hint taken from https://github.com/orgs/community/discussions/46375. Thanks!
This commit is contained in:
Manav Rathi 2024-03-08 12:30:58 +05:30
parent e47bcf2774
commit 05d13979db
2 changed files with 0 additions and 19 deletions

View file

@ -19,11 +19,6 @@ jobs:
run:
working-directory: docs
# cloudflare/pages-action needs these to create deployments
permissions:
contents: read
deployments: write
steps:
- name: Checkout code
uses: actions/checkout@v4
@ -49,5 +44,4 @@ jobs:
apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
projectName: docs-3d7
directory: docs/docs/.vitepress/dist
gitHubToken: ${{ secrets.GITHUB_TOKEN }}
wranglerVersion: "3"

View file

@ -68,16 +68,3 @@ As a concrete example, the GitHub workflow that deploys `docs/` passes "help" as
the branch name. The resulting deployment is available at "help.ente.pages.dev".
Finally, we add a custom domain to point to it from
[help.ente.io](https://help.ente.io).
## GitHub deployments
In our workflow we use the `deployments: write` permission and pass the
resulting `GITHUB_TOKEN` to the Cloudflare Pages Action
([docs](https://github.com/cloudflare/pages-action)).
This will create "GitHub Deployments" for each deploy. We can see them on the
[Deployments](https://github.com/ente-io/ente/deployments) dashboard; they also
appear on the main repository in the right sidebar.
TODO(MR): This document is not complete - all these steps have not been
integrated yet, this outlines the general plan.