optimize the flush function by deleting alerts based on their id (#1054)

pkg/database/alerts.go

@@ -850,34 +850,35 @@ func (c *Client) FlushAlerts(MaxAge string, MaxItems int) error {
 		deletedByAge = nbDeleted
 	}
 	if MaxItems > 0 {
-		if totalAlerts > MaxItems {
+		//We get the highest id for the alerts
-			nbToDelete := totalAlerts - MaxItems
+		//We substract MaxItems to avoid deleting alerts that are not old enough
-			batchSize := 500
+		//This gives us the oldest alert that we want to keep
-			if batchSize > nbToDelete {
+		//We then delete all the alerts with an id lower than this one
-				batchSize = nbToDelete
+		//We can do this because the id is auto-increment, and the database won't reuse the same id twice
-			}
+		lastAlert, err := c.QueryAlertWithFilter(map[string][]string{
-			deleted := 0
+			"sort":  {"DESC"},
-			for deleted < nbToDelete {
+			"limit": {"1"},
-				c.Log.Debugf("FlushAlerts (before query with filter) to delete: %d", nbToDelete)
+		})
-				alerts, err := c.QueryAlertWithFilter(map[string][]string{
+		c.Log.Debugf("FlushAlerts (last alert): %+v", lastAlert)
-					"sort":  {"ASC"},
+		if err != nil {
-					"limit": {strconv.Itoa(batchSize)},
+			c.Log.Errorf("FlushAlerts: could not get last alert: %s", err)
-				}) // we want to delete older alerts if we reach the max number of items
+			return errors.Wrap(err, "could not get last alert")
+		}
+
+		if len(lastAlert) != 0 {
+			maxid := lastAlert[0].ID - MaxItems
+
+			c.Log.Debugf("FlushAlerts (max id): %d", maxid)
+
+			if maxid > 0 {
+				//This may lead to orphan alerts (at least on MySQL), but the next time the flush job will run, they will be deleted
+				deletedByNbItem, err = c.Ent.Alert.Delete().Where(alert.IDLT(maxid)).Exec(c.CTX)
+
 				if err != nil {
-					c.Log.Warningf("FlushAlerts (max items query) : %s", err)
+					c.Log.Errorf("FlushAlerts: Could not delete alerts : %s", err)
-					return errors.Wrap(err, "unable to get all alerts")
+					return errors.Wrap(err, "could not delete alerts")
-				}
-				deletedAlerts, err := c.DeleteAlertGraphBatch(alerts)
-				if err != nil {
-					c.Log.Warningf("FlushAlerts (max items query) : %s", err)
-					return errors.Wrap(err, "unable to delete alerts")
-				}
-				deleted += deletedAlerts
-				if nbToDelete-deleted < batchSize {
-					batchSize = nbToDelete - deleted
 				}
 			}
-			deletedByNbItem = deleted
 		}
 	}
 	if deletedByNbItem > 0 {