beenull/crowdsec
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix appsec evt send order (#2749)

Browse source
This commit is contained in:
AlteredCoder 2024-01-17 11:59:31 +01:00 committed by GitHub
parent 685cda545b
commit 70e8377c0d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 31 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
pkg/acquisition/modules/appsec/appsec_runner.go
View file

@ -244,10 +244,6 @@ func (r *AppsecRunner) handleInBandInterrupt(request *appsec.ParsedRequest) {
r.logger.Errorf("unable to process OnMatch rules: %s", err)
return
}
// Should the in band match trigger an event ?
if r.AppsecRuntime.Response.SendEvent {
r.outChan <- evt
}
// Should the in band match trigger an overflow ?
if r.AppsecRuntime.Response.SendAlert {
@ -258,6 +254,12 @@ func (r *AppsecRunner) handleInBandInterrupt(request *appsec.ParsedRequest) {
}
r.outChan <- *appsecOvlfw
}
// Should the in band match trigger an event ?
if r.AppsecRuntime.Response.SendEvent {
r.outChan <- evt
}
}
}

45
pkg/acquisition/modules/appsec/appsec_test.go
View file

@ -55,8 +55,8 @@ func TestAppsecOnMatchHooks(t *testing.T) {
},
output_asserts: func(events []types.Event, responses []appsec.AppsecTempResponse) {
require.Len(t, events, 2)
require.Equal(t, types.LOG, events[0].Type)
require.Equal(t, types.APPSEC, events[1].Type)
require.Equal(t, types.APPSEC, events[0].Type)
require.Equal(t, types.LOG, events[1].Type)
require.Len(t, responses, 1)
require.Equal(t, 403, responses[0].HTTPResponseCode)
require.Equal(t, "ban", responses[0].Action)
@ -86,8 +86,8 @@ func TestAppsecOnMatchHooks(t *testing.T) {
},
output_asserts: func(events []types.Event, responses []appsec.AppsecTempResponse) {
require.Len(t, events, 2)
require.Equal(t, types.LOG, events[0].Type)
require.Equal(t, types.APPSEC, events[1].Type)
require.Equal(t, types.APPSEC, events[0].Type)
require.Equal(t, types.LOG, events[1].Type)
require.Len(t, responses, 1)
require.Equal(t, 413, responses[0].HTTPResponseCode)
require.Equal(t, "ban", responses[0].Action)
@ -116,8 +116,8 @@ func TestAppsecOnMatchHooks(t *testing.T) {
},
output_asserts: func(events []types.Event, responses []appsec.AppsecTempResponse) {
require.Len(t, events, 2)
require.Equal(t, types.LOG, events[0].Type)
require.Equal(t, types.APPSEC, events[1].Type)
require.Equal(t, types.APPSEC, events[0].Type)
require.Equal(t, types.LOG, events[1].Type)
require.Len(t, responses, 1)
require.Equal(t, "log", responses[0].Action)
},
@ -145,8 +145,8 @@ func TestAppsecOnMatchHooks(t *testing.T) {
},
output_asserts: func(events []types.Event, responses []appsec.AppsecTempResponse) {
require.Len(t, events, 2)
require.Equal(t, types.LOG, events[0].Type)
require.Equal(t, types.APPSEC, events[1].Type)
require.Equal(t, types.APPSEC, events[0].Type)
require.Equal(t, types.LOG, events[1].Type)
require.Len(t, responses, 1)
require.Equal(t, "allow", responses[0].Action)
},
@ -228,8 +228,8 @@ func TestAppsecOnMatchHooks(t *testing.T) {
},
output_asserts: func(events []types.Event, responses []appsec.AppsecTempResponse) {
require.Len(t, events, 2)
require.Equal(t, types.LOG, events[0].Type)
require.Equal(t, types.APPSEC, events[1].Type)
require.Equal(t, types.APPSEC, events[0].Type)
require.Equal(t, types.LOG, events[1].Type)
require.Len(t, responses, 1)
require.Equal(t, "foobar", responses[0].Action)
},
@ -358,13 +358,16 @@ func TestAppsecPreEvalHooks(t *testing.T) {
},
output_asserts: func(events []types.Event, responses []appsec.AppsecTempResponse) {
require.Len(t, events, 2)
require.Equal(t, types.LOG, events[0].Type)
require.True(t, events[0].Appsec.HasInBandMatches)
require.Len(t, events[0].Appsec.MatchedRules, 1)
require.Equal(t, "rule1", events[0].Appsec.MatchedRules[0]["msg"])
require.Equal(t, types.APPSEC, events[1].Type)
require.Equal(t, types.APPSEC, events[0].Type)
require.Equal(t, types.LOG, events[1].Type)
require.True(t, events[1].Appsec.HasInBandMatches)
require.Len(t, events[1].Appsec.MatchedRules, 1)
require.Equal(t, "rule1", events[1].Appsec.MatchedRules[0]["msg"])
require.Len(t, responses, 1)
require.True(t, responses[0].InBandInterrupt)
},
},
{
@ -600,11 +603,13 @@ func TestAppsecRuleMatches(t *testing.T) {
},
output_asserts: func(events []types.Event, responses []appsec.AppsecTempResponse) {
require.Len(t, events, 2)
require.Equal(t, types.LOG, events[0].Type)
require.True(t, events[0].Appsec.HasInBandMatches)
require.Len(t, events[0].Appsec.MatchedRules, 1)
require.Equal(t, "rule1", events[0].Appsec.MatchedRules[0]["msg"])
require.Equal(t, types.APPSEC, events[1].Type)
require.Equal(t, types.APPSEC, events[0].Type)
require.Equal(t, types.LOG, events[1].Type)
require.True(t, events[1].Appsec.HasInBandMatches)
require.Len(t, events[1].Appsec.MatchedRules, 1)
require.Equal(t, "rule1", events[1].Appsec.MatchedRules[0]["msg"])
require.Len(t, responses, 1)
require.True(t, responses[0].InBandInterrupt)
},