beenull/Pico
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactor Pico::prepareFileContent() for better performance

Browse source
This commit is contained in:
Daniel Rudolf 2016-03-06 00:49:45 +01:00
parent 479926eeb4
commit 245cd15770
1 changed files with 8 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
lib/Pico.php
View file

@ -915,38 +915,36 @@ class Pico
$content = preg_replace($metaHeaderPattern, '', $rawContent, 1); $content = preg_replace($metaHeaderPattern, '', $rawContent, 1);
// replace %version% // replace %version%
$content = str_replace('%version%', static::VERSION, $content); $variables['%version%'] = static::VERSION;
// replace %site_title% // replace %site_title%
$content = str_replace('%site_title%', $this->getConfig('site_title'), $content); $variables['%site_title%'] = $this->getConfig('site_title');
// replace %base_url% // replace %base_url%
if ($this->isUrlRewritingEnabled()) { if ($this->isUrlRewritingEnabled()) {
// always use `%base_url%?sub/page` syntax for internal links // always use `%base_url%?sub/page` syntax for internal links
// we'll replace the links accordingly, depending on enabled rewriting // we'll replace the links accordingly, depending on enabled rewriting
$content = str_replace('%base_url%?', $this->getBaseUrl(), $content); $variables['%base_url%?'] = $this->getBaseUrl();
} else { } else {
// actually not necessary, but makes the URL look a little nicer // actually not necessary, but makes the URL look a little nicer
$content = str_replace('%base_url%?', $this->getBaseUrl() . '?', $content); $variables['%base_url%?'] = $this->getBaseUrl() . '?';
} }
$content = str_replace('%base_url%', rtrim($this->getBaseUrl(), '/'), $content); $variables['%base_url%'] = rtrim($this->getBaseUrl(), '/');
// replace %theme_url% // replace %theme_url%
$themeUrl = $this->getBaseUrl() . basename($this->getThemesDir()) . '/' . $this->getConfig('theme'); $themeUrl = $this->getBaseUrl() . basename($this->getThemesDir()) . '/' . $this->getConfig('theme');
$content = str_replace('%theme_url%', $themeUrl, $content); $variables['%theme_url%'] = $themeUrl;
// replace %meta.*% // replace %meta.*%
if (!empty($meta)) { if (!empty($meta)) {
$metaKeys = $metaValues = array();
foreach ($meta as $metaKey => $metaValue) { foreach ($meta as $metaKey => $metaValue) {
if (is_scalar($metaValue) || ($metaValue === null)) { if (is_scalar($metaValue) || ($metaValue === null)) {
$metaKeys[] = '%meta.' . $metaKey . '%'; $variables['%meta.' . $metaKey . '%'] = strval($metaValue);
$metaValues[] = strval($metaValue);
} }
} }
$content = str_replace($metaKeys, $metaValues, $content);
} }
$content = str_replace(array_keys($variables), $variables, $content);
return $content; return $content;
} }