Merge pull request #217 from MindTooth/fix_reported_errors

Changed from variable assignment to comparison
This commit is contained in:
KodeStar 2018-06-20 21:20:12 +01:00 committed by GitHub
commit 0203440b06
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -14,7 +14,7 @@ class SettingsSeeder extends Seeder
public function run() public function run()
{ {
// Groups // Groups
if(!$setting_group = SettingGroup::find(1)) { if(!$setting_group == SettingGroup::find(1)) {
$setting_group = new SettingGroup; $setting_group = new SettingGroup;
$setting_group->id = 1; $setting_group->id = 1;
$setting_group->title = 'app.settings.system'; $setting_group->title = 'app.settings.system';
@ -24,7 +24,7 @@ class SettingsSeeder extends Seeder
$setting_group->title = 'app.settings.system'; $setting_group->title = 'app.settings.system';
$setting_group->save(); $setting_group->save();
} }
if(!$setting_group = SettingGroup::find(2)) { if(!$setting_group == SettingGroup::find(2)) {
$setting_group = new SettingGroup; $setting_group = new SettingGroup;
$setting_group->id = 2; $setting_group->id = 2;
$setting_group->title = 'app.settings.appearance'; $setting_group->title = 'app.settings.appearance';
@ -34,7 +34,7 @@ class SettingsSeeder extends Seeder
$setting_group->title = 'app.settings.appearance'; $setting_group->title = 'app.settings.appearance';
$setting_group->save(); $setting_group->save();
} }
if(!$setting_group = SettingGroup::find(3)) { if(!$setting_group == SettingGroup::find(3)) {
$setting_group = new SettingGroup; $setting_group = new SettingGroup;
$setting_group->id = 3; $setting_group->id = 3;
$setting_group->title = 'app.settings.miscellaneous'; $setting_group->title = 'app.settings.miscellaneous';
@ -45,7 +45,7 @@ class SettingsSeeder extends Seeder
$setting_group->save(); $setting_group->save();
} }
if($version = Setting::find(1)) { if($version == Setting::find(1)) {
$version->label = 'app.settings.version'; $version->label = 'app.settings.version';
$version->value = config('app.version'); $version->value = config('app.version');
$version->save(); $version->save();
@ -61,7 +61,7 @@ class SettingsSeeder extends Seeder
$setting->save(); $setting->save();
} }
if(!$setting = Setting::find(2)) { if(!$setting == Setting::find(2)) {
$setting = new Setting; $setting = new Setting;
$setting->id = 2; $setting->id = 2;
$setting->group_id = 2; $setting->group_id = 2;
@ -73,7 +73,7 @@ class SettingsSeeder extends Seeder
$setting->label = 'app.settings.background_image'; $setting->label = 'app.settings.background_image';
$setting->save(); $setting->save();
} }
if(!$setting = Setting::find(3)) { if(!$setting == Setting::find(3)) {
$setting = new Setting; $setting = new Setting;
$setting->id = 3; $setting->id = 3;
$setting->group_id = 3; $setting->group_id = 3;
@ -94,7 +94,7 @@ class SettingsSeeder extends Seeder
'startpage' => 'app.options.startpage', 'startpage' => 'app.options.startpage',
]); ]);
if(!$setting = Setting::find(4)) { if(!$setting == Setting::find(4)) {
$setting = new Setting; $setting = new Setting;
$setting->id = 4; $setting->id = 4;
@ -123,7 +123,7 @@ class SettingsSeeder extends Seeder
'es' => 'Español (Spanish)', 'es' => 'Español (Spanish)',
'tr' => 'Türkçe (Turkish)', 'tr' => 'Türkçe (Turkish)',
]); ]);
if($languages = Setting::find(5)) { if($languages == Setting::find(5)) {
$languages->options = $language_options; $languages->options = $language_options;
$languages->save(); $languages->save();
} else { } else {
@ -144,7 +144,7 @@ class SettingsSeeder extends Seeder
'_blank' => 'app.settings.window_target.new', '_blank' => 'app.settings.window_target.new',
]); ]);
if(!$setting = Setting::find(7)) { if(!$setting == Setting::find(7)) {
$setting = new Setting; $setting = new Setting;
$setting->id = 7; $setting->id = 7;