Fix #9651 Error in u:extract()

This logic seems inverted, this probably happened while the lua attributes were converted to use the LATTR_SETTER macros.

changelog.md

@@ -1,4 +1,4 @@
-## Version 1.19.7+dev
+## Version 1.19.6+dev
 ### Add-ons client
 ### Add-ons server
 ### Campaigns
@@ -6,33 +6,16 @@
 ### Multiplayer
 ### Lua API
 ### Packaging
+   * Windows 10 or later is now required
 ### Terrain
-### Translations
-   * Updated translations: Bengali, British English, Hungarian
-### Units
-### User interface
-### WML Engine
-   * [variables] in [side] no longer sets variables of the implicit leader unit (it now only sets the sides variables), to create a leader unit with variables, [leader] must be used instead. (issue #3742)
-### Miscellaneous and Bug Fixes
-
-## Version 1.19.7
-### Multiplayer
-   * Implemented an attempt to fix the multiplayer server crashing if someone requested game history and then disconnected before receiving the results
 ### Translations
    * Updated translations: Bengali, British English, Chinese (Simplified), Czech, Hungarian, Italian
 ### Units
-   * Dawarf - Decreased Cost from 17 to 12, Decreased Level from 1 to 0, and Decreased XP from 50 to 25
-   * Elvish Champion: HP 72 -> 70, cost 61 -> 60, accuracy bonus is now explained via a weapon special
 ### User interface
    * The `screen_pitch_microns` variable is no longer available for UI formulas
-   * Added a red line to the bottom of chat window when entering lobby
 ### WML Engine
    * [stacked_widget] no longer accepts the long-deprecated [stack] tag
-   * The author attribute is now again a display only attribute. Instead the primary_authors attribute should be used, which supports specifying multiple primary authors.
-   * [side]'s `leader` attribute has been removed
 ### Miscellaneous and Bug Fixes
-   * Fixed the game quitting at scenario end when loading a mp campaign game in singleplayer in debug mode
-   * Fixed map editor crashing when creating or opening scenario after having played a local scenario before opening the map editor
 
 ## Version 1.19.6
 ### Add-ons client

changelog_entries/dawarf-level.md

@@ -0,0 +1,2 @@
+### Units
+   * Dawarf - Decreased Cost from 17 to 12, Decreased Level from 1 to 0, and Decreased XP from 50 to 25

changelog_entries/dune_warmaster.md

@@ -1,2 +0,0 @@
-### Units
-   * Dune Warmaster: HP 59 -> 61 scimitar damage 9 -> 10

changelog_entries/ei-dialogue-fixes.md

@@ -1,5 +0,0 @@
-### Campaigns
-   * Eastern Invasion
-     * S04c: give Mal-Ravanal gold to recruit more units when their army becomes too small
-     * forbid all Dunefolk units to take the Plague Staff
-     * fix minor bugs with dialogues

changelog_entries/elvish-champion-honed.md

@@ -0,0 +1,2 @@
+### Units
+   * Elvish Champion: HP 72 -> 70, cost 61 -> 60, accuracy bonus is now explained via a weapon special

changelog_entries/explorer_resistance_nerf.md

@@ -1,2 +0,0 @@
- ### Units
-   * Dwarvish Explorer: physical resists reduced from 20% to 10%, melee damage increased from 10 to 11.

changelog_entries/fire_guardian_resistances.md

@@ -1,3 +0,0 @@
- ### Units
-   * Fire Wisps and Guardian - Fire Resistance changed from 50% to 70%
-   * Fire Wraith - Fire Resistance changed from 50% to 80%

changelog_entries/orcish_xbowman_nerf.md

@@ -1,2 +0,0 @@
-### Units
-   * Orcish Crossbowman: melee 6-3 -> 4-3, experience to level 43 -> 57

changelog_entries/primary_authors.md

@@ -0,0 +1,2 @@
+### WML Engine
+   * The author attribute is now again a display only attribute. Instead the primary_authors attribute should be used, which supports specifying multiple primary authors.

data/advanced_preferences.cfg

@@ -21,14 +21,6 @@
     [/option]
 [/advanced_preference]
 
-[advanced_preference]
-    field=addon_icons
-    name= _ "Whether to show icons in the add-ons list on the add-ons manager"
-    description= _ "Disabling saves bandwidth by not sending icons for the add-ons list in the add-ons manager"
-    type=boolean
-    default=yes
-[/advanced_preference]
-
 [advanced_preference]
     field=ask_delete
     name= _ "Confirm deleting saves"

data/campaigns/Eastern_Invasion/scenarios/04c_Mal-Ravanals_Capital.cfg

@@ -665,12 +665,6 @@
             side=4
             amount={ON_DIFFICULTY 15 45 75} # otherwise his armies start to feel a little thin around now
         [/gold]
-        [fire_event]
-            name=dacyn_warning
-        [/fire_event]
-    [/event]
-    [event]
-        name=dacyn_warning
         [message]
             speaker=Dacyn
             message= _ "Gweddry, we should not be here. They are merely toying with us right now, but all will be lost if Mal-Ravanal finds me amongst you!"
@@ -694,9 +688,6 @@
     [event]
         name=ravanal_gets_serious
 
-        [fire_event]
-            name=dacyn_warning
-        [/fire_event]
         {REPLACE_SCENARIO_MUSIC silence.ogg}
         [message]  # if you change this, also change 06b_Soradoc
             speaker=Mal-Ravanal
@@ -924,7 +915,7 @@
                     [/then]
 
                     [else]
-                        {FIND_NEARBY (trait,side=survivor,1) 36 15 99}
+                        {FIND_NEARBY (type,side=Knight,1) 36 15 99}
                     [/else]
                 [/if]
                 [message]
@@ -933,6 +924,7 @@
                 [/message]
 
                 {FIND_NEARBY (
+                    type=Knight,Terraent
                     side=8
                 ) 36 15 99}
                 [message]

data/campaigns/Eastern_Invasion/scenarios/05_Northern_Outpost.cfg

@@ -516,38 +516,6 @@
         {MODIFY_UNIT id=Dacyn attacks_left 0}
     [/event]
 
-    [event]
-        name=owaec_joins
-
-        [capture_village]
-            owner_side=2
-            side=1
-        [/capture_village]
-        [modify_unit]
-            [filter]
-                side=2
-            [/filter]
-
-            side=1
-            moves=$($this_unit.max_moves)
-            attacks_left=1
-            {TEAM_COLOR_OVERRIDE () blue}
-        [/modify_unit]
-        [message]
-            speaker=narrator
-            image=wesnoth-icon.png
-            message= _ "(You may now recruit Horsemen and Cavalrymen!)"
-        [/message]
-        [set_extra_recruit] # need to set recruits per-unit (instead of per-side) so we don't mess up the plague staff
-            id=Gweddry
-            extra_recruit={REGULAR_RECRUIT_LIST}
-        [/set_extra_recruit]
-        [set_extra_recruit]
-            id=Owaec
-            extra_recruit={REGULAR_RECRUIT_LIST}
-        [/set_extra_recruit]
-    [/event]
-
     [event]
         name=capture
         first_time_only=no
@@ -750,9 +718,34 @@
                     speaker=Owaec
                     message= _ "Huzzah!! At last, these villagers are liberated! Gweddry, thank you for your aid. I place my Clansmen and myself at your service."
                 [/message]
-                [fire_event]
-                    name=owaec_joins
-                [/fire_event]
+                [capture_village]
+                    owner_side=2
+                    side=1
+                [/capture_village]
+                [modify_unit]
+                    [filter]
+                        side=2
+                    [/filter]
+
+                    side=1
+                    moves=$($this_unit.max_moves)
+                    attacks_left=1
+                    {TEAM_COLOR_OVERRIDE () blue}
+                [/modify_unit]
+                [message]
+                    speaker=narrator
+                    image=wesnoth-icon.png
+                    message= _ "(You may now recruit Horsemen and Cavalrymen!)"
+                [/message]
+                [set_extra_recruit] # need to set recruits per-unit (instead of per-side) so we don't mess up the plague staff
+                    id=Gweddry
+                    extra_recruit={REGULAR_RECRUIT_LIST}
+                [/set_extra_recruit]
+                [set_extra_recruit]
+                    id=Owaec
+                    extra_recruit={REGULAR_RECRUIT_LIST}
+                [/set_extra_recruit]
+
                 [if]
                     [not]
                         [have_unit]
@@ -886,9 +879,33 @@
                     speaker=Owaec
                     message= _ "Huzzah!! May these be the first of many undead to fall before our hooves! Gweddry, thank you for your aid. I place my Clansmen and myself at your service."
                 [/message]
-                [fire_event]
-                    name=owaec_joins
-                [/fire_event]
+                [capture_village]
+                    owner_side=2
+                    side=1
+                [/capture_village]
+                [modify_unit]
+                    [filter]
+                        side=2
+                    [/filter]
+
+                    side=1
+                    moves=$($this_unit.max_moves)
+                    attacks_left=1
+                    {TEAM_COLOR_OVERRIDE () blue}
+                [/modify_unit]
+                [message]
+                    speaker=narrator
+                    image=wesnoth-icon.png
+                    message= _ "(You may now recruit Horsemen and Cavalrymen!)"
+                [/message]
+                [set_extra_recruit] # need to set recruits per-unit (instead of per-side) so we don't mess up the plague staff
+                    id=Gweddry
+                    extra_recruit={REGULAR_RECRUIT_LIST}
+                [/set_extra_recruit]
+                [set_extra_recruit]
+                    id=Owaec
+                    extra_recruit={REGULAR_RECRUIT_LIST}
+                [/set_extra_recruit]
                 [message]
                     speaker=Owaec
                     message= _ "Now let us free these villagers from the outlaws terrorizing them!"

data/campaigns/Eastern_Invasion/scenarios/18_Epilogue.cfg

@@ -315,30 +315,50 @@
                     time=750
                 [/delay]
 
-                [message]
-                    speaker=Konrad
-                    image=portraits/konrad_II.webp
-                    message= _ "Dolburras, Owaec has told me of the help you provided his men; both your skill at arms and your tenacious spirit. We wish to offer you this finely crafted shield — an heirloom of my line — and an honor guard as you return to Knalga."
-                [/message]
                 [if]
-                    [have_unit]
-                        id=Owaec
-                    [/have_unit]
-
+                    {VARIABLE_CONDITIONAL plague_staff_wielder_id equals Dolburras}
                     [then]
                         [message]
-                            speaker=Dolburras
-                            #po: "Aye, I am honored. You have my sincerest thanks, your Majesty."
-                            message= _ "Aye, I be honored. Ye have my sincerest thanks, yer Majesty."
+                            speaker=Konrad
+                            image=portraits/konrad_II.webp
+                            #po: the player chose to give Dolburras the plague staff
+                            message= _ "Dwarf, <i>necromancer</i>, know that Wesnoth will never tolerate your kind. You shall surrender that accursed stave to be destroyed, you shall foreswear the practice of all magic on penalty of death, and you are hereby exiled from Wesnoth. Be grateful for Our mercy."
                         [/message]
+                        [message]
+                            speaker=Dolburras
+                            #po: "Yeah, fair enough. I don't think my kinsmen will look kindly upon necromancies either."
+                            message= _ "Aye, fair enough. I dinnae think my kinsmen will look kindly upon necromancies either."
+                        [/message]
+                        {CLEAR_VARIABLE plague_staff_wielder_id}
                     [/then]
 
                     [else]
                         [message]
-                            speaker=Dolburras
-                            #po: Owaec's dead
-                            message= _ "Aye, I be honored. I only wish he were here to see the Clans avenged."
+                            speaker=Konrad
+                            image=portraits/konrad_II.webp
+                            message= _ "Dolburras, Owaec has told me of the help you provided his men; both your skill at arms and your tenacious spirit. We wish to offer you this finely crafted shield — an heirloom of my line — and an honor guard as you return to Knalga."
                         [/message]
+                        [if]
+                            [have_unit]
+                                id=Owaec
+                            [/have_unit]
+
+                            [then]
+                                [message]
+                                    speaker=Dolburras
+                                    #po: "Aye, I am honored. You have my sincerest thanks, your Majesty."
+                                    message= _ "Aye, I be honored. Ye have my sincerest thanks, yer Majesty."
+                                [/message]
+                            [/then]
+
+                            [else]
+                                [message]
+                                    speaker=Dolburras
+                                    #po: Owaec's dead
+                                    message= _ "Aye, I be honored. I only wish he were here to see the Clans avenged."
+                                [/message]
+                            [/else]
+                        [/if]
                     [/else]
                 [/if]
             [/then]
@@ -403,15 +423,34 @@
                     time=750
                 [/delay]
 
-                [message]
-                    speaker=Konrad
-                    image=portraits/konrad_II.webp
-                    message= _ "Hahid al-Ali, We know of your far-off people, but great distance has caused little contact between us. May it be thus no longer. If you accept, We would appoint you as ambassador between our two realms."
-                [/message]
-                [message]
-                    speaker=Hahid al-Ali
-                    message= _ "Me, ambassador to the barbarian kingdoms, what a thought! I am honored, and would be even more honored to learn that the job comes with... excellent pay I hope?"
-                [/message]
+                [if]
+                    {VARIABLE_CONDITIONAL plague_staff_wielder_id equals "Hahid al-Ali"}
+                    [then]
+                        [message]
+                            speaker=Konrad
+                            image=portraits/konrad_II.webp
+                            #po: the player chose to give Hahid the plague staff
+                            message= _ "Southerner, <i>necromancer</i>, know that Wesnoth will never tolerate your kind. You shall surrender that accursed stave to be destroyed, you shall foreswear the practice of all magic on penalty of death, and you are hereby exiled back to the desert wastes. Be grateful for Our mercy."
+                        [/message]
+                        [message]
+                            speaker=Hahid al-Ali
+                            message= _ "Bah, I save you barbarians from an invasion, and this is the thanks I get! What happened to being paid thrice what I’m owed? So much for northerner generosity!"
+                        [/message]
+                        {CLEAR_VARIABLE plague_staff_wielder_id}
+                    [/then]
+
+                    [else]
+                        [message]
+                            speaker=Konrad
+                            image=portraits/konrad_II.webp
+                            message= _ "Hahid al-Ali, We know of your far-off people, but great distance has caused little contact between us. May it be thus no longer. If you accept, We would appoint you as ambassador between our two realms."
+                        [/message]
+                        [message]
+                            speaker=Hahid al-Ali
+                            message= _ "Me, ambassador to the barbarian kingdoms, what a thought! I am honored, and would be even more honored to learn that the job comes with... excellent pay I hope?"
+                        [/message]
+                    [/else]
+                [/if]
             [/then]
         [/if]
 

data/campaigns/Eastern_Invasion/utils/items.cfg

@@ -70,7 +70,10 @@
             [/then]
 
             [else]
-                {INVALID_DESC}
+                [message]
+                    speaker=unit
+                    message={INVALID_DESC}
+                [/message]
             [/else]
         [/if]
     [/event]
@@ -136,7 +139,7 @@ crystal_quiver #enddef
     _"Crystal Quiver"
     _"Arrows from this crystalline quiver glimmer with a pale magical light, <i><b>illuminating</b></i> the surrounding area and making your bow or crossbow attacks <i><b>arcane</b></i>."
     {NOTE_REUSEABLE}
-    ()
+    ""
     (
         [effect]
             apply_to=new_ability
@@ -178,7 +181,7 @@ holy_amulet_3 #enddef
     _"Holy Amulet"
     _"Engraved with a consecrated symbol, this amulet will bless both your <i><b>melee</b></i> and <i><b>ranged</b></i> attacks with <i><b>arcane</b></i> damage."
     {NOTE_REUSEABLE}
-    ()
+    ""
     (
         [effect]
             apply_to=new_ability
@@ -213,7 +216,7 @@ sentinel #enddef
     _"Shield of the Sentinel"
     _"Deep within this shield’s towering bulk, enchanted machinery whirrs faintly. Whenever an adjacent ally is hit by an attack, <i><b>this shield’s bearer is hit instead</b></i>."
     {NOTE_REUSEABLE}
-    ()
+    ""
     (
         [effect]
             apply_to=overlay
@@ -565,7 +568,7 @@ yeti_steak #enddef
     _"Yetiburger"
     _"Eating this funny tasting meat <i><b>doubles your hitpoints</b></i> and grants <i><b>immunity to cold</b></i>."
     {NOTE_SINGLE_USE}
-    ()
+    ""
     (
         [effect]
             apply_to=hitpoints
@@ -595,7 +598,7 @@ yeti_steak #enddef
 
 <i><b><span color='#FF0000'>-1</span> damage, <span color='#FF0000'>-1</span> movement, <span color='#00FF00'>+10</span> hitpoints</b></i>."
     {NOTE_SINGLE_USE}
-    ()
+    ""
     (
         [effect]
             apply_to=movement
@@ -628,7 +631,7 @@ baneblade #enddef
     _"This incorporeal sword resembles those wielded by undead wraiths. Any mortal brave enough to wield it becomes <i><b>chaotic</b></i> and lashes out at their foes with reckless abandon.
 <i><b>6x4 arcane</b></i> damage, <i><b>drains</b></i>, <i><b>berserk</b></i>."
     {NOTE_REUSEABLE}
-    ()
+    ""
     (
         [effect]
             apply_to=attack
@@ -693,7 +696,7 @@ potion_of_barkskin #enddef
     _"Potion of Barkskin"
     _"This potion bubbles as though over an open flame, yet is cool to the touch. Its drinker gains the <i><b>steadfast</b></i> ability and can <i><b>heal 2 hitpoints each turn</b></i>, like dwarves with the ‘healthy’ trait."
     {NOTE_SINGLE_USE}
-    ()
+    ""
     (
         [effect]
             apply_to=new_ability
@@ -725,7 +728,7 @@ ring_of_invisibility #enddef
     _"Ring of Invisibility"
     _"This plain gold ring looks unremarkable, but its wearer gains <i><b>skirmisher</b></i> and <i><b>nightstalk</b></i>, becoming invisible in the dark."
     {NOTE_REUSEABLE}
-    ()
+    ""
     (
         [effect]
             apply_to=new_ability
@@ -763,16 +766,16 @@ plague_staff #enddef
     {PLACE_ITEM
     {ID_PLAGUE_STAFF}  _"staff"  items/plague-staff.png  {X}  {Y}
     (
-        [not]
-            race=dunefolk
-        [/not]
-
         [not]
             type_adv_tree=White Mage,Paladin
+
+            [not]
+                id=Dacyn
+            [/not]
         [/not]
 
         [not]
-            id=Owaec,Gweddry,Dacyn,Terraent,Konrad
+            id=Owaec,Gweddry,Dacyn,Hahid al-Ali,Terraent,Konrad
         [/not]
         # messes with existing recruiting, and messes with the S18 cutscene
         # if Dacyn gets this, it also breaks his scripted advancements (and his S17a recruitment)
@@ -781,83 +784,8 @@ plague_staff #enddef
     _"Looted from a dead necromancer, the wielder of this dark staff becomes <i><b>chaotic</b></i>, and can <i><b>recruit and recall</b></i> Walking Corpses and Soulless.
 <i><b>6x3 impact</b></i> damage, <i>plague</i>."
     {NOTE_REUSEABLE}
-    (
-        [switch]
-            variable=unit.id
-            [case]
-                value=Owaec
-                [message]
-                    speaker=unit
-                    message=_"Do not insult me! No clansman will ever stoop to such black magic."
-                [/message]
-            [/case]
-            [case]
-                value=Gweddry
-                [message]
-                    speaker=unit
-                    message=_"I already have an army of human soldiers — living soldiers. Let someone else use this staff."
-                [/message]
-            [/case]
-            [case]
-                value=Dacyn
-                [message]
-                    speaker=unit
-                    message=_"Tempting! Most tempting... but I fear it would be unwise for me to wield such a thing. That privilege passes onto another."
-                [/message]
-            [/case]
-            [case]
-                value=Hahid al-Ali
-                [message]
-                    speaker=unit
-                    message=_"Ha! Good joke! I’m not about to mess around with any of your foul northerner magic; necromancy was the cause of all this trouble in the first place."
-                [/message]
-            [/case]
-            [case]
-                value=Terraent
-                [message]
-                    speaker=unit
-                    message=_"I serve the light, not this staff of foul darkness! We should cast away this thing and be done with it."
-                [/message]
-            [/case]
-            [case]
-                value=Konrad
-                [message]
-                    speaker=unit
-                    message=_"...what foul thing is this? Remove it from my presence; necromancy shall not take root in Wesnoth, not under my watch."
-                [/message]
-            [/case]
-            [else]
-                [switch]
-                    variable=unit.type
-                    [case]
-                        value=White Mage,Mage of Light,Paladin
-                        [message]
-                            speaker=unit
-                            message=_"No. I serve that which is good and light, and will not wield such a dark magical artifact."
-                        [/message]
-                    [/case]
-                    [else]
-                        [switch]
-                            variable=unit.race
-                            [case]
-                                value=dunefolk
-                                [message]
-                                    speaker=unit
-                                    message=_"Fighting your northerners’ foul magic is bad enough. Don’t expect me to wield that — civilized cultures don’t mess around with magic."
-                                [/message]
-                            [/case]
-                            [else]
-                                [message]
-                                    speaker=unit
-                                    message=_"I will not wield such a dark magical artifact, though I shall not begrudge its use by my companions."
-                                [/message]
-                            [/else]
-                        [/switch]
-                    [/else]
-                [/switch]
-            [/else]
-        [/switch]
-    )
+    _"I will not wield such a dark magical artifact, though I shall not begrudge its use by my companions."
+    # this message makes no sense for Dacyn (his entire quest is to get a dark magical artifact), but I couldn't think of something good and generic that works for everyone.
     (
         [effect]
             apply_to=new_attack

data/core/macros/weapon_specials.cfg

@@ -115,33 +115,6 @@
     [/chance_to_hit]
 #enddef
 
-#define WEAPON_SPECIAL_NAVAL_RAM
-    # Canned definition of the Naval Ram ability to be included in a
-    # [specials] clause.
-    [disable]
-        id=naval_ram
-        name=_"naval ram"
-        description=_"This attack can only be used against units in water terrain."
-        [filter_opponent]
-            [filter_location]
-                [not]
-                    terrain="W*,S*"
-                [/not]
-            [/filter_location]
-        [/filter_opponent]
-        special_note=_ "This unit has an attack that can only be used against units in watery terrain."
-    [/disable]
-    [damage]
-        id=charge
-        name= _ "charge"
-        description= _ "When used offensively, this attack deals double damage to the target. It also causes this unit to take double damage from the target’s counterattack."
-        special_note={INTERNAL:SPECIAL_NOTES_CHARGE}
-        multiply=2
-        apply_to=both
-        active_on=offense
-    [/damage]
-#enddef
-
 #define WEAPON_SPECIAL_HONED
     # Canned definition of the Honed ability to be included in a
     # [specials] clause.

data/core/units.cfg

@@ -289,7 +289,7 @@ Saurians live spectacularly short lives by comparison to most of the other races
     [/race]
 
     [race]
-        id=ship
+        id=transport
         help_taxonomy=mechanical
         name= _ "race^Ship"
         plural_name= _ "race+plural^Ships"
@@ -1562,37 +1562,6 @@ The life span of the wose is unknown, although the most ancient members of this
         [/resistance]
     [/movetype]
 
-    [movetype]
-        name=flamefly
-        flying=yes
-        {DRAKEFLY_MOVE}
-        [defense]
-            deep_water=80
-            shallow_water=80
-            reef=70
-            swamp_water=70
-            flat=70
-            sand=60
-            forest=60
-            hills=60
-            mountains=60
-            village=60
-            castle=60
-            cave=70
-            fungus=60
-            frozen=80
-            unwalkable=60
-        [/defense]
-        [resistance]
-            blade=100
-            pierce=100
-            impact=100
-            fire=30
-            cold=150
-            arcane=110
-        [/resistance]
-    [/movetype]
-
     [movetype]
         name=dunefoot
         [movement_costs]

data/core/units/boats/Derelict_Galleon.cfg

@@ -2,7 +2,7 @@
 [unit_type]
     id=Derelict Hulk
     name= _ "Derelict Hulk"
-    race=ship
+    race=transport
     profile="portraits/transport/derelict-hulk.webp"
     image="units/transport/derelict-galleon.png"
     hitpoints=24

data/core/units/boats/Fireship.cfg

@@ -2,7 +2,7 @@
 [unit_type]
     id=Fireship
     name= _ "Fireship"
-    race=ship
+    race=transport
     image="halo/transport/fireship-back-glow.png~BLIT(units/transport/fireship.png)~BLIT(units/transport/flames/fireship-2.png)"
     profile="portraits/transport/fireship.webp"
     hitpoints=12
@@ -48,36 +48,6 @@
             layer=42
         [/flames_frame]
     [/standing_anim]
-    [standing_anim]
-        start_time=0
-        terrain_type=S*,*^V*
-        boat_start_time=0
-        boat_y=-1:250,-1~0:490,0:250,0~-1:490
-        flames_start_time=0
-        flames_y=-1:250,-1~0:490,0:250,0~-1:490
-        flames_directional_x=1:350,0:390,-1:350,0:390
-        [frame]
-            image="halo/transport/fireship-back-glow.png:1480"
-            layer=9
-        [/frame]
-        [boat_frame]
-            image="units/transport/fireship-[port,mid,starboard,mid].png:[350,390,350,390]"
-            auto_vflip=no
-            image_mod=~MASK(units/transport/pirate-galleon-mask.png)
-            primary=yes
-            layer=40
-        [/boat_frame]
-        [fire_frame]
-            image="units/transport/fireship-back-fire[1,2,1,2,1,2,1,2].png:[185*8]"
-            auto_vflip=no
-            layer=41
-        [/fire_frame]
-        [flames_frame]
-            image="units/transport/flames/fireship-[1~9,1~9].png:[82*10,86,82*7]"
-            auto_vflip=no
-            layer=42
-        [/flames_frame]
-    [/standing_anim]
     [movement_anim]
         start_time=0
         boat_start_time=0
@@ -176,9 +146,9 @@
         type=fire
         range=melee
         [specials]
-            {WEAPON_SPECIAL_NAVAL_RAM}
+            {WEAPON_SPECIAL_CHARGE}
         [/specials]
-        damage=6
+        damage=5
         number=1
     [/attack]
     [attack_anim]

data/core/units/boats/Pirate_Galleon.cfg

@@ -2,11 +2,11 @@
 [unit_type]
     id=Pirate Galleon
     name= _ "Pirate Galleon"
-    race=ship
+    race=transport
     image="units/transport/pirate-galleon.png"
     # ideally, we have "crew" that make sense for dialogs, and "mechanical" that depicts the transport
     # but for now, we just have "crew"
-    # small_profile="portraits/transport/mechanical-pirate_galleon.webp"
+    # small_profile="portraits/transport/mechanical-pirate_galleon.png"
     profile="portraits/transport/crew-pirate_galleon.webp"
     hitpoints=35
     movement_type=ship

data/core/units/boats/Raider_Coastal.cfg

@@ -1,169 +0,0 @@
-#textdomain wesnoth-units
-[unit_type]
-    id=Coastal Raider
-    name= _ "Coastal Raider"
-    race=ship
-    image="units/transport/raider/coastal-raider.png"
-    # ideally, we have "crew" that make sense for dialogs, and "mechanical" that depicts the transport
-    # but for now, we just have "crew"
-    small_profile="portraits/transport/mechanical-raider.webp"
-    profile="portraits/transport/crew-boat.webp"
-    hitpoints=36
-    movement_type=ship
-    [movement_costs]
-        deep_water=2
-        village=1
-    [/movement_costs]
-    [defense]
-        deep_water=50
-        shallow_water=40
-        village=50
-    [/defense]
-    movement=5
-    experience=50
-    level=1
-    alignment=lawful
-    advances_to=null
-    {AMLA_DEFAULT}
-    cost=15
-    usage=null
-    description= _"While many larger ships rely on impressive sails to harness the power of the wind, galleys and raiders are propelled by muscle-power of the crew manning the oars. This has the disadvantage of requiring a larger crew, and it does limit the speed and efficiency of transport. But these seeming weaknesses also make the vessel less vulnerable to the whims of weather and the predations of pirates.
-
-Coastal raider ships are a very basic warship, used by several races to move armed forces rapidly through shallow and coastal water. They do not possess any specific armaments, but there are always archers amongst the crew."
-
-    [standing_anim]
-        start_time=0
-        terrain_type=Wo*
-        boat_start_time=0
-        flag_start_time=0
-        boat_y=-3:200,-3~3:440,3:300,3~-2:440
-        flag_y=-3:200,-3~3:440,3:300,3~-2:440
-        flag_directional_x=-2:540,-1:250,0:340,-1:150
-        [frame]
-            image="misc/blank-hex.png:1380"
-        [/frame]
-        [boat_frame]
-            image="units/transport/raider/bob[1~7,6~2].png:[210,120,80*3,120,210,120,80*3,120]"
-            auto_vflip=no
-            #image_mod=~MASK(units/transport/raider/mask.png)
-        [/boat_frame]
-        [flag_frame]
-            image="units/transport/raider/flag[1~3,2,1~3,2].png:[200*3,110,190*3,100]"
-            auto_vflip=no
-        [/flag_frame]
-    [/standing_anim]
-    [standing_anim]
-        start_time=0
-        terrain_type=Ww*,Wr*
-        boat_start_time=0
-        flag_start_time=0
-        boat_y=-2:200,-2~1:440,1:300,1~-2:440
-        flag_y=-2:200,-2~1:440,1:300,1~-2:440
-        flag_directional_x=-2:540,-1:250,0:340,-1:150
-        [frame]
-            image="misc/blank-hex.png:1380"
-        [/frame]
-        [boat_frame]
-            image="units/transport/raider/bob[1~7,6~2].png:[210,120,80*3,120,210,120,80*3,120]"
-            auto_vflip=no
-            #image_mod=~MASK(units/transport/raider/mask.png)
-        [/boat_frame]
-        [flag_frame]
-            image="units/transport/raider/flag[1~3,2,1~3,2].png:[200*3,110,190*3,100]"
-            auto_vflip=no
-        [/flag_frame]
-    [/standing_anim]
-    [standing_anim]
-        start_time=0
-        terrain_type=S*,*^V*
-        boat_start_time=0
-        flag_start_time=0
-        flag_directional_x=-2:640,-1:300,0:390,-1:250
-        [frame]
-            image="misc/blank-hex.png:1680"
-        [/frame]
-        [boat_frame]
-            image="units/transport/raider/bob[1~7,6~2].png:[260,170,80*3,170,260,170,80*3,170]"
-            auto_vflip=no
-            #image_mod=~MASK(units/transport/raider/mask.png)
-        [/boat_frame]
-        [flag_frame]
-            image="units/transport/raider/flag[1~3,2,1~3,2].png:[200*3,110,190*3,100]"
-            auto_vflip=no
-        [/flag_frame]
-    [/standing_anim]
-    [defend]
-        hits=hit,kill
-        start_time=-120
-        boat_start_time=-120
-        boat_y=0:100,0~-3:140,-3:60,-3~0:310
-        [frame]
-            image="misc/blank-hex.png:600"
-        [/frame]
-        [boat_frame]
-            image="units/transport/raider/coastal-raider.png:120"
-            auto_vflip=no
-        [/boat_frame]
-        [boat_frame]
-            image="units/transport/raider/hit-[b,c,b,a].png:[70,150,100,140]"
-            auto_vflip=no
-        [/boat_frame]
-        [boat_frame]
-            image="units/transport/raider/coastal-raider.png:20"
-            auto_vflip=no
-        [/boat_frame]
-    [/defend]
-    [death]
-        start_time=0
-        alpha=1.0:800,1.0~0.0:280,0.0:1
-        [frame]
-            image="units/transport/raider/die-[1~12].png:[90*12]"
-        [/frame]
-    [/death]
-    [movement_anim]
-        start_time=0
-        boat_start_time=0
-        boat_y=0~-2:320,-2~0:320,0~2:320,2~0:320
-        boat_offset="0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200"
-        [frame]
-            image="misc/blank-hex.png:1600"
-        [/frame]
-        [boat_frame]
-            image="units/transport/raider/move-[a,b,a,b,a,b,a,b].png:[200*8]"
-            auto_vflip=no
-            #image_mod=~MASK(units/transport/raider/mask.png)
-        [/boat_frame]
-    [/movement_anim]
-    [attack]
-        name=bow
-        description=_"bow"
-        icon=attacks/bow.png
-        type=pierce
-        range=ranged
-        # maybe this should be swarm
-        damage=5
-        number=4
-    [/attack]
-    [attack_anim]
-        [filter_attack]
-            name=bow
-        [/filter_attack]
-        start_time=-200
-        missile_start_time=-150
-        boat_start_time=-200
-        boat_y=0~2:80,2~-2:140,-2~0:80
-        [missile_frame]
-            duration=150
-            image="projectiles/missile-n.png"
-            image_diagonal="projectiles/missile-ne.png"
-        [/missile_frame]
-        [boat_frame]
-            image="units/transport/raider/coastal-raider.png:300"
-            auto_vflip=no
-            # image_mod=~MASK(units/transport/raider/mask.png)
-        [/boat_frame]
-        [frame]
-            image="misc/blank-hex.png:300"
-        [/frame]
-    [/attack_anim]
-[/unit_type]

data/core/units/boats/Raider_Iron.cfg

@@ -1,205 +0,0 @@
-#textdomain wesnoth-units
-[unit_type]
-    id=Iron Raider
-    name= _ "Iron Raider"
-    race=ship
-    image="units/transport/raider/iron-raider.png"
-    # ideally, we have "crew" that make sense for dialogs, and "mechanical" that depicts the transport
-    # but for now, we just have "crew"
-    small_profile="portraits/transport/mechanical-raider.webp"
-    profile="portraits/transport/crew-boat.webp"
-    hitpoints=57
-    movement_type=ship
-    [movement_costs]
-        deep_water=2
-        village=1
-    [/movement_costs]
-    [defense]
-        deep_water=50
-        shallow_water=40
-        village=50
-    [/defense]
-    [resistance]
-        blade=90
-        pierce=70
-        impact=100
-        fire=110
-    [/resistance]
-    movement=5
-    experience=50
-    level=2
-    alignment=lawful
-    advances_to=null
-    {AMLA_DEFAULT}
-    cost=35
-    usage=null
-    description= _"While Galleons and Cogs rely on impressive sails to harness the power of the wind, galleys and raiders are propelled by muscle-power of the crew manning the oars. This has the disadvantage of requiring a larger crew, and it does limit the speed and efficiency of transport. But these seeming weaknesses also make the vessel less vulnerable to the whims of weather and the predations of pirates.
-
-Iron Raiders are Coastal Raiders that have been hardened to become tougher targets and harder hitters, at the expense of speed. They are often used as front-line escorts of slower cargo ships in rivers and coasts."
-
-    [standing_anim]
-        start_time=0
-        terrain_type=Wo*
-        boat_start_time=0
-        flag_start_time=0
-        boat_y=-3:200,-3~3:440,3:300,3~-2:440
-        flag_y=-3:200,-3~3:440,3:300,3~-2:440
-        flag_directional_x=-2:540,-1:250,0:340,-1:150
-        [frame]
-            image="misc/blank-hex.png:1380"
-        [/frame]
-        [boat_frame]
-            image="units/transport/raider/iron-bob[1~7,6~2].png:[210,120,80*3,120,210,120,80*3,120]"
-            auto_vflip=no
-            #image_mod=~MASK(units/transport/raider/mask.png)
-        [/boat_frame]
-        [flag_frame]
-            image="units/transport/raider/iron-flag[1~3,2,1~3,2].png:[200*3,110,190*3,100]"
-            auto_vflip=no
-        [/flag_frame]
-    [/standing_anim]
-    [standing_anim]
-        start_time=0
-        terrain_type=Ww*,Wr*
-        boat_start_time=0
-        flag_start_time=0
-        boat_y=-2:200,-2~1:440,1:300,1~-2:440
-        flag_y=-2:200,-2~1:440,1:300,1~-2:440
-        flag_directional_x=-2:540,-1:250,0:340,-1:150
-        [frame]
-            image="misc/blank-hex.png:1380"
-        [/frame]
-        [boat_frame]
-            image="units/transport/raider/iron-bob[1~7,6~2].png:[210,120,80*3,120,210,120,80*3,120]"
-            auto_vflip=no
-            #image_mod=~MASK(units/transport/raider/mask.png)
-        [/boat_frame]
-        [flag_frame]
-            image="units/transport/raider/iron-flag[1~3,2,1~3,2].png:[200*3,110,190*3,100]"
-            auto_vflip=no
-        [/flag_frame]
-    [/standing_anim]
-    [standing_anim]
-        start_time=0
-        terrain_type=S*,*^V*
-        boat_start_time=0
-        flag_start_time=0
-        flag_directional_x=-2:640,-1:300,0:390,-1:250
-        [frame]
-            image="misc/blank-hex.png:1680"
-        [/frame]
-        [boat_frame]
-            image="units/transport/raider/iron-bob[1~7,6~2].png:[260,170,80*3,170,260,170,80*3,170]"
-            auto_vflip=no
-            #image_mod=~MASK(units/transport/raider/mask.png)
-        [/boat_frame]
-        [flag_frame]
-            image="units/transport/raider/iron-flag[1~3,2,1~3,2].png:[200*3,110,190*3,100]"
-            auto_vflip=no
-        [/flag_frame]
-    [/standing_anim]
-    [defend]
-        hits=hit,kill
-        start_time=-120
-        boat_start_time=-120
-        boat_y=0:100,0~-3:140,-3:60,-3~0:310
-        boat_offset=0.0:120,0.0~-0.1:180,-0.1~0.0:300
-        [frame]
-            image="misc/blank-hex.png:600"
-        [/frame]
-        [boat_frame]
-            image="units/transport/raider/iron-raider.png:120"
-            auto_vflip=no
-        [/boat_frame]
-        [boat_frame]
-            image="units/transport/raider/iron-hit-b.png:220"
-            auto_vflip=no
-        [/boat_frame]
-        [boat_frame]
-            image="units/transport/raider/iron-raider.png:260"
-            auto_vflip=no
-        [/boat_frame]
-    [/defend]
-    [death]
-        start_time=0
-        alpha=1.0:800,1.0~0.0:280,0.0:1
-        [frame]
-            image="units/transport/raider/iron-die[1~12].png:[90*12]"
-        [/frame]
-    [/death]
-    [movement_anim]
-        start_time=0
-        boat_start_time=0
-        boat_y=0~-2:320,-2~0:320,0~2:320,2~0:320
-        boat_offset="0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200"
-        [frame]
-            image="misc/blank-hex.png:1600"
-        [/frame]
-        [boat_frame]
-            image="units/transport/raider/iron-move-[a,b,a,b,a,b,a,b].png:[200*8]"
-            auto_vflip=no
-            #image_mod=~MASK(units/transport/raider/mask.png)
-        [/boat_frame]
-    [/movement_anim]
-    [attack]
-        name=bow
-        description=_"bow"
-        icon=attacks/bow.png
-        type=pierce
-        range=ranged
-        # maybe this should be swarm
-        damage=6
-        number=5
-    [/attack]
-    [attack]
-        name=ram
-        description=_"naval ram"
-        icon=attacks/naval_ram.png
-        type=impact
-        range=melee
-        damage=12
-        number=1
-        [specials]
-            {WEAPON_SPECIAL_NAVAL_RAM}
-        [/specials]
-    [/attack]
-    [attack_anim]
-        [filter_attack]
-            name=bow
-        [/filter_attack]
-        start_time=-200
-        missile_start_time=-150
-        boat_start_time=-200
-        boat_y=0~2:80,2~-2:140,-2~0:80
-        [missile_frame]
-            duration=150
-            image="projectiles/missile-n.png"
-            image_diagonal="projectiles/missile-ne.png"
-        [/missile_frame]
-        [boat_frame]
-            image="units/transport/raider/iron-raider.png:300"
-            auto_vflip=no
-            # image_mod=~MASK(units/transport/raider/mask.png)
-        [/boat_frame]
-        [frame]
-            image="misc/blank-hex.png:300"
-        [/frame]
-    [/attack_anim]
-    [attack_anim]
-        [filter_attack]
-            name=ram
-        [/filter_attack]
-        # placeholder anim
-        start_time=-200
-        boat_start_time=-200
-        boat_y=0~2:80,2~-4:340,-4~0:180
-        boat_offset=0.0~-0.05:100,-0.05~0.8:200,0.8~0.0:300
-        [boat_frame]
-            image="units/transport/raider/iron-move-[a,b,a,b,a,b].png:[100*6]"
-            auto_vflip=no
-        [/boat_frame]
-        [frame]
-            image="misc/blank-hex.png:600"
-        [/frame]
-    [/attack_anim]
-[/unit_type]

data/core/units/boats/Transport_Galleon.cfg

@@ -2,7 +2,7 @@
 [unit_type]
     id=Transport Galleon
     name= _ "Transport Galleon"
-    race=ship
+    race=transport
     image="units/transport/transport-galleon.png"
     # ideally, we have "crew" that make sense for dialogs, and "mechanical" that depicts the transport
     # but for now, we just have "crew"

data/core/units/dunefolk/Warmaster.cfg

@@ -8,7 +8,7 @@ units/dunefolk/soldier/#enddef
     name= _ "Dune Warmaster"
     race=dunefolk
     image="{PATH_TEMP}warmaster.png"
-    hitpoints=61
+    hitpoints=59
     movement_type=dunearmoredfoot
     movement=5
     experience=150
@@ -31,7 +31,7 @@ units/dunefolk/soldier/#enddef
         description= _ "scimitar"
         type=blade
         range=melee
-        damage=10
+        damage=9
         number=4
         icon=attacks/scimitar.png
     [/attack]

data/core/units/dwarves/Explorer.cfg

@@ -7,11 +7,6 @@
     profile="portraits/dwarves/explorer.webp"
     hitpoints=60
     movement_type=dwarvishfoot
-    [resistance]
-        blade=90
-        pierce=90
-        impact=90
-    [/resistance]
     movement=5
     experience=150
     level=3
@@ -19,16 +14,17 @@
     advances_to=null
     {AMLA_DEFAULT}
     cost=51
-    usage=mixed fighter
+    usage=scout
     description= _ "Dwarvish Explorers are peerless survivalists. Using only the equipment they carry, they can range for months around the forests and mountains looking for new seams of ore and deposits of minerals. Whilst their skill in a melee is less than some other dwarves, they are unmatched with throwing axes, having practiced this skill hunting in the mountains. Their maneuverability makes them dangerous and tricky foes."
     die_sound={SOUND_LIST:DWARF_DIE}
+    #weakened from 12 damage to 10 damage
     {DEFENSE_ANIM "units/dwarves/explorer-defend-2.png" units/dwarves/explorer-defend-1.png {SOUND_LIST:DWARF_HIT} }
     [attack]
         name=battle axe
         description= _"battle axe"
         type=blade
         range=melee
-        damage=11
+        damage=10
         number=3
         icon=attacks/battleaxe.png
     [/attack]

data/core/units/dwarves/Pathfinder.cfg

@@ -18,7 +18,7 @@
     alignment=neutral
     advances_to=Dwarvish Explorer
     cost=24
-    usage=mixed fighter
+    usage=scout
     description= _ "These hardy dwarves are sometimes away from their caves for long periods, scouting and patrolling the borders. They spend this time watching for invaders, and fighting bandits and thieves who encroach on dwarvish territory. They are powerful fighters in a melee, and from a distance their deftly thrown axes can rival the power and accuracy of a human archer."
     die_sound={SOUND_LIST:DWARF_DIE}
     #weakened from 9 damage to 8 damage

data/core/units/monsters/Fire_Guardian.cfg

@@ -8,7 +8,12 @@
     profile="portraits/monsters/fire_guardian.webp"
     {DEFENSE_ANIM "units/monsters/fireghost-defend.png" "units/monsters/fireghost.png" {SOUND_LIST:DRAKE_HIT} }
     hitpoints=25
-    movement_type=flamefly
+    movement_type=drakefly
+    [resistance]
+        blade=100
+        pierce=100
+        impact=100
+    [/resistance]
     movement=6
     experience=24
     level=1

data/core/units/monsters/Fire_Wisp.cfg

@@ -7,7 +7,12 @@
     image="units/monsters/firewisp.png"
     profile="portraits/monsters/fire_guardian.webp" # temporary portrait
     hitpoints=13
-    movement_type=flamefly
+    movement_type=drakefly
+    [resistance]
+        blade=100
+        pierce=100
+        impact=100
+    [/resistance]
     movement=6
     experience=18
     level=0

data/core/units/monsters/Fire_Wraith.cfg

@@ -29,12 +29,11 @@ units/monsters/firewraith#enddef
         [/frame]
     [/movement_anim]
     hitpoints=41
-    movement_type=flamefly
+    movement_type=drakefly
     [resistance]
         blade=90
         pierce=90
         impact=90
-        fire=20
     [/resistance]
     movement=6
     experience=100

data/core/units/orcs/Crossbowman.cfg

@@ -8,7 +8,7 @@
     hitpoints=46
     movement_type=orcishfoot
     movement=5
-    experience=57
+    experience=43
     level=2
     alignment=chaotic
     advances_to=Orcish Slurbow
@@ -33,7 +33,7 @@
         icon=attacks/sword-orcish.png
         type=blade
         range=melee
-        damage=4
+        damage=6
         number=3
     [/attack]
     [attack]

data/gui/themes/default/window/help_browser.cfg

@@ -103,7 +103,7 @@
 	[resolution]
 		definition = "default"
 
-		{GUI_WINDOW_FIXED_SIZE_CENTERED 1350 800}
+		{GUI_WINDOW_FIXED_SIZE_CENTERED 1300 800}
 
 		[tooltip]
 			id = "tooltip_large"
@@ -259,7 +259,7 @@
 															vertical_grow = true
 
 															[rich_label]
-																width = 750
+																width = 700
 																id = "topic_text"
 															[/rich_label]
 														[/column]

data/languages/cs_CZ.cfg

@@ -2,5 +2,5 @@
     name="Čeština"
     sort_name = "Cestina"
     locale=cs_CZ
-    percent=99
+    percent=98
 [/locale]

data/languages/de_DE.cfg

@@ -2,5 +2,5 @@
     name="Deutsch"
     locale=de_DE
     alternates=de_LI, de_LU, de_CH, de_AT
-    percent=98
+    percent=94
 [/locale]

data/languages/en@shaw.cfg

@@ -3,5 +3,5 @@
     sort_name = "English (·𐑖𐑭𐑝𐑾𐑯)"
     locale=en@shaw
     alternates=en_AG@shaw, en_AU@shaw, en_CA@shaw, en_BW@shaw, en_DK@shaw, en_GB@shaw, en_HK@shaw, en_IE@shaw, en_IN@shaw, en_NG@shaw, en_NZ@shaw, en_PH@shaw, en_SG@shaw, en_US@shaw, en_ZA@shaw, en_ZW@shaw
-    percent=29
+    percent=30
 [/locale]

data/languages/hu_HU.cfg

@@ -1,5 +1,5 @@
 [locale]
     name="Magyar"
     locale=hu_HU
-    percent=90
+    percent=78
 [/locale]

data/languages/it_IT.cfg

@@ -1,5 +1,5 @@
 [locale]
     name="Italiano"
     locale=it_IT
-    percent=99
+    percent=96
 [/locale]

data/languages/lv_LV.cfg

@@ -1,5 +1,5 @@
 [locale]
     name="Latviešu"
     locale=lv_LV
-    percent=49
+    percent=50
 [/locale]

data/languages/nb_NO.cfg

@@ -1,5 +1,5 @@
 [locale]
     name="Norsk bokmål"
     locale=nb_NO
-    percent=68
+    percent=69
 [/locale]

data/languages/ru_RU.cfg

@@ -2,5 +2,5 @@
     name="Русский (Russkij)"
     sort_name = "Russkij"
     locale=ru_RU
-    percent=92
+    percent=93
 [/locale]

data/languages/sk_SK.cfg

@@ -1,5 +1,5 @@
 [locale]
     name="Slovenčina"
     locale=sk_SK
-    percent=92
+    percent=93
 [/locale]

data/lua/wml/message.lua

@@ -296,7 +296,7 @@ local function message_user_choice(cfg, speaker, options, text_input, sound)
 		local option_chosen, ti_content = gui.show_narration(msg_cfg, options, text_input)
 
 		if voice then
-			wesnoth.audio.sources.wml_message_speaker = nil
+			wesnoth.sources.wml_message_speaker = nil
 		end
 
 		if option_chosen == -2 then -- Pressed Escape (only if no input)

data/tools/wesnoth/version.py

@@ -2,7 +2,7 @@
 
 major = 1
 minor = 19
-release = 7
+release = 6
 dev_suffix = "+dev" # either use "+dev", "-dev", "" (empty string) or None
 
 as_string = "{}.{}.{}{}".format(major,

doc/doxygen/Doxyfile

@@ -38,7 +38,7 @@ PROJECT_NAME           = "The Battle for Wesnoth"
 # could be handy for archiving the generated documentation or if some version
 # control system is used.
 
-PROJECT_NUMBER         = 1.19.7+dev
+PROJECT_NUMBER         = 1.19.6+dev
 
 # Using the PROJECT_BRIEF tag one can provide an optional one line description
 # for a project that appears at the top of each page and should give viewer a