We don't need the upscaled sprite background behind portraits, whether
they are transparent or not (for transparent portraits it just looks
bad).
[ci skip]
Turns the unit description section into a flex container with the unit
portraits on the right, wherever flex is supported.
Fixeswesnoth/wesmere#4 and wesnoth/wesmere#3.
People moved strings around when refactoring parts of the help system in
1.13.x and didn't make sure to carry the textdomain symbol around, so a
bunch of strings that used to be in wesnoth-help in 1.12.x are now in
the main wesnoth textdomain. Sad!
[portrait] was an implementation detail of an early version of the GUI2
[message] dialog back in 1.5.x and it was supposed to go away shortly
after the experimentation stage, according to mordante, and especially
after ~RIGHT() was implemented.
For some bizarre reason, units.w.o has been relying on this tag all
along, meaning that many UMC unit portraits, and all mainline portraits
since a 1.13.x release are no longer displayed because they are
specified using the standard profile= attribute instead.
The new code has a smaller markup fingerprint (no more inline event
Javascript attributes) and it also ports the outer-click-dismiss
functionality over from the wiki. It raises the Javascript engine
requirements to IE 9 and later, though, which is inline with the home
page code.
Some refactoring and a lot of code changes are involved in this.
Basically, wmlunits has always fully trusted its WML input. This has
several implications:
* URLs such as the ones for unit detail views tend to contain
unescaped characters which are forbidden in URLs, such as spaces.
While browsers generally tolerate this well, the result is still
invalid HTML. The same applies to URLs used for inline CSS (e.g.
background-image).
* Most information read from WML such as unit names, descriptions,
campaign names, era names, and so on, was blindly trusted and could
allow an attacker to inject malicious HTML into units.wesnoth.org by
uploading an add-on that would pass the units.wesnoth.org build
process.
The resulting code might not be extent of regressions, but hopefully
we'll identify them quickly. This commit contains some additional noise
in the form of style fixes around offending lines as well. Backporting
to 1.12 is, as far as I understand, unnecessary since units.wesnoth.org
uses the master branch version of wmlunits, but it might be worth
evaluating whether to issue a warning for the 1 person in the world who
might be running the 1.12 version of the units.wesnoth.org toolchain on
their own facilities (okay, let's face it, nobody would ever do that).
* There is now a link back to units.wesnoth.org on the navbar preceding
Home.
* The mulitplication sign is used for attack stats to match 1.13.x.
* Made the Terrain table in the unit detail pages a bit more proper
markup-wise.
* Advances from/to on the unit detail page displays a dash when empty
and also has a comma-separated list of unit links in it. The same goes
for the abilities list.
