Reasoning being:
* The result_set and other APIs are nicer to use.
* We use mariadb on our server rather than mysql, so this would minimize the chance of any incompatibilities.
* The mysql C++ connector 1.1 isn't compatible with with c++17 (https://stackoverflow.com/q/47284705).
* Whether the game allows observers.
* Whether the game's replay should be publicly available (currently the same as whether observers are allowed pending the second part of #3909).
* Whether the game had a password set.
* The side's name - this differs from what can be retrieved from USER_ID since it will have the name of any AI used.
Add a "BSD Repository" option.
Add data/dist to .gitignore.
Delete data/dist from git.
Error conditions reading data/dist just set the value to Default.
Remove a leftover TODO comment.
Add description comments for the two new database columns.
This will make it easier to add/remove people to/from the group, and also ensure that the list of actual moderators matches up with the list available to users.
New config attributes added for this are:
* db_group_table - should be, based on the phpbb documentation I found, phpbb_user_group
* mp_mod_group - should be set to Multiplayer Moderators group ID
This requires three more tables to be added to any database with the forum user handler enabled, the structures of which are defined in the wesnothd man page:
* `db_game_info_table` - stores information about each game.
* `db_game_player_info_table` - stores information about each player in the game.
* `db_game_modification_info_table` - stores information about any modifications that are enabled for the game.
If we try to send a message immediately after signaling SIGHUP to
wesnothd, it won't get caught by wesnothd, probably because the control
socket is being reopened just as the message arrives. Thus, we need a 1
second delay after the signal.
This was fixed in production a while ago but I forgot to commit the
change.
At least on baldras' version of screen, the stuff command argument here
absolutely needs to be wrapped in single or double quotes to work.
I actually fixed this months ago but forgot to commit.
* Using scons -Y to point scons to a source tree that might be
read-only for the user building campaignd/wesnothd (as is the case on
baldras).
* Renamed or changed several variables for clarity.
* As a side-effect, links within the server instance dir are now
absolute rather than relative (/home/wesnoth/build/foo/bar instead of
../../build/foo/bar).
* ~/builds-int/<version> is the intermediate build directory
* ~/builds/<build-id> remains as the target directory
* /usr/src/wesnoth is the source directory base (we need to handle
basilic and gonzo separately later)
I'm fairly sure nobody other than me could possibly demand a more
detailed description of this commit.
They mostly seem to be code cleanups or style changes, plus the hack to
try to start the irc echo for the old instance after restarting... which
doesn't seem to be working.
* Added code for handling 1.8 and 1.10
* Don't use libana for Wesnoth versions that include it (1.9.x)
* We now use Git, not SVN. The downstream repository is managed
externally, so we need to update a git-new-workdir checkout every
time we want to build.
* Other nondescript changes
(Apologies for the horrible commit message, but it looks like there was
more than my own changes awaiting to be committed.)
Most references to and dependencies on Subversion have been removed.
"+svn" is now "+dev". Files that can't be fixed yet have a FIXME-GIT
comment in them; most of these are in the website tests.
