From fe934c60a7dbab19ca9e96945db1591c7888f924 Mon Sep 17 00:00:00 2001
From: Charles Dang <exodia339@gmail.com>
Date: Tue, 13 Sep 2016 17:30:43 +1100
Subject: [PATCH] Refactored use of util::scoped_resource out of surface struct
 (now class)

util::scoped_resource is likely going to be removed soon and replaced with std::unique_ptr. However,
due to the custom refcounting done on the SDL_Surfaces, here, we cannot use unique_ptr or shared_ptr.
Therefor, we simply add the functionality manually.
---
 src/sdl/utils.hpp | 78 ++++++++++++++++++++++++++---------------------
 1 file changed, 44 insertions(+), 34 deletions(-)

diff --git a/src/sdl/utils.hpp b/src/sdl/utils.hpp
index 4918c74915a..ae37ce0be70 100644
--- a/src/sdl/utils.hpp
+++ b/src/sdl/utils.hpp
@@ -48,62 +48,72 @@
 
 SDL_Keycode sdl_keysym_from_name(std::string const &keyname);
 
-
-struct surface
+class surface
 {
-private:
-	static void sdl_add_ref(SDL_Surface *surf)
-	{
-		if (surf != nullptr)
-			++surf->refcount;
-	}
-
-	struct free_sdl_surface {
-		void operator()(SDL_Surface *surf) const
-		{
-			if (surf != nullptr)
-				 SDL_FreeSurface(surf);
-		}
-	};
-
-	typedef util::scoped_resource<SDL_Surface*,free_sdl_surface> scoped_sdl_surface;
 public:
 	surface() : surface_(nullptr)
 	{}
 
-	surface(SDL_Surface *surf) : surface_(surf)
+	surface(SDL_Surface* surf) : surface_(surf)
 	{}
 
-	surface(const surface& o) : surface_(o.surface_.get())
+	surface(const surface& s) : surface_(s.get())
 	{
-		sdl_add_ref(surface_.get());
+		add_surface_ref(surface_);
 	}
 
-	void assign(const surface& o)
+	~surface()
 	{
-		SDL_Surface *surf = o.surface_.get();
-		sdl_add_ref(surf); // need to be done before assign to avoid corruption on "a=a;"
-		surface_.assign(surf);
+		free_surface();
 	}
 
-	surface& operator=(const surface& o)
+	void assign(SDL_Surface* surf)
 	{
-		assign(o);
+		assign_surface_internal(surf);
+	}
+
+	void assign(const surface& s)
+	{
+		assign_surface_internal(s.get());
+	}
+
+	surface& operator=(const surface& s)
+	{
+		assign(s);
 		return *this;
 	}
 
-	operator SDL_Surface*() const { return surface_.get(); }
+	operator SDL_Surface*() const { return surface_; }
 
-	SDL_Surface* get() const { return surface_.get(); }
+	SDL_Surface* get() const { return surface_; }
 
-	SDL_Surface* operator->() const { return surface_.get(); }
+	SDL_Surface* operator->() const { return surface_; }
 
-	void assign(SDL_Surface* surf) { surface_.assign(surf); }
-
-	bool null() const { return surface_.get() == nullptr; }
+	bool null() const { return surface_ == nullptr; }
 
 private:
-	scoped_sdl_surface surface_;
+	static void add_surface_ref(SDL_Surface* surf)
+	{
+		if(surf) {
+			++surf->refcount;
+		}
+	}
+
+	void assign_surface_internal(SDL_Surface* surf)
+	{
+		add_surface_ref(surf); // Needs to be done before assignment to avoid corruption on "a = a;"
+		free_surface();
+		surface_ = surf;
+	}
+
+	void free_surface()
+	{
+		if(surface_) {
+			SDL_FreeSurface(surface_);
+		}
+	}
+
+	SDL_Surface* surface_;
 };
 
 bool operator<(const surface& a, const surface& b);