0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Game Events: made use of some emplace_back when constructing handlers

Browse source 
And added a clarifying comment about types.
This commit is contained in:
Charles Dang 2017-11-30 10:06:46 +11:00
parent 2c12d1328b
commit fb5fd3f3c4
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/game_events/manager_impl.cpp
View file

@ -110,23 +110,23 @@ void event_handlers::add_event_handler(const config& cfg, bool is_menu_item)
}
// Create a new handler.
// Do note active_ holds the main shared_ptr, and the other three containers
// construct weak_ptrs from the shared one.
DBG_EH << "inserting event handler for name=" << name << " with id=" << id << "\n";
handler_ptr new_handler(new event_handler(cfg, is_menu_item));
active_.push_back(new_handler);
active_.emplace_back(new event_handler(cfg, is_menu_item));
// File by name.
if(utils::might_contain_variables(name)) {
dynamic_.push_back(new_handler);
dynamic_.emplace_back(active_.back());
} else {
for(const std::string& single_name : utils::split(name)) {
by_name_[standardize_name(single_name)].push_back(new_handler);
by_name_[standardize_name(single_name)].emplace_back(active_.back());
}
}
// File by ID.
if(!id.empty()) {
id_map_[id] = new_handler;
id_map_[id] = active_.back();
}
log_handlers();