0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Preferences Dialog: fixed issue where certain prefs aren't saved

Browse source 
If a preference wasn't in the selected tab, it wouldn't be saved. This was a serious issue.
See d1bcb6fe72 for more details.
This commit is contained in:
Charles Dang 2017-09-21 15:18:50 -04:00
parent d1bcb6fe72
commit ef0d4602e7
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/gui/dialogs/preferences_dialog.cpp
View file

@ -969,6 +969,8 @@ void preferences_dialog::pre_show(window& window)
listbox& selector = find_widget<listbox>(&window, "selector", false);
stacked_widget& pager = find_widget<stacked_widget>(&window, "pager", false);
pager.set_find_in_all_layers(true);
connect_signal_notify_modified(selector,
std::bind(&preferences_dialog::on_page_select, this, std::ref(window)));
@ -980,7 +982,7 @@ void preferences_dialog::pre_show(window& window)
const int main_index = index_in_pager_range(initial_index_.first, pager);
// Loops through each pager layer and checks if it has both a tab bar
// and stack. If so, it initilizes the options for the former and
// and stack. If so, it initializes the options for the former and
// selects the specified layer of the latter.
for(unsigned int i = 0; i < pager.get_layer_count(); ++i) {
listbox* tab_selector = find_widget<listbox>(