0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

addon/mg: Drop superfluous NULL pointer check

Browse source 
update_all_button's value is obtained from operator new, which will
throw if the allocation fails, so it can never be NULL in subsequent
statements.

Found by coverity.
This commit is contained in:
Ignacio R. Morelle 2014-11-18 23:35:52 -03:00
parent 01c3d7c38d
commit ed860bc9ba
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/addon/manager_ui.cpp
View file

@ -797,9 +797,7 @@ void show_addons_manager_dialog(display& disp, addons_client& client, addons_lis
if(dummy_addons_list) {
filter_box->hide(true);
description_button->enable(false);
if(update_all_button) {
update_all_button->enable(false);
}
update_all_button->enable(false);
addons_list_menu->hide(true);
}