0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make sure the pixels per step is a floating point number when needed.

Browse source 
Use a better positioner sizing algorithm when not items can be shown.
This commit is contained in:
Mark de Wever 2008-07-13 18:07:58 +00:00
parent bfb8185250
commit ec446aee22
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/gui/widgets/scrollbar.cpp
View file

@ -232,7 +232,7 @@ void tscrollbar_::recalculate()
// We can show them all.
available_length += minimum_positioner_length();
pixels_per_step_ = available_length / steps;
pixels_per_step_ = available_length / static_cast<float>(steps);
positioner_length_ = static_cast<unsigned>(pixels_per_step_ * visible_items_) + available_length % steps;
@ -242,8 +242,14 @@ void tscrollbar_::recalculate()
WRN_G << "The scrollbar is too small for the"
" number of items, movement might seem jerky.\n";
pixels_per_step_ = available_length / steps;
positioner_length_ = minimum_positioner_length();
pixels_per_step_ = available_length / static_cast<float>(steps);
// When a listbox is in 'pixel mode' (not fixed row height) the
// positioner might still be rather big so scale it proportional but
// respect the minimum.
positioner_length_ = std::max(
available_length * visible_items_ / item_count_,
minimum_positioner_length());
}
set_item_position(item_position_);