0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix commom OOS error #8960

Browse source 
Previously `synced_context::undo_blocked()` sometimes returned the worng result, leading to OOS because `synced_context::undo_blocked()` was used to determine whether we can send action to the other clients.

With this patch `synced_context::undo_blocked()` not doesn't always return true  when its called during "local choices".

I am curently not even sure whether that line is needed at all since using the rng should always set is_simultaneous_ to true.
This commit is contained in:
gfgtdf 2024-06-10 01:05:26 +02:00 • committed by Pentarctagon
parent dbbee82d9c
commit ebaafe6d6b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/synced_context.cpp
View file

@ -222,7 +222,7 @@ bool synced_context::undo_blocked()
// if the turn has ended undoing is blocked.
return is_simultaneous_
|| is_undo_blocked_
|| (randomness::generator->get_random_calls() != 0)
|| (is_synced() && (randomness::generator->get_random_calls() != 0))
|| resources::controller->is_regular_game_end()
|| resources::gamedata->end_turn_forced();
}