0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Attempt to fix recall dialog crashes

Browse source
This commit is contained in:
Celtic Minstrel 2016-08-02 14:55:52 -04:00
parent c4d51b1bbb
commit e75eaca5a0
2 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/gui/dialogs/unit_recall.cpp
View file

@ -121,14 +121,14 @@ static std::string trait_key(unit_const_ptr u)
return !u->trait_names().empty() ? u->trait_names().front().str() : "";
}
template<typename Fnc>
void tunit_recall::init_sorting_option(generator_sort_array& order_funcs, Fnc filter_on)
template<typename Ret>
void tunit_recall::init_sorting_option(generator_sort_array& order_funcs, std::function<Ret(unit_const_ptr)> filter_on)
{
order_funcs[0] = [this, &filter_on](unsigned i1, unsigned i2) {
order_funcs[0] = [this, filter_on](unsigned i1, unsigned i2) {
return filter_on((*recall_list_)[i1]) < filter_on((*recall_list_)[i2]);
};
order_funcs[1] = [this, &filter_on](unsigned i1, unsigned i2) {
order_funcs[1] = [this, filter_on](unsigned i1, unsigned i2) {
return filter_on((*recall_list_)[i1]) > filter_on((*recall_list_)[i2]);
};
}
@ -252,19 +252,19 @@ void tunit_recall::pre_show(twindow& window)
generator_sort_array order_funcs;
init_sorting_option(order_funcs, std::bind(&tstr_key, _1, &unit::type_name));
init_sorting_option<std::string>(order_funcs, std::bind(&tstr_key, _1, &unit::type_name));
list.set_column_order(0, order_funcs);
init_sorting_option(order_funcs, std::bind(&tstr_key, _1, &unit::name));
init_sorting_option<std::string>(order_funcs, std::bind(&tstr_key, _1, &unit::name));
list.set_column_order(1, order_funcs);
init_sorting_option(order_funcs, std::bind(&unit::level, _1));
init_sorting_option<int>(order_funcs, std::bind(&unit::level, _1));
list.set_column_order(2, order_funcs);
init_sorting_option(order_funcs, std::bind(&unit::experience, _1));
init_sorting_option<int>(order_funcs, std::bind(&unit::experience, _1));
list.set_column_order(3, order_funcs);
init_sorting_option(order_funcs, std::bind(&trait_key, _1));
init_sorting_option<std::string>(order_funcs, std::bind(&trait_key, _1));
list.set_column_order(4, order_funcs);
list_item_clicked(window);

4
src/gui/dialogs/unit_recall.hpp
View file

@ -54,8 +54,8 @@ private:
std::vector<std::string> filter_options_;
std::vector<std::string> last_words_;
template<typename T>
void init_sorting_option(generator_sort_array& order_funcs, T filter_on);
template<typename Ret>
void init_sorting_option(generator_sort_array& order_funcs, std::function<Ret(unit_const_ptr)> filter_on);
/** Callbacks */
void list_item_clicked(twindow& window);