0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

check for empty parameters before looping over all players

Browse source 
(cherry-picked from commit 0362e36305)
This commit is contained in:
Gunter Labes 2018-06-03 16:44:44 +02:00 • committed by Charles Dang
parent 1a72f04d4a
commit e4100fc3bd
1 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/server/server.cpp
View file

@ -2288,21 +2288,20 @@ void server::version_handler(
const std::string& /*issuer_name*/, const std::string& /*query*/, std::string& parameters, std::ostringstream* out)
{
assert(out != nullptr);
if(parameters.empty()) {
*out << "Server version is " << game_config::version;
return;
}
for(const auto& player : player_connections_) {
if(parameters == player.info().name()) {
*out << "Player " << parameters << " is using wesnoth " << player.info().version();
return;
}
}
if(parameters.empty()) {
*out << "Server version is " << game_config::version;
}
else {
*out << "Player " << parameters << " not found.";
}
*out << "Player '" << parameters << "' not found.";
}
void server::status_handler(