UtBS S9: Turn rebels into loyal units (#6371)

* Turn rebels into loyal units instead of just having zero upkeep costs for the scenario.

Resolves #6365.

changelog.md

@@ -32,7 +32,7 @@
        * Grog will not die as quick now (issue #6196 & #6197)
        * Hermit dialogue cannot be accidentally skipped now (issue #6196)
        * Fixed bug where tentacles would not spawn (issue #6196)
-     * S09: Rebels joining Kaleh’s side are now free of upkeep costs for the remainder of the scenario (issue #6229)
+     * S09: Rebels joining Kaleh’s side are now loyal (issue #6229 and #6365)
      * The last unit killed to trigger certain events should no longer linger during those events (issue #6341)
      * The Dark Assassin’s race is not revealed until uncloaked (issue #6213)
      * The Dust Devil’s XP bar is now blue (issue #6212)

data/campaigns/Under_the_Burning_Suns/scenarios/09_Blood_is_Thicker_Than_Water.cfg

@@ -2339,14 +2339,9 @@
                 side=3
             [/filter]
             side=1
-            # If the player kept as many of the rebels alive as possible it's possible for their income to become negative. Give the unit no upkeep cost to compensate.
-            # Note that having loyal upkeep is not the same as having the loyal trait, no loyal overlay will be displayed.
-            [object]
-                duration=scenario
-                [effect]
-                    apply_to=loyal
-                [/effect]
-            [/object]
+            # If the player kept as many of the rebels alive as possible it's possible for income to become negative when they join Kaleh's side.
+            # Make the units loyal as a reward for saving them - there will not be much more of the campaign to make use of them anyway.
+            {TRAIT_LOYAL}
         [/modify_unit]
         [redraw]
             clear_shroud=yes