0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Revert config unit tests to compare attributes to empty strings again

Browse source 
Reverts a change in commit 2eacb4e1c3.

The comparison in this unit test compared an *attribute* to an empty
string, not a *string*. Furthermore, the entire point of the test was
to verify that an empty attribute doesn't compare equal to the empty
string. In its old form, the test was just wrong (and failing).
This commit is contained in:
Jyrki Vesterinen 2017-10-23 20:04:21 +03:00
parent af9862cb73
commit de5a622626
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/tests/test_config.cpp
View file

@ -149,13 +149,13 @@ BOOST_AUTO_TEST_CASE ( test_config_attribute_value )
x_str = c["x"].str();
BOOST_CHECK_EQUAL(x_str, "123456789123");
// blank != "" test.
// blank != "" test.
c.clear();
BOOST_CHECK(!cc["x"].empty());
BOOST_CHECK(cc["x"] != "");
BOOST_CHECK(cc["x"].empty());
BOOST_CHECK(cc["x"].blank());
BOOST_CHECK(!c["x"].empty());
BOOST_CHECK(c["x"] != "");
BOOST_CHECK(c["x"].empty());
BOOST_CHECK(c["x"].blank());