campaignd: Don't prefix errors sent to clients with "#Error: "

The string only worked as intended before the GUI2/Pango days (i.e.
before some 1.5.x version), meaning that the client would use a red
color for the font.

In other words, deplorable user interface design.

Nowadays, the add-ons client uses a dedicated error message path for
presenting this kind of alerts to the user, which uses a dialog with a
visible "Error" caption and everything. We don't really need extra
formatting, and in any case, *it should not be the server's mission to
do this*!
This commit is contained in:
Ignacio R. Morelle 2014-01-14 00:55:19 -03:00
parent eb42dd2171
commit c84989632a

View file

@ -169,7 +169,7 @@ namespace {
config construct_error(const std::string& msg)
{
config cfg;
cfg.add_child("error")["message"] = "#Error: " + msg;
cfg.add_child("error")["message"] = msg;
LOG_CS << "ERROR: "<<msg<<"\n";
return cfg;
}