0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

MP Lobby: avoid unnecessary cache rebuild if no required addons were installed

Browse source 
I was unconditionally reloading the cache even if there were a reason ad_hoc_addon_fetch_session
failed. The cache will no longer be reloaded if said function didn't actually install anything.

Fixes #2477.
This commit is contained in:
Charles Dang 2018-02-11 14:23:27 +11:00
parent edd6b8d31c
commit c5e95d3b24
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/gui/dialogs/multiplayer/lobby.cpp
View file

@ -262,9 +262,7 @@ bool handle_addon_requirements_gui(const std::vector<mp::game_info::required_add
if(gui2::show_message(e_title, err_msg, message::yes_no_buttons, true) == gui2::window::OK) {
// Begin download session
ad_hoc_addon_fetch_session(needs_download);
return true;
return ad_hoc_addon_fetch_session(needs_download);
}
}