0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don't trigger achievement completion during replays.

Browse source 
Fixes #8858
This commit is contained in:
pentarctagon 2024-05-07 18:10:47 -05:00 • committed by Pentarctagon
parent 3e4e805b08
commit c1cce5c806
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/scripting/game_lua_kernel.cpp
View file

@ -3110,7 +3110,9 @@ int game_lua_kernel::intf_set_achievement(lua_State *L)
return 0;
}
// found the achievement - mark it as completed
preferences::set_achievement(content_for, id);
if(!play_controller_.is_replay()) {
preferences::set_achievement(content_for, id);
}
achieve.achieved_ = true;
// progressable achievements can also check for current progress equals -1
if(achieve.max_progress_ != 0) {
@ -3242,7 +3244,10 @@ int game_lua_kernel::intf_progress_achievement(lua_State *L)
}
if(!achieve.achieved_) {
int progress = preferences::progress_achievement(content_for, id, limit, achieve.max_progress_, amount);
int progress = 0;
if(!play_controller_.is_replay()) {
progress = preferences::progress_achievement(content_for, id, limit, achieve.max_progress_, amount);
}
if(progress >= achieve.max_progress_) {
intf_set_achievement(L);
achieve.current_progress_ = -1;
@ -3319,7 +3324,9 @@ int game_lua_kernel::intf_set_sub_achievement(lua_State *L)
if(sub_ach.achieved_) {
return 0;
} else {
preferences::set_sub_achievement(content_for, id, sub_id);
if(!play_controller_.is_replay()) {
preferences::set_sub_achievement(content_for, id, sub_id);
}
sub_ach.achieved_ = true;
achieve.current_progress_++;
if(achieve.current_progress_ == achieve.max_progress_) {