0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Coverity Fixes - Uninitalized SDL_UserEvent timestamp field

Browse source 
Closes
    CID 1380246
    CID 1380234
    CID 1380159
    CID 1380152
    CID 1356356
This commit is contained in:
Gregory A Lundberg 2017-09-02 11:55:07 -05:00 • committed by Charles Dang
parent c5454373b7
commit b7a42c495f
5 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/events.cpp
View file

@ -553,6 +553,7 @@ void pump()
user_event.code = 0;
user_event.data1 = reinterpret_cast<void*>(event.button.x);
user_event.data2 = reinterpret_cast<void*>(event.button.y);
user_event.timestamp = std::time(nullptr);
::SDL_PushEvent(reinterpret_cast<SDL_Event*>(&user_event));
}
@ -760,6 +761,7 @@ void call_in_main_thread(const std::function<void(void)>& f)
sdl_userevent.code = 0;
sdl_userevent.data1 = &fdata;
sdl_userevent.data2 = nullptr;
sdl_userevent.timestamp = std::time(nullptr);
sdl_event.type = INVOKE_FUNCTION_EVENT;
sdl_event.user = sdl_userevent;

1
src/gui/core/event/distributor.cpp
View file

@ -66,6 +66,7 @@ static Uint32 popup_callback(Uint32 /*interval*/, void* /*param*/)
data.code = 0;
data.data1 = 0;
data.data2 = 0;
data.timestamp = std::time(nullptr);
event.type = HOVER_REMOVE_POPUP_EVENT;
event.user = data;

1
src/gui/core/event/handler.cpp
View file

@ -85,6 +85,7 @@ static Uint32 timer_sdl_draw_event(Uint32, void*)
data.code = 0;
data.data1 = nullptr;
data.data2 = nullptr;
data.timestampt = std::time(nullptr);
event.type = DRAW_EVENT;
event.user = data;

3
src/gui/widgets/window.cpp
View file

@ -142,6 +142,7 @@ static Uint32 draw_timer(Uint32, void*)
data.code = 0;
data.data1 = nullptr;
data.data2 = nullptr;
data.timestamp = std::time(nullptr);
event.type = DRAW_EVENT;
event.user = data;
@ -194,6 +195,7 @@ static bool helptip()
data.code = 0;
data.data1 = nullptr;
data.data2 = nullptr;
data.timestamp = std::time(nullptr);
event.type = SHOW_HELPTIP_EVENT;
event.user = data;
@ -604,6 +606,7 @@ int window::show(const bool restore, const unsigned auto_close_timeout)
data.code = manager::instance().get_id(*this);
data.data1 = nullptr;
data.data2 = nullptr;
data.timestamp = std::time(nullptr);
event.type = CLOSE_WINDOW_EVENT;
event.user = data;

2
src/video.cpp
View file

@ -72,6 +72,7 @@ void trigger_full_redraw() {
data.code = 0;
data.data1 = nullptr;
data.data2 = nullptr;
data.timestamp = std::time(nullptr);
drawEvent.type = DRAW_ALL_EVENT;
drawEvent.user = data;
@ -158,6 +159,7 @@ void CVideo::video_event_handler::handle_window_event(const SDL_Event &event)
data.code = 0;
data.data1 = nullptr;
data.data2 = nullptr;
data.timestamp = std::time(nullptr);
drawEvent.type = DRAW_ALL_EVENT;
drawEvent.user = data;