0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove warning about leaking drawing surface.

Browse source 
It does get correctly freed by the wrapper when reassigned.
This commit is contained in:
Tommy 2022-04-20 20:00:16 +12:00
parent b530a47502
commit 9ece8ccc71
1 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/video.cpp
View file

@ -249,18 +249,11 @@ void CVideo::update_framebuffer()
uint32_t format = window->pixel_format();
int bpp = SDL_BITSPERPIXEL(format);
// Free the old drawing surface.
if (drawingSurface) {
// Except it can still be in use... what should we do about that?
LOG_DP << "leaking old drawing surface" << std::endl;
//LOG_DP << "freeing old drawing surface" << std::endl;
//SDL_FreeSurface(drawingSurface);
}
// This should match the old system, and so shouldn't cause any
// problems that weren't there already.
LOG_DP << "creating " << bpp << "bpp drawing surface with format "
<< SDL_GetPixelFormatName(format) << std::endl;
// Note: "surface" destructor automatically frees the old surface
drawingSurface = SDL_CreateRGBSurfaceWithFormat(
0,
wsize.x / scale,