GUI2/Message: tweaked Magic Numbers to fix layout failure with large portraits

[ci skip]

Fixes #2912
This commit is contained in:
Charles Dang 2018-05-24 10:23:15 +11:00
parent fef4254c84
commit 9bf7a4c8fb
2 changed files with 8 additions and 1 deletions

View file

@ -103,6 +103,7 @@
unlike in 1.12 (issue #3033). unlike in 1.12 (issue #3033).
* Fixed the first unit sometimes not being selected when opening the Recall * Fixed the first unit sometimes not being selected when opening the Recall
dialog. dialog.
* Fixed a crash when using very large portraits in [message] (issue #2912)
### WML engine ### WML engine
* Support formula= key in [variable] ConditionalWML * Support formula= key in [variable] ConditionalWML
* Support to_location in [move_unit], taking a location ID * Support to_location in [move_unit], taking a location ID

View file

@ -36,7 +36,13 @@ where
0 0
) )
), ),
max_height = (gamemap_height - 4) # TODO: this is rather hacky. The old value was gamemap_height - 4 but that caused
# crashes with the 727 px high Rithrandil portrait in TRoW. This value seems to work,
# but the fact that it crashed at all points to some deeper logic flaw in the size
# calculation formulas here. Need to revisit at some point...
#
# -- vultraz, 2018-05-24
max_height = (gamemap_height - 30)
) )
)#enddef )#enddef