0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed potential UB

Browse source 
this pointer needs to be duplicated because accepted_versions_ change
e.g. from load_config() could invalidate it
This commit is contained in:
loonycyborg 2021-01-12 13:05:50 +03:00
parent 8b7b22e14b
commit 99c7bd3214
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/server/server.cpp
View file

@ -657,7 +657,7 @@ void server::read_version(socket_ptr socket, std::shared_ptr<simple_wml::documen
<< ":\trejecting them\n";
// For compatibility with older clients
response.set_attr("version", accepted_versions_.begin()->c_str());
response.set_attr_dup("version", accepted_versions_.begin()->c_str());
simple_wml::node& reject = response.root().add_child("reject");
reject.set_attr_dup("accepted_versions", utils::join(accepted_versions_).c_str());