0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ai_helper.lua: avoid using table.remove

Browse source 
It’s slow. The inverse logic using table.insert is much faster,
especially for large tables.
This commit is contained in:
mattsc 2014-04-17 20:35:48 -07:00
parent e87240c67f
commit 9701a724a8
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
data/ai/lua/ai_helper.lua
View file

@ -1365,12 +1365,13 @@ function ai_helper.get_attack_combos_full(units, enemy)
-- Return value:
-- 1. Attack combinations in form { dst = src }
local attacks = ai_helper.get_attacks(units)
local all_attacks = ai_helper.get_attacks(units)
-- Eliminate those that are not on @enemy
for i = #attacks,1,-1 do
if (attacks[i].target.x ~= enemy.x) or (attacks[i].target.y ~= enemy.y) then
table.remove(attacks, i)
local attacks = {}
for _,attack in ipairs(all_attacks) do
if (attack.target.x == enemy.x) and (attack.target.y == enemy.y) then
table.insert(attacks, attack)
end
end
if (not attacks[1]) then return {} end
@ -1515,6 +1516,7 @@ function ai_helper.get_attack_combos(units, enemy, cfg)
end
-- This last step eliminates the "empty attack combo" (the one with all zeros)
-- Since this is only one, it's okay to use table.remove (even though it's slow)
table.remove(attack_array, i_empty)
return attack_array