0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix broken help crosslinks for unit types with all-hidden variations

Browse source 
Regression introduced in 6fe72e893f.
Affected master only, because I missed two relevant lines when manually
forward-porting its 1.12 counterpart.
This commit is contained in:
Ignacio R. Morelle 2014-12-22 21:16:14 -03:00
parent b63e4e5f29
commit 92be8cd73d
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/help/help_topic_generators.cpp
View file

@ -289,7 +289,7 @@ std::string unit_topic_generator::operator()() const {
std::string lang_unit = type->type_name();
std::string ref_id;
if (description_type(*type) == FULL_DESCRIPTION) {
const std::string section_prefix = type->variations().empty() ? "" : "..";
const std::string section_prefix = type->show_variations_in_help() ? ".." : "";
ref_id = section_prefix + unit_prefix + type->id();
} else {
ref_id = unknown_unit_topic;
@ -315,7 +315,7 @@ std::string unit_topic_generator::operator()() const {
first = false;
}
const unit_type* base_type = unit_types.find(base_id, unit_type::HELP_INDEXED);
const std::string section_prefix = base_type->variations().empty() ? "" : "..";
const std::string section_prefix = base_type->show_variations_in_help() ? ".." : "";
ss << make_link(base_type->type_name(), section_prefix + unit_prefix + base_id) << "\n";
}
}