0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

add some TODO comment about [do_command]

Browse source
This commit is contained in:
gfgtdf 2017-01-14 23:10:52 +01:00 • committed by GitHub
parent bca0a2e380
commit 887fc584c2
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/game_events/action_wml.cpp
View file

@ -299,6 +299,12 @@ WML_HANDLER_FUNCTION(do_command,, cfg)
ERR_NG << "allowed tags: " << o.str() << std::endl;
continue;
}
// TODO: afaik run_in_synced_context_if_not_already thows exceptions when the executed action end the scenario or the turn.
// This could cause problems, specially when its unclear whether that excetion is caught by lua or not...
// TODO: What happens when this command is run on a client that doesnt control the currentl playing side?
// I couldn't find any code that gives a proper error message in that case.
//Note that this fires related events and everthing else that also happen normally.
//have to watch out with the undo stack, therefore forbid [auto_shroud] and [update_shroud] here...
synced_context::run_in_synced_context_if_not_already(