UtBS: New graphics for Eloh by me

There are two layers of halos and they are applied in a somewhat
convoluted fashion. I should probably explain why.

The bottom halo is designed so it's drawn *below* the main unit sprite
so as to not muddle the colours on it. Halos are normally drawn *on top*
of sprites.

The back halo is specifically masked so it's drawn behind the main unit
sprite without overlapping any of its pixels, but it's asymmetrical and
supposed to flip along with the unit sprite depending on the direction
it's facing. Halos do not do that currently, at least not without using
animation WML conditionals. Unfortunately, for some reason, using a
standing animation that's nothing but conditionals causes the game to
crash at the moment.

Taking all this into consideration, using the blit IPF is a much easier
mechanism to avoid both issues at once, even if it makes the code
slightly awkward.

If someone can think of an alternative method, they're more than welcome
to change the code as long as the sprite's composition remains exactly
the same as it is now. I'm just the artist in this case.

[ci skip]

changelog.md

@@ -2,6 +2,8 @@
  ### Campaigns
    * Tutorial:
      * Added more information to the Status Table prompt about how to access it (issue #2883).
+   * Under the Burning Suns:
+     * New graphics for Eloh.
  ### Language and i18n
    * Updated translations: British English
  ### User Interface

data/campaigns/Under_the_Burning_Suns/units/quenoth/Divine_Avatar.cfg

@@ -5,6 +5,8 @@
     gender=female
     race=elf
     image=units/quenoth/eloh.png
+    # The baseframe is larger than usual to make compositing with the back haloin animations trivial.
+    bar_offset_x,bar_offset_y=0,0
     profile=portraits/eloh.png
     hitpoints=40
     movement_type=woodland
@@ -18,7 +20,7 @@
     usage=null
     do_not_list=yes
     description= _ "Divine Avatars only appear in time of great need. Forms of the Gods themselves, made real in this world for a time, blessed are those who are lucky enough to view such images of power and perfection."+{SPECIAL_NOTES}+{SPECIAL_NOTES_ARCANE}+{SPECIAL_NOTES_MAGICAL}
-    {DEFENSE_ANIM "units/quenoth/eloh.png" "units/quenoth/eloh.png" magicmissile.wav }
+    {DEFENSE_ANIM "halo/eloh-halo-bottom.png~BLIT(halo/eloh-halo-back.png)~BLIT(units/quenoth/eloh.png,0,0)" "halo/eloh-halo-bottom.png~BLIT(halo/eloh-halo-back.png)~BLIT(units/quenoth/eloh.png,0,0)" magicmissile.wav}
     die_sound=magic-holy-miss-2.ogg
     [attack]
         name=fist
@@ -41,16 +43,25 @@
         damage=10
         number=2
     [/attack]
+
+    [standing_anim]
+        start_time=0
+        [frame]
+            image="halo/eloh-halo-bottom.png~BLIT(halo/eloh-halo-back.png)~BLIT(units/quenoth/eloh.png,0,0):100"
+        [/frame]
+    [/standing_anim]
+
     [attack_anim]
         [filter_attack]
             name=fist
         [/filter_attack]
         start_time=-200
         [frame]
-            image="units/quenoth/eloh.png:375"
+            image="halo/eloh-halo-bottom.png~BLIT(halo/eloh-halo-back.png)~BLIT(units/quenoth/eloh.png,0,0):100"
         [/frame]
         {SOUND:HIT_AND_MISS fist.ogg {SOUND_LIST:MISS} -100}
     [/attack_anim]
+
     [attack_anim]
         [filter_attack]
             name=lightbeam
@@ -58,8 +69,10 @@
         {MISSILE_FRAME_LIGHT_BEAM}
         start_time=-100
         [frame]
-            image="units/quenoth/eloh.png:100"
+            image="halo/eloh-halo-bottom.png~BLIT(halo/eloh-halo-back.png)~BLIT(units/quenoth/eloh.png,0,0):100"
         [/frame]
         {SOUND:HIT_AND_MISS {SOUND_LIST:HOLY} {SOUND_LIST:HOLY_MISS} -100}
     [/attack_anim]
 [/unit_type]
+
+# kate: indent-mode normal; encoding utf-8; space-indent on;