0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix Coverity divide-by-zero warning

Browse source 
Closes CID 1380221

Instead of assert() throw an exception explaining what went wrong.
This commit is contained in:
Gregory A Lundberg 2017-09-11 05:45:24 -05:00 • committed by Jyrki Vesterinen
parent c6f523f8cd
commit 7c3d789514
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/display.cpp
View file

@ -350,7 +350,11 @@ void display::init_flags_for_side_internal(size_t n, const std::string& side_col
animated<image::locator>& f = flags_[n];
f = temp_anim;
assert(f.get_end_time() != 0);
if (f.get_end_time() <= 0) {
std::stringstream msg;
msg << "Invalid animation duration (<= 0) found when constructing flag for side " << n;
throw std::domain_error(msg.str());
}
f.start_animation(rand() % f.get_end_time(), true);
}