0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

GUI2/Addon Manager: make addon id more prominent, debug-only

Browse source 
It wasn't visible enough for people for whom it was useful, and too visible for people for whom it was not.
This commit is contained in:
Charles Dang 2024-05-26 18:17:05 -04:00
parent 279c7daa33
commit 78620c7d61
2 changed files with 26 additions and 33 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

50
data/gui/window/addon_manager.cfg
View file

@ -95,6 +95,24 @@
[/row]
[row]
grow_factor = 0
[column]
grow_factor = 1
border = "all"
border_size = 5
horizontal_grow = true
[label]
id = "addon_id"
definition = "default_small"
[/label]
[/column]
[/row]
[row]
grow_factor = 0
@ -507,38 +525,6 @@
[/row]
[row]
grow_factor = 1
[column]
grow_factor = 0
border = "all"
border_size = 5
horizontal_alignment = "left"
[label]
definition = "gold_small"
label = _ "Id:"
linked_group = "detail_labels"
[/label]
[/column]
[column]
grow_factor = 1
border = "all"
border_size = 5
horizontal_grow = true
[label]
id = "id"
definition = "default_small"
[/label]
[/column]
[/row]
[/grid]
[/column]

9
src/gui/dialogs/addon/manager.cpp
View file

@ -521,6 +521,10 @@ void addon_manager::pre_show(window& window)
connect_signal_notify_modified(version_filter,
std::bind(&addon_manager::on_selected_version_change, this));
if(!game_config::debug) {
find_widget<label>(&window, "addon_id", false).set_visible(widget::visibility::invisible);
}
on_addon_select();
window.set_enter_disabled(true);
@ -1104,7 +1108,10 @@ void addon_manager::on_addon_select()
const std::string& feedback_url = info->feedback_url;
find_widget<label>(parent, "url", false).set_label(!feedback_url.empty() ? feedback_url : _("url^None"));
find_widget<label>(parent, "id", false).set_label(info->id);
if(auto addon_id = find_widget<label>(parent, "addon_id", false, true)) {
addon_id->set_label(info->id);
}
bool installed = is_installed_addon_status(tracking_info_[info->id].state);
bool updatable = tracking_info_[info->id].state == ADDON_INSTALLED_UPGRADABLE;