0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix #4626 ai advacement aspects regression

Browse source 
the list returned by `ai_advancement.get_advancements` is a priority list, so we use the first valid entry instead of a random one.
This commit is contained in:
gfgtdf 2019-12-21 23:36:59 +01:00
parent d6a746ee77
commit 6f5ed34a50
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/actions/advancement.cpp
View file

@ -219,11 +219,13 @@ namespace
}
std::vector<std::string> allowed = ai_advancement.get_advancements(u);
if(!allowed.empty()){
std::string pick = allowed[randomness::generator->get_random_int(0, allowed.size() - 1)];
int res_new = get_advancement_index(*u, pick);
for(const auto& adv_id : allowed) {
int res_new = get_advancement_index(*u, adv_id);
if(res_new != -1) {
// if the advancement ids were really unique we could also make this function return the
// advancements id instead of its index. But i dont think there are guaraenteed to be unique.
res = res_new;
break;
}
}
}