0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

disable undoing unit creation.

Browse source 
Undoing unit recruits currently ends in oos in most cases, because the random generator is called during unit creation for creating random names.
This is not impossible to fix, ofc we could just enable it for nameless units, but i'm not 100% sure wether units with no names call the random generator for random names or not. Also names normaly don't have any influence on the game (same for genders maybe?), so there is no reason not to be able to undo it from a players point of view. We also cannot just store the random state in undo_stack->add_recruit, because the unit creation happens before that
This commit is contained in:
gfgtdf 2013-12-21 21:53:03 +01:00
parent 8a55cc355f
commit 65fded5de3
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/actions/create.cpp
View file

@ -949,8 +949,18 @@ void recruit_unit(const unit_type & u_type, int side_num, const map_location & l
if ( use_undo ) {
resources::undo_stack->add_recruit(new_unit, loc, from);
// Check for information uncovered or randomness used.
if ( mutated || u_type.genders().size() > 1 ||
new_unit.type().has_random_traits() ) {
// undoing unit recruits currently ends in oos in most cases
// because the random generator is called during unit creation for names.
// This is not impossible to fix, ofc we could just enable it for nameless units
// but i'm not 100% sure wether units with no names call the random generator for random names or not.
// also names normaly don't have any influence on the game (same for genders maybe?)
// so there is no reason not to be able to undo it from a players point of view.
// we also cannot store the random state in undo_stack->add_recruit, because the unit creation happens before that.
//if ( mutated || u_type.genders().size() > 1 ||
// new_unit.type().has_random_traits() ) {
if ( true ) {
resources::undo_stack->clear();
}
}