0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add extra comment, use end() for invalid iterator.

Browse source
This commit is contained in:
Mark de Wever 2008-11-10 18:30:36 +00:00
parent d8e00df06a
commit 62673399a8
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/image.hpp
View file

@ -42,10 +42,13 @@ namespace image {
#else
const int tile_size = 72;
#endif
// Iterators from this dummy list are needed to ensure that iterator member of cache_item
// is always non-singular iterator thus avoiding
// "Copy-contruct from singular iterator" error
// when libstdc++ debug mode is enabled.
/**
* Iterators from this dummy list are needed to ensure that iterator member
* of cache_item is always non-singular iterator thus avoiding
* "Copy-contruct from singular iterator" error when libstdc++ debug mode
* is enabled. Note copying a singular iterator is undefined behaviour by
* the C++ standard.
*/
extern std::list<int> dummy_list;
template<typename T>
@ -53,14 +56,14 @@ namespace image {
cache_item() :
loaded(false),
item() ,
position(dummy_list.begin())
position(dummy_list.end())
{
}
cache_item(T item) :
loaded(true),
item(item),
position(dummy_list.begin())
position(dummy_list.end())
{
}