move loyal overlays to the loyal trait

since the recent changes to overlays= in particular 1a7724e547,
e71033374c and b2cd1cf6c [unit]overlays= is no longer the
recommended way to add an overlay and the use of the
apply_to=overlay effect is reccomended instead, so adding it
to the [trait] is the most natural option here.

this in particular fixes #4058 . Also people simply forgetting the
IS_LOYAL macro was a not-so-uncommon cause of bugs.

In some cases people want to give the LOYAL trait without giving the
loyal overlays for those cases i added a optional OVERLAY parameter to
the {TRAIT_LOYAL} macro, also heroes should now use {TRAIT_LOYAL_HERO}
instead which uses the hero overlay. The IS_LOYAL and IS_HERO macros are
no longer needed in combination with those traits.
This commit is contained in:
gfgtdf 2019-05-20 17:51:32 +02:00
parent 26c2f941f2
commit 5cb93694c6
102 changed files with 122 additions and 414 deletions

View file

@ -52,9 +52,8 @@
side=1
x=19
y=23
{IS_HERO}
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
{TRAIT_INTELLIGENT}
[/modifications]
[/unit]

View file

@ -72,7 +72,7 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
facing=ne
[/unit]
[/side]

View file

@ -115,7 +115,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
facing=sw
[/unit]
@ -135,7 +134,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
facing=sw
[/unit]
@ -155,7 +153,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
facing=sw
[/unit]
@ -175,7 +172,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
facing=sw
[/unit]
@ -195,7 +191,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
facing=sw
[/unit]

View file

@ -221,7 +221,7 @@
[unit]
type=Mermaid Priestess
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
{TRAIT_RESILIENT}
[/modifications]
id=Cylanna
@ -230,7 +230,6 @@
side=1
x=21
y=9
{IS_HERO}
unrenamable=yes
[/unit]
@ -312,7 +311,6 @@
[/modifications]
facing=se
animate=yes
{IS_LOYAL}
profile=portraits/gwabbo.png
[/unit]

View file

@ -463,7 +463,6 @@ _f, _f, _f, _f, _f, _f, _f
side=1
x=$x1
y=$y1
{IS_LOYAL}
[/unit]
[if]
@ -590,7 +589,6 @@ _f, _f, _f, _f, _f, _f, _f
side=1
x=$x1
y=$y1
{IS_LOYAL}
[/unit]
[if]
@ -733,7 +731,6 @@ _f, _f, _f, _f, _f, _f, _f
side=1
x=$x1
y=$y1
{IS_LOYAL}
[/unit]
[if]

View file

@ -335,7 +335,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[message]
@ -627,7 +626,6 @@
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
[/unit]
[message]
@ -691,7 +689,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[if]

View file

@ -182,7 +182,7 @@
x={X}
y={Y}
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL OVERLAY=""}
{TRAIT_FEARLESS}
[/modifications]
moves=0

View file

@ -280,7 +280,6 @@
{TRAIT_LOYAL}
{TRAIT_HEALTHY}
[/modifications]
{IS_LOYAL}
animate=yes
[/unit]
[message]

View file

@ -383,10 +383,9 @@
name= _ "Caladon"
unrenamable=yes
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
{TRAIT_QUICK}
[/modifications]
{IS_HERO}
profile=portraits/caladon.png
[/unit]

View file

@ -451,7 +451,6 @@
{TRAIT_LOYAL}
{TRAIT_DEXTROUS}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
type=Thug
@ -464,7 +463,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
type=Thug
@ -477,7 +475,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
[/unit]
{CLEAR_VARIABLE Siddry_stored}

View file

@ -40,7 +40,7 @@
canrecruit=yes
type=Mermaid Diviner
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL OVERLAY=""}
{TRAIT_DEXTROUS}
[/modifications]
[ai]

View file

@ -406,7 +406,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
side=1
@ -419,7 +418,6 @@
{TRAIT_INTELLIGENT}
[/modifications]
experience=10
{IS_LOYAL}
[/unit]
[unit]
side=1
@ -432,7 +430,6 @@
{TRAIT_STRONG}
[/modifications]
experience=32
{IS_LOYAL}
[/unit]
[message]
speaker=Nebthun

View file

@ -613,7 +613,6 @@
name= _ "Theorin"
side=1
x,y=31,9
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
@ -684,7 +683,6 @@
name= _ "Stanis"
side=1
x,y=29,25
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
{TRAIT_STRONG}

View file

@ -87,9 +87,8 @@
type=General
profile="portraits/lionel.png"
unrenamable=yes
{IS_HERO}
[modifications]
{OBJECT_LOYAL}
{TRAIT_LOYAL_HERO_NOSLOT}
{TRAIT_FEARLESS}
{TRAIT_STRONG}
[/modifications]
@ -112,9 +111,8 @@
name= _ "Relgorn"
type=Dwarvish Fighter
unrenamable=yes # Shows up in HttT S14
{IS_HERO}
[modifications]
{OBJECT_LOYAL}
{TRAIT_LOYAL_HERO_NOSLOT}
{TRAIT_STRONG}
{TRAIT_HEALTHY}
[/modifications]

View file

@ -3540,7 +3540,6 @@ And the tongue of fire begets ashen repose.</i>"
[/effect]
[/object]
[/modifications]
{IS_LOYAL}
[/unit]
[delay]

View file

@ -38,7 +38,6 @@
profile=portraits/darken_volk.png
unrenamable=yes
random_traits=no
{IS_HERO}
[modifications]
# NOTE: if you change these, make sure you don't break the
# removal of the loyal trait in 'Alone at Last'
@ -49,6 +48,14 @@
[effect]
apply_to=loyal
[/effect]
[effect]
apply_to=ellipse
ellipse=misc/ellipse-hero
[/effect]
[effect]
apply_to=overlay
add=misc/hero-icon.png
[/effect]
[/trait]
{TRAIT_QUICK}
[object]

View file

@ -229,7 +229,6 @@
x,y=$prison_locations[$i].x,$prison_locations[$i].y
random_traits=no
facing=sw
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
{TEAM_COLOR_OVERRIDE () white}

View file

@ -434,10 +434,9 @@
type=$stored_Owaec.type
experience=$stored_Owaec.experience
profile=portraits/owaec.png
{IS_HERO}
random_traits=no
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
[/modifications]
[/unit]

View file

@ -372,7 +372,6 @@
side=1
canrecruit=no
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}

View file

@ -191,7 +191,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[message]
speaker=Dacyn

View file

@ -208,11 +208,10 @@
id=Konrad
name= _ "Konrad II"
profile=portraits/konrad_II.png
{IS_HERO}
type=General
random_traits=no
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
[/modifications]
side=1
x=21

View file

@ -13,12 +13,11 @@
type=White Mage
id=Dacyn
name= _ "Dacyn"
{IS_HERO}
profile=portraits/dacyn.png
random_traits=no
unrenamable=yes
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
{TEAM_COLOR_OVERRIDE () teal}
[/modifications]
#enddef

View file

@ -133,7 +133,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
type=Swordsman
@ -146,7 +145,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
{NEED_DELFADOR placement=leader}
@ -237,7 +235,6 @@
{TRAIT_LOYAL}
{TRAIT_STRONG}
[/modifications]
{IS_LOYAL}
[/unit]
[message]
speaker=Haldiel
@ -272,7 +269,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
type=Horseman
@ -286,7 +282,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
type=Horseman
@ -300,7 +295,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
type=Knight
@ -314,7 +308,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
type=Knight
@ -328,7 +321,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
type=Knight
@ -343,7 +335,6 @@
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
[/unit]
[message]
speaker=Kaylan
@ -389,7 +380,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
type=Horseman
@ -403,7 +393,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
type=Horseman
@ -417,7 +406,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
type=Knight
@ -431,7 +419,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
type=Knight
@ -445,7 +432,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
type=Knight
@ -460,7 +446,6 @@
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
[/unit]
[redraw]
[/redraw]
@ -493,7 +478,6 @@
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
[/unit]
[message]
speaker=Simyr

View file

@ -225,7 +225,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[message]
@ -277,7 +276,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
# The guy does not show up on the screen without some help

View file

@ -142,7 +142,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
#ifdef EASY
@ -159,7 +158,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
#ifdef HARD
@ -176,7 +174,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
{OBJ_TRIDENT_STORM 5 4 bop_stormtrident}
@ -323,7 +320,6 @@
{TRAIT_LOYAL}
{TRAIT_STRONG}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
side=1
@ -336,7 +332,6 @@
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
side=1
@ -349,7 +344,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
#ifdef EASY
@ -364,7 +358,6 @@
{TRAIT_LOYAL}
{TRAIT_STRONG}
[/modifications]
{IS_LOYAL}
[/unit]
#endif
[message]
@ -396,7 +389,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
#ifdef EASY
@ -411,7 +403,6 @@
{TRAIT_LOYAL}
{TRAIT_STRONG}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
side=1
@ -424,7 +415,6 @@
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
[/unit]
#else
[unit]
@ -438,7 +428,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
#endif
[message]
@ -470,7 +459,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
[/unit]
#ifdef EASY
@ -485,7 +473,6 @@
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
[/unit]
#endif
@ -518,7 +505,6 @@
{TRAIT_LOYAL}
{TRAIT_STRONG}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
side=1
@ -531,7 +517,6 @@
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
[/unit]
#ifdef EASY
@ -546,7 +531,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
#endif
[message]
@ -578,7 +562,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
side=1
@ -591,7 +574,6 @@
{TRAIT_LOYAL}
{TRAIT_STRONG}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
side=1
@ -604,7 +586,6 @@
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
[/unit]
#ifdef EASY
[unit]
@ -618,7 +599,6 @@
{TRAIT_LOYAL}
{TRAIT_STRONG}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
side=1
@ -631,7 +611,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
[/unit]
#else
[unit]
@ -645,7 +624,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
#endif

View file

@ -321,7 +321,6 @@
[/object]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
#set the variable to say the Moremirmu is alive
[set_variable]
@ -369,7 +368,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
{LOYAL_UNIT 2 (Walking Corpse) ({X}) ({Y})}

View file

@ -253,7 +253,6 @@
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -268,7 +267,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
id=Gamlel
@ -282,7 +280,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[redraw]
@ -411,7 +408,6 @@
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -426,7 +422,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
id=Gamlel
@ -440,7 +435,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
id=Darglen
@ -453,7 +447,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
#dialog
[message]
@ -529,7 +522,6 @@
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -544,7 +536,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -559,7 +550,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
#create terrain
[terrain]

View file

@ -334,7 +334,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[object]

View file

@ -277,7 +277,6 @@
[/object]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
{LOYAL_UNIT 1 (White Mage) 20 48}

View file

@ -172,7 +172,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
#enddef

View file

@ -123,7 +123,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
generate_name=yes
@ -135,7 +134,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
generate_name=yes
@ -147,7 +145,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
generate_name=yes
@ -159,7 +156,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
generate_name=yes
@ -171,7 +167,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
generate_name=yes
@ -183,7 +178,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
generate_name=yes
@ -195,7 +189,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
id=rider
@ -208,7 +201,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
generate_name=yes
@ -220,7 +212,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
generate_name=yes
@ -232,7 +223,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
{FLAG_VARIANT knalgan}
[/side]

View file

@ -193,7 +193,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[teleport]
[filter]
@ -436,7 +435,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
#ifdef EASY
@ -454,7 +452,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[/event]

View file

@ -181,7 +181,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[redraw]
[/redraw]
@ -203,7 +202,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[redraw]
[/redraw]
@ -402,9 +400,8 @@
[/filter]
side=1
canrecruit=no
{IS_HERO}
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
[/modifications]
[/modify_unit]
[/event]

View file

@ -226,7 +226,6 @@
{TRAIT_LOYAL}
{TRAIT_FEARLESS}
[/modifications]
{IS_LOYAL}
[status]
poisoned=yes
[/status]
@ -815,7 +814,6 @@ Soooo... It is you who sent your subordinates to attack us. Now when weve des
{TRAIT_LOYAL}
{TRAIT_FEARLESS}
[/modifications]
{IS_LOYAL}
[status]
poisoned=yes
[/status]

View file

@ -412,7 +412,6 @@
{TRAIT_LOYAL}
{TRAIT_DEXTROUS}
[/modifications]
{IS_LOYAL}
[/unit]
[redraw]

View file

@ -690,9 +690,8 @@ fire: +10%"
unrenamable=yes
type=Elder Mage
{PLACEMENT}
{IS_HERO}
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
{TRAIT_INTELLIGENT}
[/modifications]
[/unit]
@ -706,10 +705,9 @@ fire: +10%"
unrenamable=yes
type=Elvish Lord
{PLACEMENT}
{IS_HERO}
random_traits=no
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
[/modifications]
[/unit]
#enddef
@ -722,10 +720,9 @@ fire: +10%"
unrenamable=yes
type=Princess
{PLACEMENT}
{IS_HERO}
random_traits=no
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
[/modifications]
[/unit]
#enddef

View file

@ -135,7 +135,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
facing=nw
id=guard2
x=24
@ -169,7 +168,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
)}

View file

@ -36,7 +36,7 @@
[modifications]
{TRAIT_QUICK}
{TRAIT_RESILIENT}
{TRAIT_LOYAL}
{TRAIT_LOYAL OVERLAY=""}
[/modifications]
#enddef
@ -58,7 +58,6 @@
{TRAIT_RESILIENT}
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
#enddef
#define SCOUT
@ -71,7 +70,6 @@
{TRAIT_RESILIENT}
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
#enddef
#define LANDAR
@ -90,7 +88,7 @@
[modifications]
{TRAIT_DEXTROUS}
{TRAIT_RESILIENT}
{TRAIT_LOYAL}
{TRAIT_LOYAL OVERLAY=""}
[/modifications]
#enddef
@ -126,7 +124,7 @@
[modifications]
{TRAIT_QUICK}
{TRAIT_RESILIENT}
{TRAIT_LOYAL}
{TRAIT_LOYAL OVERLAY=""}
[/modifications]
#enddef
@ -140,7 +138,6 @@
{TRAIT_INTELLIGENT}
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
#enddef
#define TAMERIL_ISIMERIL
@ -153,7 +150,6 @@
{TRAIT_RESILIENT}
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
#enddef
#define OLURF
@ -202,7 +198,6 @@
{TRAIT_RESILIENT}
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -218,7 +213,6 @@
{TRAIT_RESILIENT}
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -262,7 +256,6 @@
{TRAIT_HEALTHY}
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -345,7 +338,6 @@
{TRAIT_DEXTROUS}
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
#enddef
#define ARKILDUR
@ -358,7 +350,6 @@
{TRAIT_STRONG}
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
#enddef
#TODO bring the macro to use.

View file

@ -238,9 +238,8 @@
#textdomain wesnoth-l
[/effect]
[/object]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
[/modifications]
{IS_HERO}
unrenamable=yes
[/unit]

View file

@ -110,7 +110,6 @@
id=Zlex
name= _ "Zlex"
x,y=6,24
{IS_LOYAL}
role=Supporter
[modifications]
{TRAIT_LOYAL}

View file

@ -42,10 +42,9 @@
name= _ "Hamel"
profile=portraits/Hamel.png
# This nice macro gives the unit silver crown.
{IS_HERO}
x,y=6,23
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
{TRAIT_STRONG}
[/modifications]
[/unit]

View file

@ -1565,7 +1565,6 @@
name= _ "Dulcatas"
side=1
x,y=4,8
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
{TRAIT_HEALTHY}
@ -1578,7 +1577,6 @@
name= _ "Antolos"
side=1
x,y=7,10
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
{TRAIT_STRONG}
@ -1591,7 +1589,6 @@
name= _ "Varem"
side=1
x,y=6,13
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
@ -2054,7 +2051,6 @@
id=Abhai
name= _ "Abhai"
# profile=Abhai.png
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}

View file

@ -69,7 +69,7 @@
name= _ "Galim"
x,y=12,11
facing=se
{IS_LOYAL}
# todo: is the unit loyal or not? before it had the {IS_LOYAL} but without the real loyal trait.
[/unit]
[/side]

View file

@ -965,6 +965,7 @@
[foreach]
array=new_companions
[do]
## TODO: does this still work after the overlays= change?
{VARIABLE this_item.side 1}
{VARIABLE this_item.canrecruit no}
# We'll be unstoring these units onto the recall list, which won't heal them automatically, so we do it here.
@ -998,7 +999,7 @@
name=this_item.modifications
mode=replace
[literal]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
{TRAIT_UNDEAD}
[/literal]
[/set_variables]

View file

@ -234,7 +234,6 @@
{TRAIT_LOYAL}
{TRAIT_HEALTHY}
[/modifications]
{IS_LOYAL}
[/unit]
[/else]
[/if]
@ -258,9 +257,8 @@
x,y=15,2
side=1
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
[/modifications]
{IS_HERO}
[/unit]
[/else]
[/if]
@ -284,9 +282,8 @@
x,y=15,2
side=1
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
[/modifications]
{IS_HERO}
[/unit]
[/else]
[/if]
@ -385,7 +382,6 @@
{TRAIT_LOYAL}
{TRAIT_DEXTROUS}
[/modifications]
{IS_LOYAL}
[/unit]
[message]

View file

@ -270,7 +270,6 @@
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
id=Abhai
name= _ "Abhai"
#profile=Abhai.png

View file

@ -597,7 +597,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[move_unit_fake]
@ -617,7 +616,6 @@
{TRAIT_LOYAL}
{TRAIT_STRONG}
[/modifications]
{IS_LOYAL}
[/unit]
[message]

View file

@ -592,7 +592,6 @@
[/filter]
canrecruit=no
{TRAIT_LOYAL}
{IS_LOYAL}
[/modify_unit]
[message]

View file

@ -25,7 +25,6 @@
id=Camerin
name= _ "Camerin"
profile=portraits/Camerin.png
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
{TRAIT_STRONG}
@ -37,7 +36,6 @@
id=Father Morvin
name= _ "Father Morvin"
profile=portraits/Father_Morvin.png
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
@ -50,7 +48,6 @@
id=Sister Thera
name= _ "Sister Thera"
profile=portraits/Sister_Thera.png
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
{TRAIT_QUICK}
@ -62,7 +59,6 @@
id=Elenia
name= _ "Elenia"
profile=portraits/Elenia.png
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
{TRAIT_HEALTHY}
@ -73,7 +69,6 @@
type=Drake Burner
id=Krash
name= _ "Krash"
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
{TRAIT_RESILIENT}

View file

@ -328,32 +328,36 @@
type=Caravan
side=1
facing=ne
upkeep=free
{IS_HERO}
[modifications]
{TRAIT_LOYAL_HERO_NOSLOT}
[/modifications]
[/unit]
[unit]
x,y=6,29
type=Caravan
side=1
facing=ne
upkeep=free
{IS_HERO}
[modifications]
{TRAIT_LOYAL_HERO_NOSLOT}
[/modifications]
[/unit]
[unit]
x,y=6,28
type=Caravan
side=1
facing=ne
upkeep=free
{IS_HERO}
[modifications]
{TRAIT_LOYAL_HERO_NOSLOT}
[/modifications]
[/unit]
[unit]
x,y=7,28
type=Caravan
side=1
facing=ne
upkeep=free
{IS_HERO}
[modifications]
{TRAIT_LOYAL_HERO_NOSLOT}
[/modifications]
[/unit]
#ifdef HARD
[unit]
@ -361,8 +365,9 @@
type=Caravan
side=1
facing=ne
upkeep=free
{IS_HERO}
[modifications]
{TRAIT_LOYAL_HERO_NOSLOT}
[/modifications]
[/unit]
#endif
[unit]
@ -373,10 +378,9 @@
name= _ "Alanin"
unrenamable=yes
facing=ne
{IS_HERO}
profile=portraits/alanin.png
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
{TRAIT_RESILIENT}
[/modifications]
[/unit]

View file

@ -275,11 +275,10 @@
id=Baglur
name= _ "Baglur"
unrenamable=yes
{IS_HERO}
profile=portraits/baglur.png
facing=sw
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
{TRAIT_RESILIENT}
[/modifications]
[/unit]

View file

@ -66,7 +66,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
x,y=13,11
@ -79,7 +78,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
x,y=9,13
@ -91,7 +89,6 @@
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
x,y=11,14
@ -103,7 +100,6 @@
{TRAIT_LOYAL}
{TRAIT_STRONG}
[/modifications]
{IS_LOYAL}
[/unit]
[/event]

View file

@ -333,11 +333,10 @@
id=Krawg
name= _ "Krawg"
unrenamable=yes
{IS_HERO}
x,y=5,24
side=1
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
{TRAIT_INTELLIGENT}
[/modifications]
[/unit]
@ -500,12 +499,11 @@
id=Thursagan
name= _ "Thursagan"
unrenamable=yes
{IS_HERO}
profile=portraits/thursagan.png
advances_to=Dwarvish Arcanister
max_experience=210
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
{TRAIT_STRONG}
[/modifications]
[/unit]

View file

@ -61,7 +61,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
x,y=13,12
@ -73,7 +72,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
x,y=9,13
@ -85,7 +83,6 @@
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
x,y=11,14
@ -97,7 +94,6 @@
{TRAIT_LOYAL}
{TRAIT_STRONG}
[/modifications]
{IS_LOYAL}
[/unit]
[/event]
@ -228,7 +224,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
type=Dwarvish Runesmith
@ -240,7 +235,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[message]
speaker=narrator

View file

@ -61,7 +61,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
x,y=10,9
@ -73,7 +72,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
x,y=8,10
@ -85,7 +83,6 @@
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
x,y=10,12
@ -97,7 +94,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
[/unit]
[/event]

View file

@ -199,11 +199,10 @@
name= _ "Durstorn"
unrenamable=yes
side=1
{IS_HERO}
profile=portraits/durstorn-insane.png
random_traits=no
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
[/modifications]
[/unit]
[unit]
@ -216,7 +215,6 @@
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
x,y=11,1
@ -228,7 +226,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
[/unit]
#alanin, baglur, krawg and thursagan
[recall]

View file

@ -367,7 +367,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[message]
speaker=Rolin # wmllint: ignore
@ -393,7 +392,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
{RANDOM "Spearman,Bowman"}
@ -407,7 +405,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
{CLEAR_VARIABLE random}
@ -558,7 +555,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[message]
speaker=Hadlin # wmllint: ignore

View file

@ -53,7 +53,6 @@
type=Bone Captain
id=Bone Captain
name= _ "Rudic"
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
[/modifications]
@ -63,7 +62,6 @@
type=SotA Ruffian
id=Carcyn
name= _ "Carcyn"
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
{TRAIT_STRONG}
@ -75,7 +73,6 @@
id=Shynal
name= _ "Shynal"
gender=female
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
@ -124,7 +121,6 @@
type=Saurian Soothsayer
id=Vendraxis
name= _ "Vendraxis"
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
{TRAIT_RESILIENT}

View file

@ -261,9 +261,8 @@
profile=portraits/gruu.png
facing=sw
random_traits=no
{IS_HERO}
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
[object]
[effect]
apply_to=image_mod

View file

@ -472,7 +472,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[allow_recruit]
@ -622,7 +621,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[allow_recruit]

View file

@ -11,9 +11,8 @@
x={X}
y={Y}
random_traits=no
{IS_HERO}
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
[/modifications]
[/unit]
#enddef
@ -29,9 +28,8 @@
x={X}
y={Y}
random_traits=no
{IS_HERO}
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
[/modifications]
[/unit]
#enddef
@ -47,9 +45,8 @@
x={X}
y={Y}
random_traits=no
{IS_HERO}
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
[/modifications]
[/unit]
#enddef

View file

@ -53,7 +53,6 @@
id=Pelmathidrol
name= _ "Pelmathidrol"
x,y=1,15
{IS_LOYAL}
facing=se
[modifications]
{TRAIT_LOYAL}
@ -144,7 +143,6 @@
x,y=45,29
id=Movrur
name= _ "Movrur"
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
[/modifications]

View file

@ -40,7 +40,7 @@
x={X}
y={Y}
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL OVERLAY=""}
[/modifications]
ai_special=guardian
random_traits=yes

View file

@ -19,9 +19,8 @@
name= _ "Angarthing"
profile=portraits/angarthing.png
unrenamable=yes
{IS_HERO}
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
{TRAIT_QUICK}
[/modifications]
#enddef
@ -32,9 +31,8 @@
profile=portraits/ratheln.png
name= _ "Ratheln"
unrenamable=yes
{IS_HERO}
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
{TRAIT_STRONG}
[/modifications]
#enddef
@ -58,9 +56,8 @@
name= _ "Dulcatulos"
profile=portraits/dulcatulos.png
unrenamable=yes
{IS_HERO}
upkeep=free
[modifications]
{TRAIT_LOYAL_HERO_NOSLOT}
{TRAIT_QUICK}
{TRAIT_HEALTHY}
[/modifications]

View file

@ -128,7 +128,6 @@
{TRAIT_LOYAL}
{SECOND_TRAIT_WML}
[/modifications]
{IS_LOYAL}
[/unit]
#enddef
@ -332,7 +331,7 @@
random_traits=no
profile=portraits/lady_outlaw.png
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
[/modifications]
[/unit]

View file

@ -171,7 +171,6 @@
{TRAIT_LOYAL}
{TRAIT_STRONG}
[/modifications]
{IS_LOYAL}
[/unit]
[message]

View file

@ -367,7 +367,6 @@
{TRAIT_LOYAL}
{TRAIT_STRONG}
[/modifications]
{IS_LOYAL}
[/unit]
[message]
speaker=Minister Edren
@ -541,7 +540,6 @@ Enter at Your Own Risk!"
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[redraw]

View file

@ -362,7 +362,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[redraw]

View file

@ -274,7 +274,7 @@
random_traits=no
profile=portraits/jessica.png
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
[/modifications]
[/unit]

View file

@ -963,7 +963,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[message]
@ -1102,7 +1101,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[message]
@ -1223,7 +1221,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[scroll_to_unit]

View file

@ -18,11 +18,10 @@
side={SIDE}
x={X}
y={Y}
{IS_HERO}
unrenamable=yes
random_traits=no
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
[/modifications]
[/unit]
#enddef
@ -41,7 +40,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
#enddef
@ -58,7 +56,6 @@
{TRAIT_UNDEAD}
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
#enddef
@ -75,7 +72,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
#enddef
@ -95,6 +91,5 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
#enddef

View file

@ -191,7 +191,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[message]
@ -257,10 +256,9 @@
name= _ "Sir Gerrick"
unrenamable=yes
profile=portraits/sir-gerrick.png
{IS_HERO}
x,y=10,9
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
{TRAIT_RESILIENT}
[/modifications]
[/unit]
@ -425,7 +423,6 @@
{TRAIT_INTELLIGENT}
[/modifications]
x,y=5,11
{IS_LOYAL}
[/unit]
[unit]
side=1
@ -445,7 +442,6 @@
{TRAIT_QUICK}
[/modifications]
x,y=5,10
{IS_LOYAL}
[/unit]
[message]
@ -549,7 +545,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
[/unit]
[message]
@ -586,7 +581,6 @@
{TRAIT_LOYAL}
{TRAIT_STRONG}
[/modifications]
{IS_LOYAL}
[/unit]
[message]
@ -799,10 +793,9 @@
name= _ "Sir Gerrick"
unrenamable=yes
profile=portraits/sir-gerrick.png
{IS_HERO}
x,y=10,9
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
{TRAIT_RESILIENT}
[/modifications]
[/unit]

View file

@ -317,11 +317,10 @@
profile=portraits/hylas.png
name= _ "Minister Hylas"
unrenamable=yes
{IS_HERO}
side=1
x,y=21,14
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
{TRAIT_INTELLIGENT}
[/modifications]
[/unit]
@ -480,7 +479,6 @@
{TRAIT_STRONG}
[/modifications]
x,y=14,21
{IS_LOYAL}
[/unit]
[message]
@ -515,7 +513,6 @@
{TRAIT_INTELLIGENT}
[/modifications]
x,y=14,21
{IS_LOYAL}
[/unit]
[unit]
side=1
@ -535,7 +532,6 @@
{TRAIT_QUICK}
[/modifications]
x,y=15,21
{IS_LOYAL}
[/unit]
[message]

View file

@ -162,11 +162,10 @@
name= _ "Ethiliel"
unrenamable=yes
profile=portraits/ethiliel.png
{IS_HERO}
x,y=recall,recall
random_traits=no
[modifications]
# Loyal trait is given later
{TRAIT_LOYAL_HERO_NOSLOT}
{TRAIT_QUICK}
[/modifications]
[/unit]
@ -299,7 +298,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
[/unit]
[message]
@ -545,18 +543,18 @@
{VARIABLE EthilielV.x recall}
{VARIABLE EthilielV.y recall}
{CLEAR_VARIABLE EthilielV.modifications}
[set_variables]
name=EthilielV.modifications
mode=insert
[value]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
{TRAIT_QUICK}
[/value]
[/set_variables]
{CLEAR_VARIABLE EthilielV.upkeep}
{CLEAR_VARIABLE EthilielV.upkeep}
[unstore_unit]
variable=EthilielV
[/unstore_unit]

View file

@ -486,7 +486,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
to_variable=ranger
[/unit]
[if]

View file

@ -798,9 +798,8 @@
moves=$this_unit.max_moves
profile=portraits/urza-afalas.png
canrecruit=no
{IS_HERO}
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
[/modifications]
[/modify_unit]

View file

@ -473,11 +473,10 @@ _f, _f, Re, _f
name= _ "Urza Afalas"
unrenamable=yes
profile=portraits/urza-afalas.png
{IS_HERO}
x,y=recall,recall
random_traits=no
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
[/modifications]
[/unit]
[/then]

View file

@ -666,7 +666,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
)}
{UNIT 1 (White Mage) 9 2 (
generate_name=yes
@ -675,7 +674,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
)}
[/event]

View file

@ -542,7 +542,6 @@ Besides... I want my brother back."
{TRAIT_LOYAL}
{TRAIT_STRONG}
[/modifications]
{IS_LOYAL}
)}
[message]

View file

@ -130,10 +130,9 @@
type=Red Mage
profile=portraits/baran.png
side=1
{IS_HERO}
{PLACEMENT}
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
{TRAIT_INTELLIGENT}
[/modifications]
[/unit]

View file

@ -1004,7 +1004,6 @@
gender=$elf_pool[$random_elf_pool_index].gender
random_traits=yes
#ifdef EASY
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
[/modifications]
@ -1410,7 +1409,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
#endif
[/unit]
[/do]

View file

@ -745,7 +745,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
x=$x1
y=$y1
[/unit]
@ -1036,7 +1035,6 @@
[/effect]
[/object]
[/modifications]
{IS_LOYAL}
x="$($x1 - 2)"
y="$($y1 - 4)"
side=1

View file

@ -452,7 +452,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[/then]
[/if]
@ -1830,7 +1829,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
role=ally
[/unit]
@ -1846,7 +1844,6 @@
{TRAIT_LOYAL}
{TRAIT_STRONG}
[/modifications]
{IS_LOYAL}
role=ally
[/unit]
@ -1862,7 +1859,6 @@
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
role=ally
[/unit]
@ -1879,7 +1875,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
role=ally
[/unit]
#endif
@ -1896,7 +1891,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
role=ally
[/unit]
@ -1945,7 +1939,6 @@
{TRAIT_LOYAL}
{TRAIT_STRONG}
[/modifications]
{IS_LOYAL}
role=ally
placement=map
passable=yes
@ -1963,7 +1956,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
role=ally
placement=map
passable=yes
@ -1981,7 +1973,6 @@
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
role=ally
placement=map
passable=yes
@ -1999,7 +1990,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
role=ally
placement=map
passable=yes
@ -2019,7 +2009,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
role=ally
placement=map
passable=yes

View file

@ -303,7 +303,6 @@ _ "These undead trolls fight again in death as they did in life, except this tim
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -318,7 +317,6 @@ _ "These undead trolls fight again in death as they did in life, except this tim
{TRAIT_LOYAL}
{TRAIT_STRONG}
[/modifications]
{IS_LOYAL}
[/unit]
#ifdef HARD
@ -361,7 +359,6 @@ _ "These undead trolls fight again in death as they did in life, except this tim
[/effect]
[/object]
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -387,7 +384,6 @@ _ "These undead trolls fight again in death as they did in life, except this tim
[/effect]
[/object]
[/modifications]
{IS_LOYAL}
[/unit]
# reveal a bit of the escape passage to the player
@ -719,7 +715,6 @@ _ "These undead trolls fight again in death as they did in life, except this tim
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
[/unit]
[remove_shroud]
@ -1273,7 +1268,6 @@ _ "These undead trolls fight again in death as they did in life, except this tim
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
[/unit]
[kill]
@ -1308,7 +1302,6 @@ _ "These undead trolls fight again in death as they did in life, except this tim
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
#endif
@ -1395,7 +1388,6 @@ _ "These undead trolls fight again in death as they did in life, except this tim
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[message]

View file

@ -753,7 +753,6 @@
{TRAIT_LOYAL}
{TRAIT_STRONG}
[/modifications]
{IS_LOYAL}
[/unit]
[message]

View file

@ -188,7 +188,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -203,7 +202,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -218,7 +216,6 @@
{TRAIT_LOYAL}
{TRAIT_STRONG}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -233,7 +230,6 @@
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -248,7 +244,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -263,7 +258,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -278,7 +272,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -293,7 +286,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -308,7 +300,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -323,7 +314,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[/event]

View file

@ -167,7 +167,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
[/unit]
[/else]
[/if]
@ -187,7 +186,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -202,7 +200,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -218,7 +215,6 @@
{TRAIT_LOYAL}
{TRAIT_STRONG}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -233,7 +229,6 @@
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -248,7 +243,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -263,7 +257,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -278,7 +271,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -293,7 +285,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -308,7 +299,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -323,7 +313,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[/event]

View file

@ -4456,7 +4456,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[delay]

View file

@ -818,7 +818,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
[/unit]
[if]
[variable]
@ -872,7 +871,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[if]
[variable]
@ -927,7 +925,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[if]
[variable]
@ -977,7 +974,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
[/unit]
[if]
[variable]
@ -1052,7 +1048,6 @@
{TRAIT_LOYAL}
{TRAIT_INTELLIGENT}
[/modifications]
{IS_LOYAL}
[/unit]
[message]
speaker=We-jial
@ -2394,7 +2389,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
[/unit]
[message]
speaker=Hekuba

View file

@ -315,7 +315,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
[/unit]
# recall heroes
@ -467,7 +466,6 @@
[modifications]
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
[unit]
@ -478,7 +476,6 @@
{TRAIT_LOYAL}
{TRAIT_RESILIENT}
[/modifications]
{IS_LOYAL}
ai_special=guardian
[/unit]
[/event]
@ -1198,7 +1195,6 @@
{TRAIT_LOYAL}
{TRAIT_QUICK}
[/modifications]
{IS_LOYAL}
[/unit]
[message]

View file

@ -19,10 +19,9 @@
profile=portraits/nym.png
upkeep=loyal
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
{TRAIT_DEXTROUS}
[/modifications]
{IS_HERO}
#enddef
#define GARAK
@ -32,7 +31,7 @@
profile=portraits/garak.png
unrenamable=yes
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
{TRAIT_STRONG}
[object]
[effect]
@ -47,7 +46,6 @@
[/effect]
[/object]
[/modifications]
{IS_HERO}
#enddef
#define ZHUL
@ -57,7 +55,7 @@
profile=portraits/zhul.png
unrenamable=yes
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
{TRAIT_INTELLIGENT}
[object]
[effect]
@ -69,5 +67,4 @@
[/effect]
[/object]
[/modifications]
{IS_HERO}
#enddef

View file

@ -82,9 +82,8 @@
[/leader]
[unit]
type=Sky Drake
{IS_HERO}
[modifications]
{OBJECT_LOYAL}
{TRAIT_LOYAL_HERO_NOSLOT}
{TRAIT_STRONG}
{TRAIT_RESILIENT}
[/modifications]

View file

@ -87,7 +87,6 @@
[unit]
type=Giant Scorpion
ai_special=guardian
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
[/modifications]
@ -97,7 +96,6 @@
[unit]
type=Giant Scorpion
ai_special=guardian
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
[/modifications]

View file

@ -81,7 +81,6 @@
[unit]
type=Dwarvish Dragonguard
ai_special=guardian
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
[/modifications]
@ -91,7 +90,6 @@
[unit]
type=Dwarvish Dragonguard
ai_special=guardian
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
[/modifications]

View file

@ -70,16 +70,17 @@
[/leader]
[unit]
{GRIBBEL}
{IS_HERO}
experience=35 # Intended to cover what he could have earned in previous appearance plus some.
moves=0
x,y=2,35
facing=ne
[+modifications]
{TRAIT_LOYAL_HERO}
[/modifications]
[/unit]
[unit]
type=Drake Warden
ai_special=guardian
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
{TRAIT_QUICK}
@ -90,7 +91,6 @@
[unit]
type=Drake Enforcer
ai_special=guardian
{IS_LOYAL}
[modifications]
{TRAIT_LOYAL}
{TRAIT_QUICK}

View file

@ -52,9 +52,8 @@
name= _ "Vank"
unrenamable=yes
type=Drake Glider
{IS_HERO}
[modifications]
{OBJECT_LOYAL}
{TRAIT_LOYAL_HERO_NOSLOT}
{TRAIT_QUICK}
{TRAIT_RESILIENT}
[/modifications]
@ -75,7 +74,6 @@
name= _ "Gribbel"
type=Drake Flameheart
[modifications]
{OBJECT_LOYAL}
{TRAIT_STRONG}
{TRAIT_RESILIENT}
[/modifications]
@ -96,9 +94,8 @@
id=Krenix
name= _ "Krenix"
type=Saurian Soothsayer
{IS_HERO}
[modifications]
{TRAIT_LOYAL}
{TRAIT_LOYAL_HERO}
{TRAIT_RESILIENT}
[/modifications]
#enddef

View file

@ -77,8 +77,8 @@
x,y=13,5
random_traits=no
facing=nw
{IS_HERO}
[modifications]
{TRAIT_LOYAL_HERO_NOSLOT}
{TRAIT_INTELLIGENT}
[object]
[effect]
@ -521,7 +521,7 @@
message= _"To attack the quintain, first select the attacker (Lisar), then the target (the quintain). You will see an attack description. Click <b>Attack</b> when youre ready."
[/message]
)}
[disallow_end_turn]
reason=_"You cannot end your turn until you have attacked the dummy!"
[/disallow_end_turn]

View file

@ -164,7 +164,6 @@ _"No gold carried over to the next scenario."#enddef
{TRAIT_UNDEAD}
{TRAIT_LOYAL}
[/modifications]
{IS_LOYAL}
[/unit]
#enddef

View file

@ -15,6 +15,8 @@
color="255,255,255"
#enddef
## TODO: this was moved to the loyal trait but a few codes used with witouht the loyal trait,
## so i'll leave it for now. since this icon is afaik not transparent though should not be a problem.
#define IS_HERO
# Embed this into a unit declaration to add a hero icon to the unit.
overlays="misc/hero-icon.png"

View file

@ -2,6 +2,10 @@
# Traits for the [modifications] clause of SingleWML descriptions
#define TRAIT_LOYAL
#arg OVERLAY
"misc/loyal-icon.png"
#endarg
# Units with trait Loyal have no upkeep.
[trait]
id=loyal
@ -14,6 +18,32 @@ During campaigns, certain units may opt to join the players forces of their o
[effect]
apply_to=loyal
[/effect]
[effect]
apply_to=overlay
add={OVERLAY}
[/effect]
[/trait]
#enddef
#define TRAIT_LOYAL_HERO
{TRAIT_LOYAL OVERLAY="misc/hero-icon.png"}
[+trait]
[effect]
apply_to=ellipse
ellipse=misc/ellipse-hero
[/effect]
[/trait]
#enddef
#define TRAIT_LOYAL_HERO_NOSLOT
# loyal hero unit where for some reason we don't
# want the loyal to appear in the traits list, i
# really think its be better if stayed consitent and decided for
# one way and removed either this or TRAIT_LOYAL_HERO
{TRAIT_LOYAL_HERO}
[+trait]
male_name=""
female_name=""
[/trait]
#enddef

Some files were not shown because too many files have changed in this diff Show more