0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Addon Manager: don't reload addon list after Update All if nothing changed

Browse source 
Can happen, for example, if the op was canceled. This also properly flags need_wml_cache_refresh_
on a per-addon basis when updating.
This commit is contained in:
Charles Dang 2017-10-27 14:54:51 +11:00
parent ea0f4ab6dd
commit 5ac959e783
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/gui/dialogs/addon/manager.cpp
View file

@ -648,13 +648,16 @@ void addon_manager::update_all_addons(window& window)
{
for(const auto& a : addons_) {
if(tracking_info_[a.first].state == ADDON_INSTALLED_UPGRADABLE) {
// TODO: handle result of this
client_.install_addon_with_checks(addons_, a.second);
addons_client::install_result result = client_.install_addon_with_checks(addons_, a.second);
// Take note if any wml_changes occurred
need_wml_cache_refresh_ |= result.wml_changed;
}
}
need_wml_cache_refresh_ = true;
load_addon_list(window);
if(need_wml_cache_refresh_) {
load_addon_list(window);
}
}
/** Performs all backend and UI actions for publishing the specified add-on. */