0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Optimize the lobby speed.

Browse source 
Try to resize the content of the listboxes with their current content,
only if that fails invalidate the entire window layout.

Since the playerlist consists of three fixed size listboxes the
invalidation still occurs rather often. Especially when a game is
selected the resize happens often since most of the time the number of
people slotted in different listboxes are different, causing a resize.

Unfortunately that's hard to fix in the current setup, the fix would
be to add a proper treeview widget. Then all players are in one widget
and moving an item in one widget should be easier to handle without a
window invalidation.
This commit is contained in:
Mark de Wever 2010-01-17 11:08:05 +00:00
parent 711eb2d48e
commit 56a124a2a7
1 changed files with 30 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

49
src/gui/dialogs/lobby_main.cpp
View file

@ -782,14 +782,6 @@ void tlobby_main::update_playerlist()
player_list_.other_rooms.auto_hide();
player_list_.other_games.auto_hide();
/**
* @todo See whether this invalidate can be removed.
*
* It should be possible but once done the clicking on the sort oder of the
* players in an empty lobby seems to crash with a not sized userpanel
* size {-1, -1, 0, 0}.
*/
window_->invalidate_layout();
player_list_dirty_ = false;
}
@ -1205,18 +1197,37 @@ void tlobby_main::process_gamelist(const config &data)
void tlobby_main::process_gamelist_diff(const config &data)
{
if (lobby_info_.process_gamelist_diff(data)) {
update_gamelist_diff();
lobby_info_.sync_games_display_status();
}
int joined = data.child_count("insert_child");
int left = data.child_count("remove_child");
if (joined > 0 || left > 0) {
if (left > joined) {
do_notify(NOTIFY_LOBBY_QUIT);
} else {
do_notify(NOTIFY_LOBBY_JOIN);
{
assert(window_);
twindow::tinvalidate_layout_blocker blocker(*window_);
if (lobby_info_.process_gamelist_diff(data)) {
update_gamelist_diff();
lobby_info_.sync_games_display_status();
}
int joined = data.child_count("insert_child");
int left = data.child_count("remove_child");
if (joined > 0 || left > 0) {
if (left > joined) {
do_notify(NOTIFY_LOBBY_QUIT);
} else {
do_notify(NOTIFY_LOBBY_JOIN);
}
}
}
/*
* As long as the layout is valid update all listboxes; if
* update_content_size() returns false the layout is invalidated. If
* invalidated the trying to size the other listboxes is a waste of
* effort, since they will be requested for a layout phase anyway.
*/
if(!window_->get_need_layout()) {
player_list_.active_game.list->update_content_size()
&& player_list_.active_room.list->update_content_size()
&& player_list_.other_rooms.list->update_content_size()
&& player_list_.other_games.list->update_content_size()
&& gamelistbox_->update_content_size();
}
}