0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Help: disable Unknown Topic popup (fixes #2587)

Browse source 
It's just a workaround and doesn't address the underlying issue, yes, but given
that we intend to refactor the help browser in 1.15, it's not worth the time and
effort to solve the event context layering issue, at least not for this.

The underlying issue might need fixing anyway, but I'll leave that for another time.
This commit is contained in:
Charles Dang 2018-03-05 12:56:26 +11:00
parent abf93216ac
commit 5517063fb9
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/help/help_browser.cpp
View file

@ -148,9 +148,18 @@ void help_browser::handle_event(const SDL_Event &event)
if (!ref.empty()) {
const topic *t = find_topic(toplevel_, ref);
if (t == nullptr) {
//
// HACK: there are difficult-to-solve issues with a GUI2 popup over the
// GUI1 help browser (see issue #2587). Simply disabling it for now.
// Should be reenabled once the help browser switches to GUI2.
//
// -- vultraz, 2018-03-05
//
#if 0
std::stringstream msg;
msg << _("Reference to unknown topic: ") << "'" << ref << "'.";
gui2::show_transient_message("", msg.str());
#endif
update_cursor();
}
else {