0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

wb: silence "Unable to build future map" warning

Browse source
This commit is contained in:
gfgtdf 2018-05-05 15:58:37 +02:00 • committed by Charles Dang
parent 5a3eec5398
commit 51189881dc
1 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/whiteboard/manager.cpp
View file

@ -272,7 +272,17 @@ bool manager::allow_leader_to_move(const unit& leader) const
//Look for another leader on another keep in the same castle
{ wb::future_map future; // start planned unit map scope
if(!has_planned_unit_map()) {
// TODO: when the game executes all whiteboard moves at turn end applying the future map
// will fail because we are currently executing actions, and if one of those actions
// was a movement of the leader this function will be called, resulting the the error
// mesage below, we silence that message for now by adding (!executing_actions_)
//
// Also this check is generally flawed, for example it could happen that the leader found
// by find_backup_leader would be moved to that location _after_ the unit would be recruited
// It could also happen that the original leader can be moved back to that location before
// the unit is recruited.
if(!has_planned_unit_map() && !executing_actions_) {
WRN_WB << "Unable to build future map to determine whether leader's allowed to move." << std::endl;
}
if(find_backup_leader(leader))