0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix version_info ctor calls expecting the sane parameter

Browse source 
The sane parameter was removed in commit
02a31a5b89, but I did not realize that
`false` would still be implicitly cast to char and invoke the usual list
constructor.

Fix this by using the default constructor instead, which does what we
want sans removed parameter.

Note that this mistake and subsequent fix has no bearing on anything
other than code presentation because false and '\0' are the same value
and the three number values are 0 with the default ctor too.
This commit is contained in:
Ignacio R. Morelle 2015-08-18 03:50:31 -03:00
parent c36bb4c5d0
commit 5108fa05ad
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/addon/manager.cpp
View file

@ -381,7 +381,7 @@ void refresh_addon_version_info_cache()
version_info get_addon_version_info(const std::string& addon)
{
static const version_info nil(0,0,0,false);
static const version_info nil;
std::map< std::string, version_info >::iterator entry = version_info_cache.find(addon);
return entry != version_info_cache.end() ? entry->second : nil;
}

2
src/addon/state.cpp
View file

@ -29,7 +29,7 @@ addon_tracking_info get_addon_tracking_info(const addon_info& addon)
t.can_publish = have_addon_pbl_info(id);
t.in_version_control = have_addon_in_vcs_tree(id);
t.installed_version = version_info(0, 0, 0, false);
//t.installed_version = version_info();
if(is_addon_installed(id)) {
if(t.can_publish) {