0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix a bug with auto-stored WML variables...

Browse source 
...not being restored correctly to their previous state afterwards
(spotted by silene)
This commit is contained in:
Patrick Parker 2009-04-05 19:07:06 +00:00
parent 0883510e03
commit 4ffceb57a8
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/variable.cpp
View file

@ -474,9 +474,8 @@ scoped_wml_variable::scoped_wml_variable(const std::string& var_name) :
void scoped_wml_variable::store(const config& var_value)
{
// FIXME: this code isn't correct, as it concats all the children.
foreach (const config &i, repos->get_variables().child_range(var_name_)) {
previous_val_.append(i);
previous_val_.add_child(var_name_, i);
}
repos->clear_variable_cfg(var_name_);
repos->add_variable_cfg(var_name_, var_value);
@ -488,7 +487,6 @@ scoped_wml_variable::~scoped_wml_variable()
{
if(activated_) {
repos->clear_variable_cfg(var_name_);
// FIXME: this code isn't correct, as previous_val_ doesn't contain a var_name_ child.
foreach (const config &i, previous_val_.child_range(var_name_)) {
repos->add_variable_cfg(var_name_, i);
}