0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

eclipse plugin: Use StringBuilder instead of simple string concatenation

Browse source 
Issue found by "FindBugs"
This commit is contained in:
Timotei Dolean 2011-04-10 10:33:54 +00:00
parent ecbb07ab16
commit 4c519f177a
1 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
utils/java/org.wesnoth/src/org/wesnoth/utils/ListUtils.java
View file

@ -23,13 +23,14 @@ public class ListUtils
{
if (list == null || list.isEmpty())
return ""; //$NON-NLS-1$
String result = ""; //$NON-NLS-1$
StringBuilder result = new StringBuilder(); //$NON-NLS-1$
for (int i = 0; i < list.size() - 1; i++)
{
result += (list.get(i) + separator);
result.append(list.get(i) + separator);
}
result += list.get(list.size() - 1);
return result;
result.append(list.get(list.size() - 1));
return result.toString();
}
/**
@ -44,12 +45,13 @@ public class ListUtils
if (array == null || array.length == 0)
return ""; //$NON-NLS-1$
String result = ""; //$NON-NLS-1$
StringBuilder result = new StringBuilder(); //$NON-NLS-1$
for (int i = 0; i < array.length - 1; i++)
{
result += (array[i] + separator);
result.append(array[i] + separator);
}
result += array[array.length - 1];
return result;
result.append(array[array.length - 1]);
return result.toString();
}
}