0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix wrong comment handling in wmllint

Browse source 
A comment containing a string [advancefrom] was causing wmllint to get confused

../../data/campaigns/Dead_Water/scenarios/06_Uncharted_Islands.cfg, line 22: [advancefrom] needs to be manually updated to [modify_unit_type] and moved into the _main.cfg file
This commit is contained in:
Andrey Bienkowski 2021-01-14 22:40:51 +03:00
parent 92fedf8f2a
commit 48d001add7
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
data/tools/wmllint
View file

@ -1804,13 +1804,14 @@ def global_sanity_check(filename, lines):
# Because we can't be sure about what the UMC author wants to do, just warn
in_campaign = False
for num, line in enumerate(lines, start=1):
if "[campaign]" in line:
precomment = line.split("#")[0]
if "[campaign]" in precomment:
in_campaign = True
continue
if "[/campaign]" in line:
if "[/campaign]" in precomment:
in_campaign = False
continue
if has_opening_tag(line, "advancefrom"):
if has_opening_tag(precomment, "advancefrom"):
print("{}, line {}: [advancefrom] needs to be manually updated to \
[modify_unit_type] and moved into the _main.cfg file".format(filename, num))
if in_campaign: