0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix #2339: iterating wesnoth.unit_types is extremely slow

Browse source 
The problem was that the code copied the entire list of unit types every
time Lua moved to the next unit type. Fixed by taking a reference to it
instead.

Thanks to @ilyapopov for identifying the problem.
This commit is contained in:
Jyrki Vesterinen 2018-01-31 19:50:10 +02:00
parent 7a6c39380e
commit 4685aed6a5
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/scripting/lua_unit_type.cpp
View file

@ -135,8 +135,8 @@ static int impl_unit_type_count(lua_State* L)
static int impl_unit_type_next(lua_State* L)
{
const unit_type* base = *static_cast<const unit_type**>(luaL_checkudata(L, 1, UnitTypeTable));
auto unit_map = base ? base->variation_types() : unit_types.types();
decltype(unit_map)::const_iterator it = unit_map.end();
const auto& unit_map = base ? base->variation_types() : unit_types.types();
auto it = unit_map.end();
if(lua_isnoneornil(L, 2)) {
if(base) {
if(base->has_gender_variation(unit_race::MALE)) {