0ct0pu5/wesnoth
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix crash on unit animations #5032

Browse source 
I don't really know how this code supposed to code work, i just
added a guard against possible UB there.
This commit is contained in:
gfgtdf 2023-03-21 20:07:04 +01:00
parent 7fe5d09745
commit 43fc79235a
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/units/animation.cpp
View file

@ -1432,6 +1432,9 @@ bool unit_animator::would_end() const
void unit_animator::wait_until(int animation_time) const
{
if(animated_units_.empty()) {
return;
}
// important to set a max animation time so that the time does not go past this value for movements.
// fix for bug #1565
animated_units_[0].my_unit->anim_comp().get_animation()->set_max_animation_time(animation_time);
@ -1474,11 +1477,17 @@ void unit_animator::wait_for_end() const
int unit_animator::get_animation_time() const
{
if(animated_units_.empty()) {
return 0;
}
return animated_units_[0].my_unit->anim_comp().get_animation()->get_animation_time() ;
}
int unit_animator::get_animation_time_potential() const
{
if(animated_units_.empty()) {
return 0;
}
return animated_units_[0].my_unit->anim_comp().get_animation()->get_animation_time_potential() ;
}